New issue
Advanced search Search tips

Issue 616517 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.2% regression in smoothness.sync_scroll.key_mobile_sites_smooth at 396591:396610

Project Member Reported by briander...@chromium.org, Jun 1 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=616517

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgnMaFrAoM


Bot(s) for this bug's original alert(s):

android-nexus5
Cc: vmp...@chromium.org
Owner: vmp...@chromium.org

=== Auto-CCing suspected CL author vmpstr@chromium.org ===

Hi vmpstr@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : cc: Restore the space of interest area padding to be ideal contents space.
Author  : vmpstr
Commit description:
  
This patch ensures that the interest area padding we use is specified in
ideal contents scale, not in screen scale. Effectively this means that
on devices with content scale > 1, we will have a smaller interest area.

This restores the behavior that was changed when the calculation was
moved to the tiling set.

R=ericrk, enne
BUG=614990
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2022613002
Cr-Commit-Position: refs/heads/master@{#396602}
Commit  : 55a6f3c6ead8ab53ff8b0a1ea5953971d3e272a3
Date    : Fri May 27 23:46:35 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@396590  26.2568  1.01365   8  good
chromium@396600  25.3704  0.297579  5  good
chromium@396601  25.232   0.464964  5  good
chromium@396602  26.8262  0.32151   5  bad    <--
chromium@396603  27.0012  0.637059  5  bad
chromium@396605  27.5618  0.479229  5  bad
chromium@396610  27.537   0.539956  8  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 616517

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.sync_scroll.key_mobile_sites_smooth
Test Metric: mean_input_event_latency/http___shop.mobileweb.ebay.com_searchresults?kw_viking+helmet
Relative Change: 3.06%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3711
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011037757628047248


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5847185447452672

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: WontFix (was: Assigned)
This patch reduces the prepaint region significantly, which recovers a lot of the memory regression it introduced (see crbug.com/614990). This can also cause small degradation in performance since we don't prepaint as much. 

I'm going to mark this as WontFix, but feel free to change that if you feel differently. 

Sign in to add a comment