New issue
Advanced search Search tips

Issue 616515 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.3% regression in speedometer at 396768:396783

Project Member Reported by briander...@chromium.org, Jun 1 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=616515

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgnPaiuwoM


Bot(s) for this bug's original alert(s):

win-zenbook
Cc: yosin@chromium.org
Owner: yosin@chromium.org

=== Auto-CCing suspected CL author yosin@chromium.org ===

Hi yosin@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Move VisibleSelection::nonBoundaryShadowTreeRootNode() to FrameSelection.cpp
Author  : yosin
Commit description:
  
This patch moves a member function |nonBoundaryShadowTreeRootNode()| in
|VisibleSelection| to "FrameSelection.cpp", where only the place uses it,
to simplify |VisibleSelection| class for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2023793002
Cr-Commit-Position: refs/heads/master@{#396783}
Commit  : ed9fa2dc442523095d1cb8dcd2cf21db292adc34
Date    : Tue May 31 04:26:41 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@396767  7274.48  405.663  18  good
chromium@396775  6529.74  129.359  5   good
chromium@396779  6517.67  157.827  5   good
chromium@396781  6936.97  104.18   5   good
chromium@396782  6553.45  118.12   5   good
chromium@396783  9058.77  2518.64  18  bad    <--

Bisect job ran on: winx64_zen_perf_bisect
Bug ID: 616515

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: Total/Total
Relative Change: 4.62%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_zen_perf_bisect/builds/174
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011037854495974128


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5800387752230912

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: bmeu...@chromium.org mvstan...@chromium.org
Status: WontFix (was: Assigned)
The patch in #2 looks harmless and the regression is very small. Going to close as WontFix.

Sign in to add a comment