New issue
Advanced search Search tips

Issue 616504 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 581111



Sign in to add a comment

DevTools: restore the dominators view

Project Member Reported by paulir...@chromium.org, Jun 1 2016

Issue description

We removed it because we thought it was never used.

It comes up so frequently that it seems that the majority of people doing memory debugging wants that view.

It seems like we're already calculating it, but just not exposing it in the UI. Can we restore?


FWIW, our CL removing dominators from the tool (june 2014): https://codereview.chromium.org/352603003
Attached is FF's dominators view
 
firefox-dominators (1).png
413 KB View Download
FWIW, it may get asked about since we still have documentation for it live! We maybe want to asses *why* it is asked for and verify people were actively using it.

Comment 2 by alph@chromium.org, Jun 8 2016

Cc: pfeldman@chromium.org
Labels: -Type-Bug Type-Feature
Do you have a success story from people using it?
I remember the view was very frustrating and hard to explain.
Old comments on Firefox's memory tools launch (https://news.ycombinator.com/item?id=10553899)
> It does not seem to support a dominator tree view. That will be missed for serious investigations.
> Chrome's tool supports a dominator tree view. Sorry, also I'm excited to see a memory usage tool for firefox is now available. Supporting a dominator tree view is IMHO a crucial feature you will need sooner or later for investigating memory usage issues. The predecessor to the Eclipse Memory Analyzer had that in 2006/2007.


Dominators being central to the canonical walkthrough of Eclipse's memory profiler: http://memoryanalyzer.blogspot.com/2008/05/automated-heap-dump-analysis-finding.html

WebKit takes a moment to introduce them alongside their brand new tools: https://webkit.org/blog/6425/memory-debugging-with-web-inspector/


Aside from this, it's something I've heard frequently from devs. Sam the Hat has used it and found it valuable. 
Status: Archived (was: Assigned)
Bulk DevTools triage, closing low priority issues with no action plan.

Sign in to add a comment