Android restore should restore sync preferences |
|||||||||
Issue descriptionIf a user signs in to Chrome then, by default, all types of sync are enabled; but the user has the ability to select what is synced. When a user switches to a new device we should not sync anything that was disabled for sync on the old device. Since these preferences clearly cannot themselves be synced, they should be saved and restored though Android backup and restore. From a private email discussion we believe the relevant preferences are: kSyncFirstSetupComplete kSyncKeepEverythingSynced kSyncAutofillProfile kSyncAutofillWallet kSyncAutofillWalletMetadata kSyncAutofill kSyncBookmarks kSyncDeviceInfo kSyncFaviconImages kSyncFaviconTracking kSyncHistoryDeleteDirectives kSyncPasswords kSyncPreferences kSyncPriorityPreferences kSyncSessions kSyncSupervisedUserSettings kSyncSupervisedUserSharedSettings kSyncSupervisedUserWhitelists kSyncTabs kSyncTypedUrls kSyncSuppressStart In addition we may need to restore kSyncEncryptionBootstrapToken kSyncKeystoreEncryptionBootstrapToken but this needs further investigation.
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 2 2016
Moved back to M-52. We really do need this in M-52 since we need this in ROM Android images asap.
,
Jun 2 2016
bauerb@ has pointed out that if a user has chosen to use a custom passphrase for sync encryption it is probably because they want some extra privacy over using their google credentials, so we probably don't want to save and restore it. As such we should not the encryption tokens, or anything else associated with the custom passphrase.
,
Jun 2 2016
Yeah, that's a good point. Nicolas, WDYT? Probably makes sense not to backup & restore the prefs necessary to generate the encryption key, right? The user will just have to enter their passphrase on their restored device?
,
Jun 3 2016
BTW bauerb@ also said that he thinks that restoring the custom password would require restoring some of the data stored outside the preference file. This seems to be confirmed by my testing, in which I restored the all the apparently relevant preferences, and still got the passphrase notification. I have not investigated exactly what additional data would be required.
,
Jun 6 2016
,
Jun 6 2016
ReleaseBlock-Stable to ensure visibility
,
Jun 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afa2077192b4c38c3f828c29628c54f0339f3534 commit afa2077192b4c38c3f828c29628c54f0339f3534 Author: aberent <aberent@chromium.org> Date: Tue Jun 07 10:34:46 2016 [Android backup] Sync settings, and new to old version restore Backup and restore the sync settings. Also enable restore to an older version of Chrome than the backed up version. BUG= 616477 BUG=613205 Review-Url: https://codereview.chromium.org/2047473003 Cr-Commit-Position: refs/heads/master@{#398267} [modify] https://crrev.com/afa2077192b4c38c3f828c29628c54f0339f3534/chrome/android/java/AndroidManifest.xml [modify] https://crrev.com/afa2077192b4c38c3f828c29628c54f0339f3534/chrome/android/java/res_template/xml/chromebackupscheme.xml [modify] https://crrev.com/afa2077192b4c38c3f828c29628c54f0339f3534/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java [modify] https://crrev.com/afa2077192b4c38c3f828c29628c54f0339f3534/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java [modify] https://crrev.com/afa2077192b4c38c3f828c29628c54f0339f3534/chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java
,
Jun 7 2016
,
Jun 7 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a5946faf7a8ec6a933f9f667499c314d6ce5694 commit 9a5946faf7a8ec6a933f9f667499c314d6ce5694 Author: Anthony Berent <aberent@chromium.org> Date: Wed Jun 08 09:02:35 2016 [Android backup] Sync settings, and new to old version restore Backup and restore the sync settings. Also enable restore to an older version of Chrome than the backed up version. BUG= 616477 BUG=613205 Review-Url: https://codereview.chromium.org/2047473003 Cr-Commit-Position: refs/heads/master@{#398267} (cherry picked from commit afa2077192b4c38c3f828c29628c54f0339f3534) Review URL: https://codereview.chromium.org/2043303002 . Cr-Commit-Position: refs/branch-heads/2743@{#277} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/9a5946faf7a8ec6a933f9f667499c314d6ce5694/chrome/android/java/AndroidManifest.xml [modify] https://crrev.com/9a5946faf7a8ec6a933f9f667499c314d6ce5694/chrome/android/java/res_template/xml/chromebackupscheme.xml [modify] https://crrev.com/9a5946faf7a8ec6a933f9f667499c314d6ce5694/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java [modify] https://crrev.com/9a5946faf7a8ec6a933f9f667499c314d6ce5694/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java [modify] https://crrev.com/9a5946faf7a8ec6a933f9f667499c314d6ce5694/chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java
,
Jun 8 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a5946faf7a8ec6a933f9f667499c314d6ce5694 commit 9a5946faf7a8ec6a933f9f667499c314d6ce5694 Author: Anthony Berent <aberent@chromium.org> Date: Wed Jun 08 09:02:35 2016 [Android backup] Sync settings, and new to old version restore Backup and restore the sync settings. Also enable restore to an older version of Chrome than the backed up version. BUG= 616477 BUG=613205 Review-Url: https://codereview.chromium.org/2047473003 Cr-Commit-Position: refs/heads/master@{#398267} (cherry picked from commit afa2077192b4c38c3f828c29628c54f0339f3534) Review URL: https://codereview.chromium.org/2043303002 . Cr-Commit-Position: refs/branch-heads/2743@{#277} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/9a5946faf7a8ec6a933f9f667499c314d6ce5694/chrome/android/java/AndroidManifest.xml [modify] https://crrev.com/9a5946faf7a8ec6a933f9f667499c314d6ce5694/chrome/android/java/res_template/xml/chromebackupscheme.xml [modify] https://crrev.com/9a5946faf7a8ec6a933f9f667499c314d6ce5694/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java [modify] https://crrev.com/9a5946faf7a8ec6a933f9f667499c314d6ce5694/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java [modify] https://crrev.com/9a5946faf7a8ec6a933f9f667499c314d6ce5694/chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ew...@chromium.org
, Jun 1 2016