New issue
Advanced search Search tips

Issue 616453 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Relax MALI_MIDGARD build restrictions after exporting destroy_hrtimer_on_stack()

Project Member Reported by groeck@chromium.org, Jun 1 2016

Issue description

We could previously not build MALI_MIDGARD with DEBUG_OBJECTS_TIMERS enabled because it needs destroy_hrtimer_on_stack(), which was not exported.

destroy_hrtimer_on_stack() is now exported upstream with commit c08376ac97cb2. We can cherry-pick this commit and relax the build restrictions.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2016

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/689fd0ba8a11e61592addc5655a548ba4e314352

commit 689fd0ba8a11e61592addc5655a548ba4e314352
Author: Guenter Roeck <groeck@chromium.org>
Date: Wed Jun 01 13:55:17 2016

CHROMIUM: gpu: Relax MALI_MIDGARD build restrictions

We could previously not build MALI_MIDGARD with DEBUG_OBJECTS_TIMERS
enabled because it needs destroy_hrtimer_on_stack(), which was not
exported.

destroy_hrtimer_on_stack() is now exported upstream with commit
c08376ac97cb2. After cherry-picking this commit, we can relax
the build restrictions.

BUG= chromium:616453 
TEST=Build with both MALI_MIDGARD and DEBUG_OBJECTS_TIMERS enabled

Change-Id: I400fef4d07c0a0ba7b15db530c9c2c78691c39c2
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/348473
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/689fd0ba8a11e61592addc5655a548ba4e314352/drivers/gpu/arm/midgard/Kconfig

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/f73f409fe46e99d22df5e995c55c03fed80ebd54

commit f73f409fe46e99d22df5e995c55c03fed80ebd54
Author: Guenter Roeck <linux@roeck-us.net>
Date: Fri May 27 00:21:05 2016

UPSTREAM: timer: Export destroy_hrtimer_on_stack()

hrtimer_init_on_stack() needs a matching call to
destroy_hrtimer_on_stack(), so both need to be exported.

BUG= chromium:616453 
TEST=Build with both MALI_MIDGARD and DEBUG_OBJECTS_TIMERS enabled

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit c08376ac97cb202ec65320f3d90d5c4c5e2adb0b)
Signed-off-by: Guenter Roeck <groeck@chromium.org>

Change-Id: I6183096c7080a5e3248c05ef948b1be1c8e5e68d
Reviewed-on: https://chromium-review.googlesource.com/348472
Commit-Ready: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/f73f409fe46e99d22df5e995c55c03fed80ebd54/kernel/time/hrtimer.c

Status: Verified (was: Started)

Sign in to add a comment