New issue
Advanced search Search tips

Issue 616452 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Removing a failure entry in third_party/WebKit/LayoutTests/TestExpectations doesn't trigger bot to run

Project Member Reported by xidac...@chromium.org, Jun 1 2016 
Please refer to PS#1 in this CL:
https://codereview.chromium.org/2029573002/#ps1

I removed an entry in the TestExpectations file, the *_blink_dbg bots should run all the layout tests to confirm that. But the bots don't run the tests at all.

Comment 1 by xidac...@chromium.org, Jun 1 2016 

I had to add a blank line in a source file so that the bots can run.

Comment 2 by qyears...@chromium.org, Mar 6 2017

Labels: -OS-All
Owner: qyears...@chromium.org
Status: Started (was: Available)
Summary: Removing a failure entry in third_party/WebKit/LayoutTests/TestExpectations doesn't trigger bot to run (was: Remove a failure entry in third_party/WebKit/LayoutTests/TestExpectations doesn't trigger bot to run)
AFAIK, whether these try bots run the "webkit_tests (with patch)" step depends on the "data" part of the webkit_layout_tests entry in BUILD.gn (https://chromium.googlesource.com/chromium/src/+/fbb72741a769f768299bdeb7865dac5785ce1fd9/BUILD.gn#913).

BUILD.gn was changed after this bug was filed, now verifying to see whether this is now fixed: https://codereview.chromium.org/2735833002

Comment 3 by qyears...@chromium.org, Mar 6 2017

Status: Fixed (was: Started)
Just trying it out in https://codereview.chromium.org/2735833002, and it looks like this is now fixed; layout tests are being run for a single change in TestExpectations.
►

Sign in to add a comment