GN build for gles2_conform_test is broken on Windows and Mac |
||
Issue descriptionCurrently the BUILD.gn file is trying to redeclare 'defines' for 'gles2_conform_test_windowless', and on Windows is trying to remove NOMINMAX defines. The former should be replaced with += and the latter should be replaced with the appropriate config subtraction. This is breaking the Clang GPU FYI bot on Windows since we switched to GN.
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efdfa08bead0343980fb6bb8e9a8ef5a9b096bbf commit efdfa08bead0343980fb6bb8e9a8ef5a9b096bbf Author: jmadill <jmadill@chromium.org> Date: Wed Jun 01 22:05:17 2016 Fix Win/GN build of GLES2-CTS. The egl_native_win.cc file was missing a necessary include annotation. Also remove a spurious windows source file. This break was only visible when running with gn gen <dir> --check, which wasn't visible until seen on the bots. BUG= 616449 TBR=kbr@chromium.org,sievers@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2032673002 Cr-Commit-Position: refs/heads/master@{#397265} [modify] https://crrev.com/efdfa08bead0343980fb6bb8e9a8ef5a9b096bbf/gpu/gles2_conform_support/BUILD.gn [modify] https://crrev.com/efdfa08bead0343980fb6bb8e9a8ef5a9b096bbf/gpu/gles2_conform_support/native/egl_native_win.cc
,
Jun 2 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2016