New issue
Advanced search Search tips

Issue 616447 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 618793
issue 641142

Blocking:
issue 553459



Sign in to add a comment

Stop using deprecated MessageLoop methods

Project Member Reported by fdoray@chromium.org, Jun 1 2016

Issue description

The following MessageLoop methods are deprecated and should no longer be used:

- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon

The following replacements should be made:

MessageLoop::current()->PostTask -> ThreadTaskRunnerHandle::Get()->PostTask
                        PostDelayedTask                            PostDelayedTask
                        DeleteSoon                                 DeleteSoon
                        ReleaseSoon                                ReleaseSoon

MessageLoop::current()->task_runner() -> ThreadTaskRunnerHandle::Get()

|message_loop|->PostTask -> |message_loop|->task_runner()->PostTask
                PostDelayedTask                            PostDelayedTask
                DeleteSoon                                 DeleteSoon
                ReleaseSoon                                ReleaseSoon

 
Showing comments 103 - 202 of 202 Older
Project Member

Comment 103 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13b955d465a1e4ce91961710091c7707f38a9d98

commit 13b955d465a1e4ce91961710091c7707f38a9d98
Author: fdoray <fdoray@chromium.org>
Date: Tue Jun 14 17:47:08 2016

Remove MessageLoop::current()->task_runner() in ui.

This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in ui.

In files where this replacement is made, it adds these include:
  #include "base/threading/thread_task_runner_handle.h"
  #include "base/location.h" (if required)
  #include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.

Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2054573002
Cr-Commit-Position: refs/heads/master@{#399739}

[modify] https://crrev.com/13b955d465a1e4ce91961710091c7707f38a9d98/ui/accelerated_widget_mac/display_link_mac.cc
[modify] https://crrev.com/13b955d465a1e4ce91961710091c7707f38a9d98/ui/base/test/windowed_nsnotification_observer.mm
[modify] https://crrev.com/13b955d465a1e4ce91961710091c7707f38a9d98/ui/snapshot/screenshot_grabber.cc
[modify] https://crrev.com/13b955d465a1e4ce91961710091c7707f38a9d98/ui/views/widget/native_widget_mac_unittest.mm

Project Member

Comment 104 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f59fabf98d3f1a283ff5b13a2baa6f757edc274

commit 5f59fabf98d3f1a283ff5b13a2baa6f757edc274
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 15 16:01:03 2016

Remove use of deprecated MessageLoop methods in components.

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=caitkp@chromium.org

Review-Url: https://codereview.chromium.org/2037843002
Cr-Commit-Position: refs/heads/master@{#399909}

[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/browsing_data/conditional_cache_deletion_helper.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/browsing_data/storage_partition_http_cache_data_remover.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/browsing_data_ui/history_notice_utils.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/dom_distiller/content/browser/distillable_page_utils_android.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/dom_distiller/content/browser/dom_distiller_viewer_source.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/dom_distiller/core/distiller.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/dom_distiller/core/dom_distiller_service.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/dom_distiller/core/task_tracker.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/mus/public/cpp/tests/window_server_test_base.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/ownership/owner_settings_service.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/pairing/fake_controller_pairing_controller.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/pairing/fake_host_pairing_controller.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/password_manager/content/browser/credential_manager_impl_unittest.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/safe_browsing_db/database_manager_unittest.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/safe_json/testing_json_parser.cc
[modify] https://crrev.com/5f59fabf98d3f1a283ff5b13a2baa6f757edc274/components/timers/alarm_timer_unittest.cc

Project Member

Comment 105 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6be72adffd58d7b87f47ab6ea69e1985e808f272

commit 6be72adffd58d7b87f47ab6ea69e1985e808f272
Author: fdoray <fdoray@chromium.org>
Date: Thu Jun 16 17:46:41 2016

Restore calls to MessageLoopForUI::current() in chrome/.

Some calls to MessageLoopForUI::current()->PostTask/DeleteSoon were
wrongly migrated to ThreadTaskRunnerHandle::Get() by
https://codereview.chromium.org/2033753002/ (see discussion at
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/Wj_cNO2l2qE/1XWt_Ex1AgAJ)

This CL migrates these calls to
MessageLoopForUI::current()->task_runner()->PostTask/DeleteSoon instead.

BUG=616447

Review-Url: https://codereview.chromium.org/2052603002
Cr-Commit-Position: refs/heads/master@{#400194}

[modify] https://crrev.com/6be72adffd58d7b87f47ab6ea69e1985e808f272/chrome/browser/chromeos/login/easy_unlock/easy_unlock_reauth.cc
[modify] https://crrev.com/6be72adffd58d7b87f47ab6ea69e1985e808f272/chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc
[modify] https://crrev.com/6be72adffd58d7b87f47ab6ea69e1985e808f272/chrome/browser/chromeos/login/test/wizard_in_process_browser_test.cc
[modify] https://crrev.com/6be72adffd58d7b87f47ab6ea69e1985e808f272/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
[modify] https://crrev.com/6be72adffd58d7b87f47ab6ea69e1985e808f272/chrome/browser/ui/ash/media_delegate_chromeos.cc
[modify] https://crrev.com/6be72adffd58d7b87f47ab6ea69e1985e808f272/chrome/browser/ui/views/chrome_views_delegate.cc

Project Member

Comment 106 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcb9b32ec79d574c921ba5ad8b9405d99d9d5f86

commit bcb9b32ec79d574c921ba5ad8b9405d99d9d5f86
Author: fdoray <fdoray@chromium.org>
Date: Mon Jun 20 20:23:32 2016

Remove calls to MessageLoop::current() in ipc.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2080423002
Cr-Commit-Position: refs/heads/master@{#400762}

[modify] https://crrev.com/bcb9b32ec79d574c921ba5ad8b9405d99d9d5f86/ipc/ipc_logging.cc
[modify] https://crrev.com/bcb9b32ec79d574c921ba5ad8b9405d99d9d5f86/ipc/ipc_logging.h
[modify] https://crrev.com/bcb9b32ec79d574c921ba5ad8b9405d99d9d5f86/ipc/ipc_sync_channel_unittest.cc

Project Member

Comment 107 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af82da320b8ef3521fd6fbf0e999e66097e2ed24

commit af82da320b8ef3521fd6fbf0e999e66097e2ed24
Author: fdoray <fdoray@chromium.org>
Date: Tue Jun 21 12:43:12 2016

Use ThreadTaskRunnerHandle::Get() in dbus.

Replace MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in dbus.

Why?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

BUG=616447

Review-Url: https://codereview.chromium.org/2082653002
Cr-Commit-Position: refs/heads/master@{#400969}

[modify] https://crrev.com/af82da320b8ef3521fd6fbf0e999e66097e2ed24/dbus/bus.cc

Project Member

Comment 108 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7ca8b710dcd9f45e852ceea546b5de96e8d7ca3

commit f7ca8b710dcd9f45e852ceea546b5de96e8d7ca3
Author: fdoray <fdoray@chromium.org>
Date: Tue Jun 21 14:00:26 2016

Remove calls to MessageLoop::current() in sync.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=maxbogue@chromium.org

Review-Url: https://codereview.chromium.org/2083713002
Cr-Commit-Position: refs/heads/master@{#400983}

[modify] https://crrev.com/f7ca8b710dcd9f45e852ceea546b5de96e8d7ca3/sync/internal_api/http_bridge.cc
[modify] https://crrev.com/f7ca8b710dcd9f45e852ceea546b5de96e8d7ca3/sync/internal_api/http_bridge_unittest.cc
[modify] https://crrev.com/f7ca8b710dcd9f45e852ceea546b5de96e8d7ca3/sync/internal_api/public/engine/model_safe_worker.cc
[modify] https://crrev.com/f7ca8b710dcd9f45e852ceea546b5de96e8d7ca3/sync/internal_api/public/engine/model_safe_worker.h
[modify] https://crrev.com/f7ca8b710dcd9f45e852ceea546b5de96e8d7ca3/sync/internal_api/public/http_bridge.h

Project Member

Comment 109 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2

commit c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2
Author: fdoray <fdoray@chromium.org>
Date: Tue Jun 21 17:35:40 2016

Remove calls to MessageLoop::current() in ios.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=droger@chromium.org

Review-Url: https://codereview.chromium.org/2079423002
Cr-Commit-Position: refs/heads/master@{#401027}

[modify] https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2/ios/crnet/crnet_environment.mm
[modify] https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2/ios/web/web_thread_impl.cc

Project Member

Comment 110 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9d291f3d13f4691eb24ae93b4a23d091125e972

commit b9d291f3d13f4691eb24ae93b4a23d091125e972
Author: fdoray <fdoray@chromium.org>
Date: Tue Jun 21 17:36:24 2016

Remove calls to MessageLoop::current() in mojo.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2080923002
Cr-Commit-Position: refs/heads/master@{#401028}

[modify] https://crrev.com/b9d291f3d13f4691eb24ae93b4a23d091125e972/mojo/message_pump/handle_watcher.cc

Project Member

Comment 111 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/038016b7d0e4e1356bcc5a01ba9a78ed3f8b9151

commit 038016b7d0e4e1356bcc5a01ba9a78ed3f8b9151
Author: fdoray <fdoray@chromium.org>
Date: Tue Jun 21 17:40:40 2016

Remove calls to MessageLoop::current() in jingle.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=sergeyu@chromium.org

Review-Url: https://codereview.chromium.org/2088433002
Cr-Commit-Position: refs/heads/master@{#401032}

[modify] https://crrev.com/038016b7d0e4e1356bcc5a01ba9a78ed3f8b9151/jingle/glue/proxy_resolving_client_socket.cc
[modify] https://crrev.com/038016b7d0e4e1356bcc5a01ba9a78ed3f8b9151/jingle/notifier/base/xmpp_connection.cc

Project Member

Comment 112 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10eaa01bf64c5dad1cb2a216803fbe3680672d34

commit 10eaa01bf64c5dad1cb2a216803fbe3680672d34
Author: fdoray <fdoray@chromium.org>
Date: Tue Jun 21 18:03:34 2016

Remove calls to MessageLoop::current() in remoting.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=garykac@chromium.org

Review-Url: https://codereview.chromium.org/2080343003
Cr-Commit-Position: refs/heads/master@{#401042}

[modify] https://crrev.com/10eaa01bf64c5dad1cb2a216803fbe3680672d34/remoting/host/setup/start_host_main.cc

Project Member

Comment 113 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/095043f0fe0cde2aedd7bd5708c5fee543166c29

commit 095043f0fe0cde2aedd7bd5708c5fee543166c29
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 13:20:43 2016

Remove calls to deprecated MessageLoop methods in ppapi.

This CL makes the following replacements in
ppapi:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=bbudge@chromium.org

Review-Url: https://codereview.chromium.org/2087923003
Cr-Commit-Position: refs/heads/master@{#401268}

[modify] https://crrev.com/095043f0fe0cde2aedd7bd5708c5fee543166c29/ppapi/proxy/ppb_testing_proxy.cc

Project Member

Comment 114 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eeb764832f20a297cdce834432ebfe44acc59d2

commit 5eeb764832f20a297cdce834432ebfe44acc59d2
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 16:11:28 2016

Remove calls to deprecated MessageLoop methods in net.

This CL makes the following replacements in
net:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=agl@chromium.org

Review-Url: https://codereview.chromium.org/2090613002
Cr-Commit-Position: refs/heads/master@{#401297}

[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/base/network_config_watcher_mac.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/disk_cache/disk_cache_test_util.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/dns/dns_config_service_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/dns/dns_transaction_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/dns/host_resolver_impl_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/dns/serial_worker_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/http/http_cache_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/http/http_response_body_drainer_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/proxy/mock_proxy_script_fetcher.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/proxy/proxy_resolver_v8_tracing_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/proxy/proxy_resolver_v8_tracing_wrapper_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/socket/ssl_server_socket_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/test/embedded_test_server/embedded_test_server_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/tools/gdig/gdig.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/tools/quic/synchronous_host_resolver.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/url_request/url_request_context_builder_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/url_request/url_request_job_factory_impl_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/url_request/url_request_job_unittest.cc
[modify] https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2/net/url_request/url_request_unittest.cc

Project Member

Comment 115 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6e6599ff56aba98213244468b3e5e6ac6bd316b

commit e6e6599ff56aba98213244468b3e5e6ac6bd316b
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 16:49:44 2016

Remove calls to deprecated MessageLoop methods in device.

This CL makes the following replacements in
device:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2090043003
Cr-Commit-Position: refs/heads/master@{#401306}

[modify] https://crrev.com/e6e6599ff56aba98213244468b3e5e6ac6bd316b/device/power_save_blocker/power_save_blocker_mac.cc
[modify] https://crrev.com/e6e6599ff56aba98213244468b3e5e6ac6bd316b/device/serial/serial_service_unittest.cc

Project Member

Comment 116 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974

commit 2edf4dd2c1b1d4f217025e1cbb50479c32e7a974
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 17:09:02 2016

Remove calls to deprecated MessageLoop methods in extensions.

This CL makes the following replacements in
extensions:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2090063002
Cr-Commit-Position: refs/heads/master@{#401317}

[modify] https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974/extensions/browser/api/alarms/alarms_api_unittest.cc
[modify] https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
[modify] https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974/extensions/browser/api/storage/storage_frontend_unittest.cc
[modify] https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974/extensions/browser/extension_icon_image_unittest.cc
[modify] https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974/extensions/browser/file_reader.cc
[modify] https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974/extensions/browser/file_reader_unittest.cc
[modify] https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974/extensions/browser/image_loader_unittest.cc
[modify] https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974/extensions/browser/quota_service_unittest.cc
[modify] https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974/extensions/browser/value_store/value_store_frontend_unittest.cc
[modify] https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974/extensions/renderer/gc_callback_unittest.cc
[modify] https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974/extensions/renderer/script_context_set_unittest.cc

Project Member

Comment 117 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/549ee967bfbd50b561383d723f357f1ded17f466

commit 549ee967bfbd50b561383d723f357f1ded17f466
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 17:33:03 2016

Remove calls to deprecated MessageLoop methods in rlz.

This CL makes the following replacements in
rlz:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2084913004
Cr-Commit-Position: refs/heads/master@{#401330}

[modify] https://crrev.com/549ee967bfbd50b561383d723f357f1ded17f466/rlz/lib/rlz_lib_test.cc

Project Member

Comment 118 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01c8157ece1ba00df660bdf8c17cf01bae3cd230

commit 01c8157ece1ba00df660bdf8c17cf01bae3cd230
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 18:49:15 2016

Remove calls to deprecated MessageLoop methods in tools.

This CL makes the following replacements in
tools:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2085023004
Cr-Commit-Position: refs/heads/master@{#401371}

[modify] https://crrev.com/01c8157ece1ba00df660bdf8c17cf01bae3cd230/tools/gn/loader.cc
[modify] https://crrev.com/01c8157ece1ba00df660bdf8c17cf01bae3cd230/tools/gn/loader_unittest.cc
[modify] https://crrev.com/01c8157ece1ba00df660bdf8c17cf01bae3cd230/tools/gn/scheduler.cc
[modify] https://crrev.com/01c8157ece1ba00df660bdf8c17cf01bae3cd230/tools/gn/setup.cc
[modify] https://crrev.com/01c8157ece1ba00df660bdf8c17cf01bae3cd230/tools/ipc_fuzzer/message_replay/replay_process.cc

Project Member

Comment 119 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/726c9d64f8f41c2755300409cf6e8c4918651f94

commit 726c9d64f8f41c2755300409cf6e8c4918651f94
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 18:50:26 2016

Remove calls to deprecated MessageLoop methods in ui.

This CL makes the following replacements in
ui:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2086093003
Cr-Commit-Position: refs/heads/master@{#401372}

[modify] https://crrev.com/726c9d64f8f41c2755300409cf6e8c4918651f94/ui/events/gesture_detection/gesture_provider_unittest.cc
[modify] https://crrev.com/726c9d64f8f41c2755300409cf6e8c4918651f94/ui/events/platform/platform_event_source_unittest.cc
[modify] https://crrev.com/726c9d64f8f41c2755300409cf6e8c4918651f94/ui/gfx/animation/animation_container_unittest.cc
[modify] https://crrev.com/726c9d64f8f41c2755300409cf6e8c4918651f94/ui/gfx/animation/animation_unittest.cc
[modify] https://crrev.com/726c9d64f8f41c2755300409cf6e8c4918651f94/ui/views/animation/bounds_animator_unittest.cc
[modify] https://crrev.com/726c9d64f8f41c2755300409cf6e8c4918651f94/ui/views/controls/menu/menu_controller_unittest.cc

Project Member

Comment 120 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68e6a5844a09c6410421210c95ba3c84b0b7cdff

commit 68e6a5844a09c6410421210c95ba3c84b0b7cdff
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 19:07:18 2016

Remove calls to deprecated MessageLoop methods in sync.

This CL makes the following replacements in
sync:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=maxbogue@chromium.org

Review-Url: https://codereview.chromium.org/2086363002
Cr-Commit-Position: refs/heads/master@{#401379}

[modify] https://crrev.com/68e6a5844a09c6410421210c95ba3c84b0b7cdff/sync/engine/sync_scheduler_unittest.cc
[modify] https://crrev.com/68e6a5844a09c6410421210c95ba3c84b0b7cdff/sync/internal_api/attachments/attachment_service_proxy_unittest.cc
[modify] https://crrev.com/68e6a5844a09c6410421210c95ba3c84b0b7cdff/sync/internal_api/http_bridge_unittest.cc
[modify] https://crrev.com/68e6a5844a09c6410421210c95ba3c84b0b7cdff/sync/internal_api/public/base/cancelation_signal_unittest.cc
[modify] https://crrev.com/68e6a5844a09c6410421210c95ba3c84b0b7cdff/sync/internal_api/public/util/weak_handle_unittest.cc
[modify] https://crrev.com/68e6a5844a09c6410421210c95ba3c84b0b7cdff/sync/internal_api/syncapi_server_connection_manager_unittest.cc
[modify] https://crrev.com/68e6a5844a09c6410421210c95ba3c84b0b7cdff/sync/tools/sync_client.cc
[modify] https://crrev.com/68e6a5844a09c6410421210c95ba3c84b0b7cdff/sync/tools/sync_listen_notifications.cc
[modify] https://crrev.com/68e6a5844a09c6410421210c95ba3c84b0b7cdff/sync/util/get_session_name_unittest.cc

Project Member

Comment 121 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b57365e023ea624c1441ab822319c183bb4bffc

commit 9b57365e023ea624c1441ab822319c183bb4bffc
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 19:55:33 2016

Remove calls to MessageLoop::current() in services.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2082513004
Cr-Commit-Position: refs/heads/master@{#401384}

[modify] https://crrev.com/9b57365e023ea624c1441ab822319c183bb4bffc/services/shell/background/background_shell.cc

Project Member

Comment 122 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e32586856127825431ad7c94bd70868d75fd6a8

commit 8e32586856127825431ad7c94bd70868d75fd6a8
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 19:56:16 2016

Remove calls to deprecated MessageLoop methods in ipc.

This CL makes the following replacements in
ipc:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2087163003
Cr-Commit-Position: refs/heads/master@{#401385}

[modify] https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8/ipc/attachment_broker_mac_unittest.cc
[modify] https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8/ipc/ipc_channel_posix_unittest.cc
[modify] https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8/ipc/ipc_channel_proxy_unittest.cc
[modify] https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8/ipc/ipc_channel_unittest.cc
[modify] https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8/ipc/ipc_fuzzing_tests.cc
[modify] https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8/ipc/ipc_perftest_support.cc
[modify] https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8/ipc/ipc_send_fds_test.cc
[modify] https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8/ipc/ipc_sync_channel_unittest.cc
[modify] https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8/ipc/mojo/ipc_channel_mojo_unittest.cc
[modify] https://crrev.com/8e32586856127825431ad7c94bd70868d75fd6a8/ipc/sync_socket_unittest.cc

Project Member

Comment 123 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18f8e78847f33a3ddcd979cd2f2ca952314de02a

commit 18f8e78847f33a3ddcd979cd2f2ca952314de02a
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 19:57:08 2016

Remove calls to deprecated MessageLoop methods in services.

This CL makes the following replacements in
services:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2091443002
Cr-Commit-Position: refs/heads/master@{#401386}

[modify] https://crrev.com/18f8e78847f33a3ddcd979cd2f2ca952314de02a/services/shell/runner/child/test_native_main.cc
[modify] https://crrev.com/18f8e78847f33a3ddcd979cd2f2ca952314de02a/services/shell/standalone/context.cc
[modify] https://crrev.com/18f8e78847f33a3ddcd979cd2f2ca952314de02a/services/shell/standalone/desktop/launcher_process.cc
[modify] https://crrev.com/18f8e78847f33a3ddcd979cd2f2ca952314de02a/services/shell/standalone/tracer.cc
[modify] https://crrev.com/18f8e78847f33a3ddcd979cd2f2ca952314de02a/services/tracing/public/cpp/trace_provider_impl.cc

Project Member

Comment 124 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ad58be9c95de52a6e6962c83df9099c8084ddae

commit 2ad58be9c95de52a6e6962c83df9099c8084ddae
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 20:36:16 2016

Remove calls to deprecated MessageLoop methods in remoting.

This CL makes the following replacements in
remoting:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=garykac@chromium.org

Review-Url: https://codereview.chromium.org/2082363002
Cr-Commit-Position: refs/heads/master@{#401392}

[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/base/auto_thread.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/base/auto_thread_task_runner_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/base/auto_thread_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/client/client_status_logger_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/host/daemon_process_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/host/host_change_notification_listener_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/host/host_status_logger_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/host/resizing_host_observer_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/host/setup/start_host_main.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/host/token_validator_factory_impl_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/protocol/authenticator_test_base.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/protocol/chromium_socket_factory_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/protocol/pseudotcp_adapter_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/protocol/spake2_authenticator_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/protocol/third_party_authenticator_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/protocol/v2_authenticator_unittest.cc
[modify] https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae/remoting/signaling/iq_sender_unittest.cc

MessageLoopDeprecatedMethods clang-tidy fix
MessageloopCheck.cpp
6.8 KB View Download
MessageloopCheck.h
1.3 KB View Download
ThreadmessageloopCheck.h
1.1 KB View Download
ThreadmessageloopCheck.cpp
1.6 KB View Download
Project Member

Comment 126 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c85099dabdd4ae0fe75c01f44b11278229dd3f80

commit c85099dabdd4ae0fe75c01f44b11278229dd3f80
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 20:55:34 2016

Remove calls to deprecated MessageLoop methods in components.

This CL makes the following replacements in
components:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=caitkp@chromium.org

Review-Url: https://codereview.chromium.org/2082333002
Cr-Commit-Position: refs/heads/master@{#401396}

[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/autofill/core/browser/autofill_download_manager_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/autofill/core/browser/webdata/web_data_service_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/browser_sync/browser/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/devtools_http_handler/devtools_http_handler.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/history/core/browser/history_backend.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/history/core/browser/history_querying_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/history/core/browser/history_service.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/history/core/browser/history_service_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/history/core/browser/top_sites_impl_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/history/core/test/history_backend_db_base_test.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/invalidation/impl/invalidation_notifier_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/invalidation/impl/non_blocking_invalidator_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/invalidation/impl/sync_invalidation_listener_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/invalidation/impl/sync_system_resources_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/nacl/loader/nacl_ipc_adapter_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/nacl/loader/nacl_listener.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/network_time/network_time_tracker.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/omnibox/browser/autocomplete_provider_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/omnibox/browser/history_quick_provider_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/omnibox/browser/history_url_provider_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/omnibox/browser/shortcuts_backend_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/omnibox/browser/shortcuts_provider_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/password_manager/core/browser/password_store_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/policy/core/common/async_policy_provider_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/policy/core/common/cloud/cloud_policy_refresh_scheduler_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/precache/core/fetcher_pool_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/proxy_config/pref_proxy_config_tracker_impl_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/ssl_config/ssl_config_service_manager_pref_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/storage_monitor/media_storage_util_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/storage_monitor/storage_monitor_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/sync_driver/glue/browser_thread_model_worker_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/sync_driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/sync_driver/glue/sync_backend_registrar_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/sync_driver/glue/ui_model_worker_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/test_runner/mock_screen_orientation_client.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/tracing/child/child_trace_message_filter_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/wallpaper/wallpaper_resizer_unittest.cc
[modify] https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80/components/wifi/wifi_test.cc

Project Member

Comment 127 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83f4a1ae815486cc99b983f4b38191da96b71c8e

commit 83f4a1ae815486cc99b983f4b38191da96b71c8e
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 21:05:44 2016

Remove calls to deprecated MessageLoop methods in jingle.

This CL makes the following replacements in
jingle:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=sergeyu@chromium.org

Review-Url: https://codereview.chromium.org/2082353002
Cr-Commit-Position: refs/heads/master@{#401400}

[modify] https://crrev.com/83f4a1ae815486cc99b983f4b38191da96b71c8e/jingle/glue/chrome_async_socket.cc
[modify] https://crrev.com/83f4a1ae815486cc99b983f4b38191da96b71c8e/jingle/glue/proxy_resolving_client_socket_unittest.cc
[modify] https://crrev.com/83f4a1ae815486cc99b983f4b38191da96b71c8e/jingle/glue/task_pump.cc
[modify] https://crrev.com/83f4a1ae815486cc99b983f4b38191da96b71c8e/jingle/glue/thread_wrapper_unittest.cc
[modify] https://crrev.com/83f4a1ae815486cc99b983f4b38191da96b71c8e/jingle/notifier/communicator/single_login_attempt_unittest.cc
[modify] https://crrev.com/83f4a1ae815486cc99b983f4b38191da96b71c8e/jingle/notifier/listener/non_blocking_push_client_unittest.cc
[modify] https://crrev.com/83f4a1ae815486cc99b983f4b38191da96b71c8e/jingle/notifier/listener/push_client_unittest.cc

Project Member

Comment 128 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70df5a951c7f1acc97104d985f8f25d7d9c96b31

commit 70df5a951c7f1acc97104d985f8f25d7d9c96b31
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 22 21:13:59 2016

Remove calls to deprecated MessageLoop methods in cc.

This CL makes the following replacements in
cc:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2082323002
Cr-Commit-Position: refs/heads/master@{#401405}

[modify] https://crrev.com/70df5a951c7f1acc97104d985f8f25d7d9c96b31/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/70df5a951c7f1acc97104d985f8f25d7d9c96b31/cc/test/layer_tree_test.cc

Project Member

Comment 129 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb32419d7ec55e6c37379c4f1d0e969eefe38f73

commit cb32419d7ec55e6c37379c4f1d0e969eefe38f73
Author: fdoray <fdoray@chromium.org>
Date: Thu Jun 23 15:52:55 2016

Remove calls to deprecated MessageLoop methods in chrome.

This CL makes the following replacements in
chrome:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2083363002
Cr-Commit-Position: refs/heads/master@{#401614}

[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/download/download_status_updater_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/api/storage/settings_sync_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/api/top_sites/top_sites_apitest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/app_data_migrator_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/extension_action_icon_factory_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/extension_icon_manager_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/extension_prefs_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/extension_protocols_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/extensions/extension_web_ui_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/importer/firefox_importer_browsertest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/importer/profile_writer_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/media/combined_desktop_media_list_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/media/native_desktop_media_list_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/media/tab_desktop_media_list_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/media_galleries/media_galleries_permissions_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/net/dns_probe_browsertest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/net/predictor_browsertest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/net/quota_policy_channel_id_store_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/password_manager/password_store_mac_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/policy/cloud/device_management_service_browsertest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/predictors/autocomplete_action_predictor_table_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/predictors/autocomplete_action_predictor_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/printing/cloud_print/privet_http_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/printing/cloud_print/privet_url_fetcher_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/printing/print_job.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/search_engines/template_url_fetcher_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/sync/test/integration/autofill_helper.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/sync/test/integration/status_change_checker.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/themes/theme_syncable_service_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/common/mac/mock_launchd.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/common/service_process_util_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/renderer/autofill/autofill_renderer_browsertest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/service/cloud_print/printer_job_handler.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/service/cloud_print/printer_job_handler_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/service/service_main.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/service/service_process_prefs_unittest.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/test/base/browser_with_test_window_test.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/utility/image_writer/disk_unmounter_mac.cc
[modify] https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc

Project Member

Comment 130 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6

commit cddcf0efb1c2f1050c9e90a6cb849d25576e74f6
Author: fdoray <fdoray@chromium.org>
Date: Thu Jun 23 21:20:30 2016

Remove calls to MessageLoop::current() in components.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=caitkp@chromium.org

Review-Url: https://codereview.chromium.org/2087583002
Cr-Commit-Position: refs/heads/master@{#401716}

[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/devtools_http_handler/devtools_http_handler.cc
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/invalidation/impl/sync_invalidation_listener_unittest.cc
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/invalidation/impl/sync_system_resources.cc
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/invalidation/impl/sync_system_resources.h
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/mus/common/gpu_service.cc
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/mus/common/gpu_service.h
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/mus/gpu/gpu_service_mus.cc
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/mus/gpu/gpu_service_mus.h
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/nacl/loader/nacl_listener.cc
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/nacl/loader/nacl_listener.h
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/policy/core/browser/browser_policy_connector.cc
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/sync_driver/glue/sync_backend_host_core.cc
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/sync_driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/sync_driver/glue/sync_backend_host_impl.h
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/variations/variations_http_header_provider.cc
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/webdata/common/web_data_request_manager.cc
[modify] https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6/components/webdata/common/web_data_request_manager.h

Project Member

Comment 131 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/156962f3287f15059fef4ee6b8f7eb2accd05c9a

commit 156962f3287f15059fef4ee6b8f7eb2accd05c9a
Author: fdoray <fdoray@chromium.org>
Date: Mon Jun 27 04:14:56 2016

Remove calls to deprecated MessageLoop methods in gin.

This CL makes the following replacements in
gin:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2087293002
Cr-Commit-Position: refs/heads/master@{#402108}

[modify] https://crrev.com/156962f3287f15059fef4ee6b8f7eb2accd05c9a/gin/modules/timer_unittest.cc
[modify] https://crrev.com/156962f3287f15059fef4ee6b8f7eb2accd05c9a/gin/shell/gin_main.cc
[modify] https://crrev.com/156962f3287f15059fef4ee6b8f7eb2accd05c9a/gin/test/file_runner.cc

Project Member

Comment 132 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c3a37991068030209c185e450faf4b37279186d

commit 9c3a37991068030209c185e450faf4b37279186d
Author: fdoray <fdoray@chromium.org>
Date: Tue Jun 28 21:59:31 2016

Remove calls to deprecated MessageLoop methods in mojo.

This CL makes the following replacements in
mojo:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2090603002
Cr-Commit-Position: refs/heads/master@{#402560}

[modify] https://crrev.com/9c3a37991068030209c185e450faf4b37279186d/mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc
[modify] https://crrev.com/9c3a37991068030209c185e450faf4b37279186d/mojo/public/cpp/bindings/tests/router_unittest.cc

Project Member

Comment 133 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaa8bdbc629edda9f59548cf98bc811d7204aa8c

commit aaa8bdbc629edda9f59548cf98bc811d7204aa8c
Author: fdoray <fdoray@chromium.org>
Date: Tue Jun 28 23:50:43 2016

Remove calls to deprecated MessageLoop methods in google_apis.

This CL removes calls to deprecated methods MessageLoop::PostTask
and MessageLoop::RunUntilIdle in google_apis.

BUG=616447
TBR=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2083383002
Cr-Commit-Position: refs/heads/master@{#402600}

[modify] https://crrev.com/aaa8bdbc629edda9f59548cf98bc811d7204aa8c/google_apis/gaia/oauth2_access_token_fetcher_immediate_error.cc
[modify] https://crrev.com/aaa8bdbc629edda9f59548cf98bc811d7204aa8c/google_apis/gaia/oauth2_token_service_request_unittest.cc

Project Member

Comment 134 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/392099634d1ca439a1365569f558a5661af17a0d

commit 392099634d1ca439a1365569f558a5661af17a0d
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 29 14:44:29 2016

Remove calls to MessageLoop::current() in net.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=agl@chromium.org

Review-Url: https://codereview.chromium.org/2082773002
Cr-Commit-Position: refs/heads/master@{#402805}

[modify] https://crrev.com/392099634d1ca439a1365569f558a5661af17a0d/net/dns/serial_worker_unittest.cc
[modify] https://crrev.com/392099634d1ca439a1365569f558a5661af17a0d/net/proxy/mock_proxy_resolver.cc
[modify] https://crrev.com/392099634d1ca439a1365569f558a5661af17a0d/net/proxy/mock_proxy_resolver.h
[modify] https://crrev.com/392099634d1ca439a1365569f558a5661af17a0d/net/quic/quic_connection_logger.cc
[modify] https://crrev.com/392099634d1ca439a1365569f558a5661af17a0d/net/quic/quic_connection_logger.h
[modify] https://crrev.com/392099634d1ca439a1365569f558a5661af17a0d/net/test/spawned_test_server/spawner_communicator.cc

Project Member

Comment 135 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c16c6f870e4c1546b1e5e93205caa59d5c33e513

commit c16c6f870e4c1546b1e5e93205caa59d5c33e513
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 29 15:27:32 2016

Remove calls to MessageLoop::current() in chrome.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447

Review-Url: https://codereview.chromium.org/2110603002
Cr-Commit-Position: refs/heads/master@{#402816}

[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/browser/android/net/external_estimate_provider_android.cc
[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/browser/extensions/extension_error_reporter.cc
[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/browser/extensions/extension_error_reporter.h
[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/browser/extensions/extension_install_prompt.cc
[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/browser/extensions/extension_install_prompt.h
[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/browser/metrics/thread_watcher.cc
[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/browser/process_singleton_posix.cc
[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/service/cloud_print/cloud_print_proxy_backend.cc
[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/service/cloud_print/cloud_print_proxy_backend.h
[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/service/cloud_print/printer_job_handler.cc
[modify] https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513/chrome/utility/image_writer/disk_unmounter_mac.cc

Project Member

Comment 136 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b37b2e3abbe6eee8bad666bd543b23570f3ca7c2

commit b37b2e3abbe6eee8bad666bd543b23570f3ca7c2
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 29 17:18:59 2016

Remove calls to deprecated MessageLoop methods in third_party.

This CL makes the following replacements in
third_party:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

TBR=dglazkov@chromium.org,estade@chromium.org,agl@chromium.org
BUG=616447

Review-Url: https://codereview.chromium.org/2107163003
Cr-Commit-Position: refs/heads/master@{#402847}

[modify] https://crrev.com/b37b2e3abbe6eee8bad666bd543b23570f3ca7c2/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/b37b2e3abbe6eee8bad666bd543b23570f3ca7c2/third_party/libaddressinput/chromium/chrome_address_validator.cc
[modify] https://crrev.com/b37b2e3abbe6eee8bad666bd543b23570f3ca7c2/third_party/libaddressinput/chromium/chrome_metadata_source_unittest.cc
[modify] https://crrev.com/b37b2e3abbe6eee8bad666bd543b23570f3ca7c2/third_party/zlib/google/zip_reader.cc

Project Member

Comment 137 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab

commit 4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 29 19:45:52 2016

Remove calls to MessageLoop::current() in extensions.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=reillyg@chromium.org
TBR=achuith@chromium.org

Review-Url: https://codereview.chromium.org/2085673002
Cr-Commit-Position: refs/heads/master@{#402906}

[modify] https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab/chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_unittest.cc
[modify] https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc
[modify] https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab/chrome/browser/notifications/extension_welcome_notification_unittest.cc
[modify] https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
[modify] https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc
[modify] https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab/extensions/browser/file_reader.cc
[modify] https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab/extensions/browser/file_reader.h
[modify] https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab/extensions/browser/process_manager.cc
[modify] https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab/extensions/browser/quota_service.cc
[modify] https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab/extensions/browser/quota_service.h

Project Member

Comment 138 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f9e59a94ddd7a183c75eef4f4d321e840d2d954

commit 3f9e59a94ddd7a183c75eef4f4d321e840d2d954
Author: fdoray <fdoray@chromium.org>
Date: Wed Jun 29 19:52:57 2016

Remove calls to MessageLoop::current() in media.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=chcunningham@chromium.org

Review-Url: https://codereview.chromium.org/2076423004
Cr-Commit-Position: refs/heads/master@{#402911}

[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/audio/alsa/alsa_output.cc
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/audio/alsa/alsa_output.h
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/audio/sounds/test_data.cc
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/audio/sounds/test_data.h
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/base/test_helpers.cc
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/base/test_helpers.h
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/capture/video/file_video_capture_device.cc
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/gpu/v4l2_image_processor.cc
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/gpu/v4l2_video_encode_accelerator.cc
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/3f9e59a94ddd7a183c75eef4f4d321e840d2d954/media/gpu/vaapi_video_decode_accelerator.h

Project Member

Comment 139 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42eea45c7d8947db18f7672b1f07f7ae25d4e977

commit 42eea45c7d8947db18f7672b1f07f7ae25d4e977
Author: fdoray <fdoray@chromium.org>
Date: Thu Jun 30 14:38:41 2016

Remove calls to MessageLoop::current() in chromeos.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=zelidrag@chromium.org

Review-Url: https://codereview.chromium.org/2083493004
Cr-Commit-Position: refs/heads/master@{#403172}

[modify] https://crrev.com/42eea45c7d8947db18f7672b1f07f7ae25d4e977/chromeos/network/managed_network_configuration_handler_impl.cc

Project Member

Comment 140 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1022458f506270ac5f1ac260916313847f7b54c3

commit 1022458f506270ac5f1ac260916313847f7b54c3
Author: fdoray <fdoray@chromium.org>
Date: Thu Jun 30 18:17:39 2016

Remove calls to deprecated MessageLoop methods in base.

This CL makes the following replacements in
base:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |x| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO).

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447

Review-Url: https://codereview.chromium.org/2103333006
Cr-Commit-Position: refs/heads/master@{#403224}

[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/deferred_sequenced_task_runner_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/files/file_path_watcher_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/files/file_proxy_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/files/file_util_proxy_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/files/important_file_writer_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/mac/libdispatch_task_runner_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/message_loop/message_loop_task_runner_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/message_loop/message_loop_test.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/message_loop/message_loop_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/message_loop/message_pump_libevent_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/message_loop/message_pump_perftest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/observer_list_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/sequence_checker_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/synchronization/waitable_event_watcher_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/test/power_monitor_test_base.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/test/sequenced_worker_pool_owner.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/test/test_message_loop.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/threading/thread.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/timer/timer_unittest.cc
[modify] https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3/base/trace_event/trace_event_system_stats_monitor_unittest.cc

Project Member

Comment 141 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76388ee0f590195676606308a2666dd25ae5b4b7

commit 76388ee0f590195676606308a2666dd25ae5b4b7
Author: fdoray <fdoray@chromium.org>
Date: Thu Jun 30 18:29:01 2016

Remove calls to MessageLoop::current() in content.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447

Review-Url: https://codereview.chromium.org/2105173004
Cr-Commit-Position: refs/heads/master@{#403228}

[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/android/java/java_bridge_thread.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/appcache/appcache_response_unittest.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/appcache/appcache_url_request_job_unittest.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/device_sensors/data_fetcher_shared_memory_mac.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/download/drag_download_file.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/download/drag_download_file.h
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/gamepad/gamepad_provider.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/browser/geolocation/geolocation_provider_impl_unittest.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/child/child_process.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/child/child_thread_impl.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/renderer/devtools/devtools_agent_filter.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/renderer/devtools/devtools_agent_filter.h
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/renderer/p2p/ipc_socket_factory.cc
[modify] https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7/content/renderer/render_thread_impl.cc

Project Member

Comment 142 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63a7d15df011311dc10d90ff2095b8c04d33eda7

commit 63a7d15df011311dc10d90ff2095b8c04d33eda7
Author: kelvinp <kelvinp@chromium.org>
Date: Thu Jun 30 20:26:41 2016

Revert of Remove calls to MessageLoop::current() in content. (patchset #1 id:1 of https://codereview.chromium.org/2105173004/ )

Reason for revert:
Failed Browser tests and webkit tests.

Browser tests failed:
DevToolsSanityTest.AutoAttachToWindowOpen
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/26458

webkit tests failed:
inspector/sources/debugger-pause/debugger-pause-on-promise-rejection.html
inspector/sources/debugger/live-edit-no-reveal.html
inspector/sources/debugger-step/debugger-step-out-document-write.html
inspector/sources/debugger-step/debugger-step-over-inlined-scripts.html
inspector/sources/debugger-console/debug-console-command.html
inspector/sources/debugger-frameworks/frameworks-sourcemap.html
inspector-protocol/debugger/debugger-doesnt-step-into-injected-script.html
inspector/sources/debugger-step/debugger-step-over-document-write.html
inspector/sources/debugger-step/debugger-step-out-event-listener.html
inspector/sources/debugger-console/debugger-command-line-api.html
inspector/sources/debugger-step/debugger-step-into-event-listener.html
inspector/sources/debugger-breakpoints/dom-breakpoints.html
inspector/sources/debugger/debugger-return-value.html
inspector/sources/debugger-ui/debugger-inline-values.html
inspector/sources/debugger-ui/reveal-not-skipped.html
inspector-protocol/debugger/stepping-with-blackboxed-ranges.html
inspector/sources/debugger-step/debugger-step-in.html
inspector/sources/debugger-frameworks/frameworks-skip-step-in.html
inspector/sources/debugger-step/debugger-step-into-across-timeouts.html
inspector/sources/debugger-frameworks/frameworks-step-from-framework.html
inspector/sources/debugger-step/debugger-step-into-custom-element-callbacks.html
inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html
inspector/sources/debugger/mutation-observer-suspend-while-paused.html
inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html
inspector-protocol/debugger/postMessage-on-pause.html
inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
inspector/sources/debugger/live-edit.html
inspector/sources/debugger-frameworks/frameworks-steppings.html
inspector-protocol/debugger/continueToLocation.html
inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe.html
inspector/sources/debugger-step/debugger-step-into-document-write.html
inspector-protocol/debugger/updateCallFrameScopes.html
inspector/sources/debugger-step/debugger-step-over.html
inspector/sources/debugger-frameworks/frameworks-jquery.html
inspector-protocol/debugger/debugger-setBlackboxPatterns.html
inspector/sources/debugger-step/debugger-step-into-inlined-scripts.html
inspector/sources/debugger-step/debugger-step-over-across-timeouts.html
inspector/sources/debugger-step/debugger-step-through-promises.html
inspector/sources/debugger-step/debugger-step-out-custom-element-callbacks.html
inspector-protocol/debugger/step-over-caught-exception.html

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/6394

Original issue's description:
> Remove calls to MessageLoop::current() in content.
>
> Why?
> The fact that there's a MessageLoop on the thread is an
> unnecessary implementation detail. When browser threads
> are migrated to base/task_scheduler, tasks will no longer
> have access to a MessageLoop.
>
> These changes were generated manually.
>
> BUG=616447
>
> Committed: https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7
> Cr-Commit-Position: refs/heads/master@{#403228}

TBR=jochen@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616447

Review-Url: https://codereview.chromium.org/2116643002
Cr-Commit-Position: refs/heads/master@{#403268}

[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/android/java/java_bridge_thread.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/appcache/appcache_response_unittest.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/appcache/appcache_url_request_job_unittest.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/device_sensors/data_fetcher_shared_memory_mac.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/download/drag_download_file.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/download/drag_download_file.h
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/gamepad/gamepad_provider.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/browser/geolocation/geolocation_provider_impl_unittest.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/child/child_process.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/child/child_thread_impl.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/renderer/devtools/devtools_agent_filter.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/renderer/devtools/devtools_agent_filter.h
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/renderer/p2p/ipc_socket_factory.cc
[modify] https://crrev.com/63a7d15df011311dc10d90ff2095b8c04d33eda7/content/renderer/render_thread_impl.cc

Project Member

Comment 143 by bugdroid1@chromium.org, Jul 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d056ff7a8b9cadcd19dba50d20059428aa1db9b

commit 6d056ff7a8b9cadcd19dba50d20059428aa1db9b
Author: fdoray <fdoray@chromium.org>
Date: Mon Jul 04 21:56:42 2016

Remove remaining calls to deprecated MessageLoop methods.

This CL makes the following replacements everywhere:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |x| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO).

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

TBR=garykac@chromium.org
BUG=616447

Review-Url: https://codereview.chromium.org/2104363004
Cr-Commit-Position: refs/heads/master@{#403716}

[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/chrome/test/chromedriver/server/chromedriver_server.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/components/precache/core/precache_fetcher_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/content/renderer/media/media_stream_audio_processor.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/ipc/ipc_sync_channel.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/mojo/public/cpp/bindings/tests/associated_interface_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/mojo/public/cpp/bindings/tests/binding_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/mojo/public/cpp/bindings/tests/request_response_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/mojo/public/cpp/bindings/tests/sync_method_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/mojo/public/cpp/bindings/tests/union_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/mojo/public/cpp/bindings/tests/validation_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/remoting/host/chromoting_host_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/remoting/host/desktop_process_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/remoting/host/ipc_desktop_environment_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/remoting/protocol/authenticator_test_base.h
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/remoting/protocol/channel_multiplexer_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/remoting/protocol/connection_tester.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/remoting/protocol/connection_tester.h
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/remoting/protocol/monitored_video_stub_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/remoting/protocol/negotiating_authenticator_unittest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/remoting/test/protocol_perftest.cc
[modify] https://crrev.com/6d056ff7a8b9cadcd19dba50d20059428aa1db9b/services/shell/tests/shell/shell_unittest.cc

Project Member

Comment 144 by bugdroid1@chromium.org, Jul 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e716a9021e055fc77e0459d1a46b269864333cf8

commit e716a9021e055fc77e0459d1a46b269864333cf8
Author: fdoray <fdoray@chromium.org>
Date: Tue Jul 05 16:05:49 2016

Remove calls to deprecated MessageLoop methods in content.

This CL makes the following replacements in
content:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=jam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2082343002
Cr-Commit-Position: refs/heads/master@{#403787}

[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/blob_storage/blob_reader_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/blob_storage/blob_url_request_job_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/browser_thread_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/byte_stream_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/devtools/devtools_manager_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/devtools/site_per_process_devtools_browsertest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/download/download_file_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/fileapi/file_system_operation_impl_write_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/fileapi/file_system_url_request_job_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/fileapi/file_writer_delegate_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/fileapi/local_file_stream_reader_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/gamepad/gamepad_provider_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/geolocation/geolocation_provider_impl_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/geolocation/network_location_provider_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/indexed_db/indexed_db_transaction_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/media/capture/web_contents_video_capture_device_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/quota/quota_backend_impl_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/renderer_host/input/gesture_event_queue_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/renderer_host/input/touch_event_queue_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/renderer_host/media/media_stream_ui_proxy_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/storage_partition_impl_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/browser/webui/url_data_manager_backend.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/child/power_monitor_broadcast_source_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/child/shared_memory_data_consumer_handle_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/child/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/gpu/gpu_main.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/ppapi_plugin/ppapi_broker_main.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/ppapi_plugin/ppapi_plugin_main.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/public/test/render_view_test.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/public/test/test_utils.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/device_sensors/device_light_event_pump_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/device_sensors/device_motion_event_pump_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/device_sensors/device_orientation_event_pump_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/gpu/render_widget_compositor_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/media/media_stream_video_track_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/media/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/media/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/pepper/plugin_module.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/pepper/ppb_flash_message_loop_impl.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/render_thread_impl_browsertest.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/renderer/renderer_main.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/test/appcache_test_helper.cc
[modify] https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8/content/utility/utility_main.cc

Project Member

Comment 145 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e94d86444553f5bf3abe0af715fa6f49acc18f67

commit e94d86444553f5bf3abe0af715fa6f49acc18f67
Author: fdoray <fdoray@chromium.org>
Date: Thu Jul 07 19:19:01 2016

Remove calls to MessageLoop::current() in content.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

This CL is identical to https://codereview.chromium.org/2105173004/
except for a fix to content/renderer/devtools/devtools_agent.cc

BUG=616447

Review-Url: https://codereview.chromium.org/2123653003
Cr-Commit-Position: refs/heads/master@{#404207}

[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/browser/android/java/java_bridge_thread.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/browser/appcache/appcache_response_unittest.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/browser/appcache/appcache_url_request_job_unittest.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/browser/device_sensors/data_fetcher_shared_memory_mac.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/browser/download/drag_download_file.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/browser/download/drag_download_file.h
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/browser/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/browser/geolocation/geolocation_provider_impl_unittest.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/child/child_process.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/child/child_thread_impl.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/renderer/devtools/devtools_agent_filter.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/renderer/devtools/devtools_agent_filter.h
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/renderer/p2p/ipc_socket_factory.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/e94d86444553f5bf3abe0af715fa6f49acc18f67/device/gamepad/gamepad_provider.cc

Is comment 5 the clang-tidy script you referred to in the CLs? BTW, consider using an attachment next time?
Project Member

Comment 147 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0544fc6ed9a3477926b3640fae9706836f211ea

commit f0544fc6ed9a3477926b3640fae9706836f211ea
Author: fdoray <fdoray@chromium.org>
Date: Mon Jul 18 16:05:15 2016

Remove calls to MessageLoop::current() in tools.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447

Review-Url: https://codereview.chromium.org/2130443002
Cr-Commit-Position: refs/heads/master@{#406006}

[modify] https://crrev.com/f0544fc6ed9a3477926b3640fae9706836f211ea/tools/gn/loader.cc
[modify] https://crrev.com/f0544fc6ed9a3477926b3640fae9706836f211ea/tools/gn/loader.h
[modify] https://crrev.com/f0544fc6ed9a3477926b3640fae9706836f211ea/tools/gn/loader_unittest.cc
[modify] https://crrev.com/f0544fc6ed9a3477926b3640fae9706836f211ea/tools/gn/scheduler.cc
[modify] https://crrev.com/f0544fc6ed9a3477926b3640fae9706836f211ea/tools/gn/scheduler.h
[modify] https://crrev.com/f0544fc6ed9a3477926b3640fae9706836f211ea/tools/gn/setup.cc

Project Member

Comment 148 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d

commit 2df4a9ef0a0abb0c21d8994fe597c68f6637d95d
Author: fdoray <fdoray@chromium.org>
Date: Mon Jul 18 23:47:16 2016

Remove remaining calls to deprecated MessageLoop methods on Mac.

With this CL, there is no remaining call to these methods on Mac:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Note that this CL also removes calls to these methods from files that
are not built on Mac.

These calls were not migrated by the clang-tidy script used previously
for various reasons (Objective-C code, templates, macros, header files,
std::unique_ptr<MessageLoop>...).

This CL was generated manually (with the help of a few regular
expressions).

BUG=616447
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=sdefresne@chromium.org (for ios/'s trivial application of this refactoring)

Review-Url: https://codereview.chromium.org/2132593002
Cr-Commit-Position: refs/heads/master@{#406148}

[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/base/files/file_path_watcher_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/base/ios/weak_nsobject_unittest.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/base/memory/memory_pressure_listener_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/base/message_loop/message_loop_task_runner_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/base/message_loop/message_loop_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/base/message_loop/message_pump_glib_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/app_shim/chrome_main_app_mode_mac.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/browsing_data/browsing_data_helper_browsertest.h
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/devtools/device/port_forwarding_browsertest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/first_run_dialog.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/keystone_infobar_delegate.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chrome/browser/ui/cocoa/status_bubble_mac.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/chromecast/base/component/component_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/components/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/components/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/components/scheduler/child/idle_helper_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/components/search_provider_logos/logo_tracker_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/components/translate/ios/browser/ios_translate_driver.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/content/browser/renderer_host/media/media_stream_ui_controller_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/content/browser/renderer_host/media/video_capture_manager_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/content/browser/renderer_host/text_input_client_mac_unittest.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/device/serial/serial_connection_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/extensions/browser/api/cast_channel/cast_test_util.h
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/gpu/ipc/service/image_transport_surface_overlay_mac.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/ios/chrome/browser/infobars/infobar_container_ios.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/ios/chrome/browser/passwords/credential_manager.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/ios/chrome/browser/signin/browser_state_data_remover.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/ios/crnet/crnet_environment.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/jingle/glue/chrome_async_socket_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/jingle/notifier/base/xmpp_connection_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/media/audio/audio_input_controller_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/media/audio/mac/audio_low_latency_input_mac_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/media/cast/sender/h264_vt_encoder_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/media/filters/ffmpeg_demuxer_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/net/proxy/proxy_config_service_android_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/net/test/embedded_test_server/embedded_test_server_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/ppapi/proxy/ppb_message_loop_proxy.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/ppapi/proxy/ppb_message_loop_proxy.h
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/remoting/client/client_status_logger_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/remoting/host/host_status_logger_unittest.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/services/shell/background/background_shell.cc
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/sync/internal_api/public/attachments/task_queue.h
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/third_party/WebKit/Source/web/tests/DEPS
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/third_party/WebKit/Source/web/tests/RunAllTests.cpp
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/ui/base/test/scoped_fake_nswindow_fullscreen.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/ui/base/test/ui_controls_mac.mm
[modify] https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d/ui/views/widget/native_widget_mac_unittest.mm

Project Member

Comment 149 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c08014da520a3193d91ba87ec0f4ae30d9e79c61

commit c08014da520a3193d91ba87ec0f4ae30d9e79c61
Author: fdoray <fdoray@chromium.org>
Date: Tue Jul 19 20:05:12 2016

Remove deprecated methods from MessageLoop on Mac.

This CL removes the declaration of these deprecated methods on Mac:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon

And makes these methods protected on Mac:
- MessageLoop::Run
- MessageLoop::RunUntilIdle
(These methods are protected instead of removed because they are still
used through derived classes.)

We believe that this CL will prevent developers from adding new calls
to the deprecated methods (since the code won't compile on Mac bots).
We will remove these methods on other platforms as soon as possible.

BUG=616447

Review-Url: https://codereview.chromium.org/2155223002
Cr-Commit-Position: refs/heads/master@{#406360}

[modify] https://crrev.com/c08014da520a3193d91ba87ec0f4ae30d9e79c61/base/message_loop/message_loop.cc
[modify] https://crrev.com/c08014da520a3193d91ba87ec0f4ae30d9e79c61/base/message_loop/message_loop.h

Project Member

Comment 150 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1e050c52c26c7e0232da4717564ac6d2f649fcd

commit e1e050c52c26c7e0232da4717564ac6d2f649fcd
Author: fdoray <fdoray@chromium.org>
Date: Tue Jul 19 21:05:54 2016

Remove calls to MessageLoop::current() in base.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

Note: Some files outside of base/ had to be modified
because they didn't compile anymore after
#include "base/message_loop/message_loop.h" was removed
from base/ headers.

BUG=616447
TBR=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2136563002
Cr-Commit-Position: refs/heads/master@{#406378}

[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/base/observer_list_threadsafe.h
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/base/power_monitor/power_monitor_device_source.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/base/power_monitor/power_monitor_device_source_win.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/base/threading/thread.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/base/threading/thread.h
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/chrome/browser/android/data_usage/external_data_use_reporter.h
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/chrome/browser/chromeos/policy/android_management_client_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/components/data_use_measurement/content/data_use_measurement_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/components/gcm_driver/gcm_account_tracker_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/components/omnibox/browser/bookmark_provider_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/components/policy/core/common/cloud/cloud_policy_core_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/components/signin/core/browser/account_tracker_service_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/components/ssl_errors/error_classification_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/content/browser/browser_thread_impl.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/content/browser/browser_thread_impl.h
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/dbus/test_service.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/dbus/test_service.h
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/google_apis/gaia/gaia_auth_fetcher_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/google_apis/gaia/gaia_oauth_client_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/ios/chrome/browser/net/retryable_url_fetcher_unittest.mm
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/ios/web/web_thread_impl.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/ios/web/web_thread_impl.h
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/media/capture/system_message_window_win_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/net/cert_net/nss_ocsp.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/net/dns/dns_config_service_posix_unittest.cc
[modify] https://crrev.com/e1e050c52c26c7e0232da4717564ac6d2f649fcd/net/quic/quic_end_to_end_unittest.cc

Project Member

Comment 151 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8170ad0608f90dbcc21a932e244470a0740e8c41

commit 8170ad0608f90dbcc21a932e244470a0740e8c41
Author: tapted <tapted@chromium.org>
Date: Wed Jul 20 07:29:21 2016

Fix mac_views_browser compile after r406360 (MessageLoop::Run() protected on Mac)

The compile step regressed in http://go/macviewsbuilder/builds/11862

r406360 made MessageLoop::Run() a protected method on Mac.
tab_drag_controller_interactive_uitest.cc uses it, and this is built on
that Mac bot.

Replace MessageLoop::current()->Run() with RunLoop().Run().

BUG=616447
TBR=fdoray@chromium.org

Review-Url: https://codereview.chromium.org/2167473004
Cr-Commit-Position: refs/heads/master@{#406512}

[modify] https://crrev.com/8170ad0608f90dbcc21a932e244470a0740e8c41/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Project Member

Comment 152 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76db1513714741d8d6e6dd6e872d50f20b090fce

commit 76db1513714741d8d6e6dd6e872d50f20b090fce
Author: fdoray <fdoray@chromium.org>
Date: Tue Jul 26 19:10:06 2016

Remove MessageLoop::current() from base::win::ObjectWatcher.

Why? The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads are migrated to
base/task_scheduler, tasks will no longer have access to a MessageLoop
but they will be able to get the current ThreadTaskRunnerHandle.

Before this CL, ObjectWatcher implemented
WillDestroyCurrentMessageLoop() to stop the watch when the
MessageLoop responsible for running the callback was destroyed.
This prevented the watch callback from being sent to a destroyed
MessageLoop.

Now that ObjectWatcher keeps a reference to a TaskRunner, this is
no longer required. The TaskRunner can't be deleted while there are
references to it. If the underlying MessageLoop has been deleted
when the watch callback is posted, the callback will simply not run.

Note that the watch will still be stopped when the ObjectWatcher is
deleted.

TBR=ben@chromium.org
BUG=616447

Review-Url: https://codereview.chromium.org/2125763003
Cr-Commit-Position: refs/heads/master@{#407874}

[modify] https://crrev.com/76db1513714741d8d6e6dd6e872d50f20b090fce/base/files/file_path_watcher_win.cc
[modify] https://crrev.com/76db1513714741d8d6e6dd6e872d50f20b090fce/base/process/kill_win.cc
[modify] https://crrev.com/76db1513714741d8d6e6dd6e872d50f20b090fce/base/win/object_watcher.cc
[modify] https://crrev.com/76db1513714741d8d6e6dd6e872d50f20b090fce/base/win/object_watcher.h
[modify] https://crrev.com/76db1513714741d8d6e6dd6e872d50f20b090fce/chrome/common/service_process_util_win.cc
[modify] https://crrev.com/76db1513714741d8d6e6dd6e872d50f20b090fce/ui/gfx/font_fallback_win.cc

Clang-tidy checks to remove calls to deprecated MessageLoop methods
checks.zip
4.0 KB Download
Project Member

Comment 154 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/428e75e2645afccd3683e2c0700765f3dc0a3b83

commit 428e75e2645afccd3683e2c0700765f3dc0a3b83
Author: fdoray <fdoray@chromium.org>
Date: Mon Aug 08 13:31:41 2016

Remove calls to deprecated MessageLoop methods in suggestions_service_unittest.cc

This CL replaces calls to MessageLoop::RunUntilIdle with
RunLoop().RunUntilIdle() in suggestions_service_unittest.cc.

Note that there is no reason to call RunUntilIdle() multiple times
in a row. After a call returns, the MessageLoop is idle. It stays idle
until a task is posted or a timer expires. There is no reason to call
RunUntilIdle() before that.

BUG=616447

Review-Url: https://codereview.chromium.org/2212223003
Cr-Commit-Position: refs/heads/master@{#410339}

[modify] https://crrev.com/428e75e2645afccd3683e2c0700765f3dc0a3b83/components/suggestions/suggestions_service_unittest.cc

Project Member

Comment 155 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e46618d151ea43f2a7cc135f25cea6a173f67a58

commit e46618d151ea43f2a7cc135f25cea6a173f67a58
Author: fdoray <fdoray@chromium.org>
Date: Mon Aug 08 20:42:03 2016

Remove calls to deprecated MessageLoop methods in site_instance_impl_unittest.cc

This CL replaces calls to MessageLoop::RunUntilIdle with
RunLoop().RunUntilIdle() in site_instance_impl_unittest.cc.

Note that there is no reason to call RunUntilIdle() multiple times
in a row. After a call returns, the MessageLoop is idle. It stays idle
until a task is posted or a timer expires. There is no reason to call
RunUntilIdle() before that.

BUG=616447

Review-Url: https://codereview.chromium.org/2219053002
Cr-Commit-Position: refs/heads/master@{#410447}

[modify] https://crrev.com/e46618d151ea43f2a7cc135f25cea6a173f67a58/content/browser/site_instance_impl_unittest.cc

Project Member

Comment 156 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ef45cf47455fb44e8fa0ab5d1ba545c91429941

commit 6ef45cf47455fb44e8fa0ab5d1ba545c91429941
Author: fdoray <fdoray@chromium.org>
Date: Thu Aug 25 15:36:37 2016

Remove calls to deprecated MessageLoop methods on Windows and Linux.

This Cl removes most calls to these methods on Windows and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2211473003
Cr-Commit-Position: refs/heads/master@{#414442}

[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ash/test/shelf_view_test_api.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/base/memory/memory_pressure_monitor_win_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/base/message_loop/message_loop_task_runner_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/base/message_loop/message_loop_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/base/message_loop/message_pump_glib_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/base/message_loop/message_pump_perftest.cc
[add] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/base/task_scheduler/scheduler_worker_unittest.cc~RF3e0a7fad.TMP
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/base/win/object_watcher_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/blimp/client/core/contents/blimp_contents_impl_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/download/download_path_reservation_tracker_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/first_run/try_chrome_dialog_view.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/importer/edge_importer_browsertest_win.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/local_discovery/local_domain_resolver_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/local_discovery/service_discovery_client_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/metrics/thread_watcher_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/password_manager/password_store_win_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/prerender/prerender_resource_throttle_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/ui/views/color_chooser_dialog.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/common/service_process_util_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/chrome/test/chromedriver/server/chromedriver_server.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/arc/arc_bridge_service_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/arc/standalone/arc_standalone_bridge_runner.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/arc/standalone/service_helper_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/cronet/ios/cronet_environment.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/data_usage/core/data_use_aggregator_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/data_use_measurement/content/data_use_measurement_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/dom_distiller/core/distiller_url_fetcher_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/nacl/broker/nacl_broker_listener.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/nacl/broker/nacl_broker_listener.h
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/nacl/loader/nonsfi/nonsfi_listener.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/policy/core/browser/url_blacklist_manager_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/policy/core/common/configuration_policy_provider_test.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/sync/driver/non_ui_model_type_controller_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/sync/driver/ui_data_type_controller_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/sync/tools/testserver/run_sync_testserver.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/components/sync_sessions/favicon_cache_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/browser/appcache/chrome_appcache_service_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/browser/indexed_db/indexed_db_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/browser/tracing/etw_tracing_agent_win.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/browser/web_contents/web_contents_view_aura_browsertest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/gpu/gpu_watchdog_thread.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/public/test/content_browser_test.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/renderer/media/audio_message_filter_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/renderer/media/media_stream_video_renderer_sink_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/dbus/end_to_end_async_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/dbus/mock_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/dbus/object_manager_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/dbus/signal_sender_verification_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/dbus/test_service.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/device/battery/battery_status_manager_linux.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/device/bluetooth/bluez/bluetooth_adapter_profile_bluez_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/device/bluetooth/bluez/bluetooth_audio_sink_bluez_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/device/bluetooth/bluez/bluetooth_bluez_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/device/bluetooth/bluez/bluetooth_socket_bluez_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/extensions/browser/api/declarative/rules_registry_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/extensions/shell/test/shell_test.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ipc/attachment_broker_privileged_win_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ipc/ipc_channel_mojo_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ipc/ipc_channel_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ipc/ipc_channel_win.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/jingle/notifier/listener/xmpp_push_client_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/audio/audio_low_latency_input_output_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/audio/audio_output_device_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/audio/win/audio_low_latency_input_win_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/audio/win/audio_low_latency_output_win_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/audio/win/audio_output_win_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/capture/video/linux/video_capture_device_linux.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/cast/test/sender.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/device_monitors/system_message_window_win_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/gpu/rendering_helper.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/gpu/v4l2_image_processor.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/gpu/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/gpu/vaapi_video_encode_accelerator.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/midi/midi_manager_alsa.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/media/midi/midi_manager_win.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/net/base/network_change_notifier_win_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/net/dns/mdns_client_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/net/http/transport_security_persister_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/net/test/spawned_test_server/local_test_server_win.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/net/test/spawned_test_server/spawner_communicator.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/net/tools/get_server_time/get_server_time.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/net/tools/net_watcher/net_watcher.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/net/tools/testserver/run_testserver.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ppapi/nacl_irt/irt_pnacl_translator_compile.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ppapi/nacl_irt/irt_pnacl_translator_link.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ppapi/nacl_irt/irt_ppapi.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/remoting/host/daemon_process_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/remoting/host/remoting_me2me_host.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/remoting/host/win/rdp_client_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/remoting/host/win/worker_process_launcher_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/remoting/protocol/ice_transport_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/remoting/test/protocol_perftest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/remoting/test/test_chromoting_client_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/services/navigation/content_client/browser_main_parts.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/app_list/demo/app_list_demo_views.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/app_list/pagination_model_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/app_list/views/apps_grid_view_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/aura/demo/demo_main.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/aura/test/ui_controls_factory_aurawin.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/aura/window_event_dispatcher_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/base/x/selection_requestor_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/events/platform/platform_event_source_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/gl/gl_surface_glx.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/keyboard/keyboard_controller_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/message_center/views/message_center_view_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/shell_dialogs/select_file_dialog_win.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/views/controls/menu/menu_controller_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
[modify] https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc

Project Member

Comment 157 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00108e0c668b75d9416d50852176ce39c5454e2d

commit 00108e0c668b75d9416d50852176ce39c5454e2d
Author: fdoray <fdoray@chromium.org>
Date: Thu Aug 25 17:33:32 2016

Revert of Remove MessageLoop::current() from base::win::ObjectWatcher. (patchset #5 id:80001 of https://codereview.chromium.org/2125763003/ )

Reason for revert:
Breaks Win10 builder. crbug.com/632184

Original issue's description:
> Remove MessageLoop::current() from base::win::ObjectWatcher.
>
> Why? The fact that there's a MessageLoop on the thread is an
> unnecessary implementation detail. When browser threads are migrated to
> base/task_scheduler, tasks will no longer have access to a MessageLoop
> but they will be able to get the current ThreadTaskRunnerHandle.
>
> Before this CL, ObjectWatcher implemented
> WillDestroyCurrentMessageLoop() to stop the watch when the
> MessageLoop responsible for running the callback was destroyed.
> This prevented the watch callback from being sent to a destroyed
> MessageLoop.
>
> Now that ObjectWatcher keeps a reference to a TaskRunner, this is
> no longer required. The TaskRunner can't be deleted while there are
> references to it. If the underlying MessageLoop has been deleted
> when the watch callback is posted, the callback will simply not run.
>
> Note that the watch will still be stopped when the ObjectWatcher is
> deleted.
>
> TBR=ben@chromium.org
> BUG=616447
>
> Committed: https://crrev.com/76db1513714741d8d6e6dd6e872d50f20b090fce
> Cr-Commit-Position: refs/heads/master@{#407874}

TBR=grt@chromium.org,ben@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=616447

Review-Url: https://codereview.chromium.org/2277333002
Cr-Commit-Position: refs/heads/master@{#414465}

[modify] https://crrev.com/00108e0c668b75d9416d50852176ce39c5454e2d/base/files/file_path_watcher_win.cc
[modify] https://crrev.com/00108e0c668b75d9416d50852176ce39c5454e2d/base/process/kill_win.cc
[modify] https://crrev.com/00108e0c668b75d9416d50852176ce39c5454e2d/base/win/object_watcher.cc
[modify] https://crrev.com/00108e0c668b75d9416d50852176ce39c5454e2d/base/win/object_watcher.h
[modify] https://crrev.com/00108e0c668b75d9416d50852176ce39c5454e2d/chrome/common/service_process_util_win.cc
[modify] https://crrev.com/00108e0c668b75d9416d50852176ce39c5454e2d/ui/gfx/font_fallback_win.cc

Project Member

Comment 158 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2ac872c47b999311b86dd1e9dd723e3943588f0

commit d2ac872c47b999311b86dd1e9dd723e3943588f0
Author: fs <fs@opera.com>
Date: Thu Aug 25 17:35:16 2016

Remove temporary file that was accidentally checked in

This file was added as part of https://codereview.chromium.org/2211473003
but looks like it was done so by mistake. Remove it again.

TBR=fdoray@chromium.org
BUG=616447

Review-Url: https://codereview.chromium.org/2276423002
Cr-Commit-Position: refs/heads/master@{#414467}

[delete] https://crrev.com/bcfbd47c643580867f4466d80acb0173925a91c8/base/task_scheduler/scheduler_worker_unittest.cc~RF3e0a7fad.TMP

Comment 159 by kbr@chromium.org, Aug 25 2016

Blockedon: 641142
Project Member

Comment 160 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee7bd139a3b585f2adad420252bd82578caec4a3

commit ee7bd139a3b585f2adad420252bd82578caec4a3
Author: fdoray <fdoray@chromium.org>
Date: Fri Aug 26 13:51:18 2016

Remove calls to deprecated MessageLoop methods from tools/.

This CL removes calls to these methods from tools/ files:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447

Review-Url: https://codereview.chromium.org/2278993002
Cr-Commit-Position: refs/heads/master@{#414701}

[modify] https://crrev.com/ee7bd139a3b585f2adad420252bd82578caec4a3/tools/android/forwarder2/device_forwarder_main.cc

Project Member

Comment 161 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61c7b7929551f82e84a1b3ccf6073aa8b4e6bbe6

commit 61c7b7929551f82e84a1b3ccf6073aa8b4e6bbe6
Author: fdoray <fdoray@chromium.org>
Date: Fri Aug 26 17:35:42 2016

Remove calls to deprecated MessageLoop methods from gpu/.

This CL removes calls to these methods from gpu/ files:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2274213004
Cr-Commit-Position: refs/heads/master@{#414742}

[modify] https://crrev.com/61c7b7929551f82e84a1b3ccf6073aa8b4e6bbe6/gpu/tools/compositor_model_bench/compositor_model_bench.cc

Project Member

Comment 162 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1f67c7ebef8f522b508172849275e0ff3b77264

commit e1f67c7ebef8f522b508172849275e0ff3b77264
Author: fdoray <fdoray@chromium.org>
Date: Tue Aug 30 20:27:45 2016

Remove calls to deprecated MessageLoop methods from mojo/.

This CL removes calls to these methods from mojo/ files:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447

Review-Url: https://codereview.chromium.org/2272253003
Cr-Commit-Position: refs/heads/master@{#415407}

[modify] https://crrev.com/e1f67c7ebef8f522b508172849275e0ff3b77264/mojo/android/system/base_run_loop.cc
[modify] https://crrev.com/e1f67c7ebef8f522b508172849275e0ff3b77264/mojo/android/system/src/org/chromium/mojo/system/impl/BaseRunLoop.java

Project Member

Comment 163 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02837149eb615d36c22c4191ec6882fe3b018393

commit 02837149eb615d36c22c4191ec6882fe3b018393
Author: fdoray <fdoray@chromium.org>
Date: Thu Sep 01 17:03:02 2016

Remove calls to deprecated MessageLoop methods from sandbox/.

This CL removes calls to these methods from sandbox/ files:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447

Review-Url: https://codereview.chromium.org/2278883003
Cr-Commit-Position: refs/heads/master@{#415979}

[modify] https://crrev.com/02837149eb615d36c22c4191ec6882fe3b018393/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc

Project Member

Comment 164 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ae151ac5827e72f0c8e7f5730f77e2a466ae4d9

commit 4ae151ac5827e72f0c8e7f5730f77e2a466ae4d9
Author: fdoray <fdoray@chromium.org>
Date: Tue Sep 06 21:34:48 2016

Remove calls to deprecated MessageLoop methods in content.

This CL (hopefully) removes all calls to these methods in content:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=avi@chromium.org

Review-Url: https://codereview.chromium.org/2312803003
Cr-Commit-Position: refs/heads/master@{#416734}

[modify] https://crrev.com/4ae151ac5827e72f0c8e7f5730f77e2a466ae4d9/content/app/android/download_main.cc
[modify] https://crrev.com/4ae151ac5827e72f0c8e7f5730f77e2a466ae4d9/content/renderer/media/webmediaplayer_ms_unittest.cc

Project Member

Comment 165 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c10fe2026be2eaddc2e8490d1f9224b51ccb4f3

commit 8c10fe2026be2eaddc2e8490d1f9224b51ccb4f3
Author: fdoray <fdoray@chromium.org>
Date: Tue Sep 06 23:00:42 2016

Remove calls to deprecated MessageLoop methods in blimp.

This CL (hopefully) removes all calls to these methods in blimp:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=dtrainor@chromium.org

Review-Url: https://codereview.chromium.org/2316493005
Cr-Commit-Position: refs/heads/master@{#416748}

[modify] https://crrev.com/8c10fe2026be2eaddc2e8490d1f9224b51ccb4f3/blimp/client/core/compositor/delegated_output_surface_unittest.cc
[modify] https://crrev.com/8c10fe2026be2eaddc2e8490d1f9224b51ccb4f3/blimp/client/core/contents/blimp_contents_manager_unittest.cc
[modify] https://crrev.com/8c10fe2026be2eaddc2e8490d1f9224b51ccb4f3/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc

Project Member

Comment 166 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edab6b4d1638411b81eb5c0c8f75ca98510b1815

commit edab6b4d1638411b81eb5c0c8f75ca98510b1815
Author: fdoray <fdoray@chromium.org>
Date: Tue Sep 06 23:05:37 2016

Remove calls to deprecated MessageLoop methods in chromecast.

This CL (hopefully) removes all calls to these methods in chromecast:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=halliwell@chromium.org

Review-Url: https://codereview.chromium.org/2311363002
Cr-Commit-Position: refs/heads/master@{#416751}

[modify] https://crrev.com/edab6b4d1638411b81eb5c0c8f75ca98510b1815/chromecast/base/bind_to_task_runner_unittest.cc
[modify] https://crrev.com/edab6b4d1638411b81eb5c0c8f75ca98510b1815/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/edab6b4d1638411b81eb5c0c8f75ca98510b1815/chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc
[modify] https://crrev.com/edab6b4d1638411b81eb5c0c8f75ca98510b1815/chromecast/media/cma/backend/multizone_backend_unittest.cc
[modify] https://crrev.com/edab6b4d1638411b81eb5c0c8f75ca98510b1815/chromecast/media/cma/base/balanced_media_task_runner_unittest.cc
[modify] https://crrev.com/edab6b4d1638411b81eb5c0c8f75ca98510b1815/chromecast/media/cma/base/buffering_frame_provider_unittest.cc
[modify] https://crrev.com/edab6b4d1638411b81eb5c0c8f75ca98510b1815/chromecast/media/cma/base/demuxer_stream_adapter_unittest.cc
[modify] https://crrev.com/edab6b4d1638411b81eb5c0c8f75ca98510b1815/chromecast/media/cma/base/multi_demuxer_stream_adapter_unittest.cc
[modify] https://crrev.com/edab6b4d1638411b81eb5c0c8f75ca98510b1815/chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc

Project Member

Comment 167 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/311b80864193429e1cb49bdf6e78014127bbf89a

commit 311b80864193429e1cb49bdf6e78014127bbf89a
Author: fdoray <fdoray@chromium.org>
Date: Tue Sep 06 23:12:59 2016

Remove calls to deprecated MessageLoop methods in extensions.

This CL (hopefully) removes all calls to these methods in extensions:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2314983002
Cr-Commit-Position: refs/heads/master@{#416758}

[modify] https://crrev.com/311b80864193429e1cb49bdf6e78014127bbf89a/extensions/browser/api/audio/audio_apitest.cc

Project Member

Comment 168 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/259095f84708e39cafdebaed6b05f7568125ac73

commit 259095f84708e39cafdebaed6b05f7568125ac73
Author: fdoray <fdoray@chromium.org>
Date: Tue Sep 06 23:30:30 2016

Remove calls to deprecated MessageLoop methods in remoting.

This CL (hopefully) removes all calls to these methods in remoting:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=sergeyu@chromium.org

Review-Url: https://codereview.chromium.org/2315883002
Cr-Commit-Position: refs/heads/master@{#416773}

[modify] https://crrev.com/259095f84708e39cafdebaed6b05f7568125ac73/remoting/host/chromeos/clipboard_aura_unittest.cc

Project Member

Comment 169 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5aacdb8469393764fcf5ae296e1176ac6f25650

commit a5aacdb8469393764fcf5ae296e1176ac6f25650
Author: fdoray <fdoray@chromium.org>
Date: Wed Sep 07 00:53:01 2016

Remove calls to deprecated MessageLoop methods in ppapi.

This CL (hopefully) removes all calls to these methods in ppapi:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=bbudge@chromium.org

Review-Url: https://codereview.chromium.org/2310253002
Cr-Commit-Position: refs/heads/master@{#416805}

[modify] https://crrev.com/a5aacdb8469393764fcf5ae296e1176ac6f25650/ppapi/proxy/tracked_callback_unittest.cc

Project Member

Comment 170 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caf5d18c1f0719b5d6c572f82debab1ad33db204

commit caf5d18c1f0719b5d6c572f82debab1ad33db204
Author: fdoray <fdoray@chromium.org>
Date: Wed Sep 07 10:09:23 2016

Remove calls to deprecated MessageLoop methods in headless.

This CL (hopefully) removes all calls to these methods in headless:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2311373002
Cr-Commit-Position: refs/heads/master@{#416897}

[modify] https://crrev.com/caf5d18c1f0719b5d6c572f82debab1ad33db204/headless/public/util/generic_url_request_job_test.cc

Project Member

Comment 171 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c41a2ec2e985736ca8cec99f46b37ab9d3aadd2d

commit c41a2ec2e985736ca8cec99f46b37ab9d3aadd2d
Author: fdoray <fdoray@chromium.org>
Date: Wed Sep 07 13:03:43 2016

Remove calls to deprecated MessageLoop methods in ash.

This CL (hopefully) removes all calls to these methods in ash:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2314233002
Cr-Commit-Position: refs/heads/master@{#416921}

[modify] https://crrev.com/c41a2ec2e985736ca8cec99f46b37ab9d3aadd2d/ash/common/system/chromeos/power/power_status_unittest.cc
[modify] https://crrev.com/c41a2ec2e985736ca8cec99f46b37ab9d3aadd2d/ash/drag_drop/drag_drop_interactive_uitest.cc

Project Member

Comment 172 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e74ea6f8bc4bf98b6a8d5e147a5e52de261d135b

commit e74ea6f8bc4bf98b6a8d5e147a5e52de261d135b
Author: fdoray <fdoray@chromium.org>
Date: Wed Sep 07 16:08:06 2016

Remove calls to deprecated MessageLoop methods in media.

This CL (hopefully) removes all calls to these methods in media:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=chcunningham@chromium.org

Review-Url: https://codereview.chromium.org/2317803002
Cr-Commit-Position: refs/heads/master@{#416946}

[modify] https://crrev.com/e74ea6f8bc4bf98b6a8d5e147a5e52de261d135b/media/audio/android/audio_android_unittest.cc
[modify] https://crrev.com/e74ea6f8bc4bf98b6a8d5e147a5e52de261d135b/media/base/android/media_source_player_unittest.cc
[modify] https://crrev.com/e74ea6f8bc4bf98b6a8d5e147a5e52de261d135b/media/cast/test/utility/tap_proxy.cc
[modify] https://crrev.com/e74ea6f8bc4bf98b6a8d5e147a5e52de261d135b/media/filters/ffmpeg_demuxer_unittest.cc

Project Member

Comment 173 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/207e2db51feb6892f1624886191d8a5532fb3516

commit 207e2db51feb6892f1624886191d8a5532fb3516
Author: fdoray <fdoray@chromium.org>
Date: Wed Sep 07 17:45:51 2016

Remove calls to deprecated MessageLoop methods in device.

This CL (hopefully) removes all calls to these methods in device:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2311093005
Cr-Commit-Position: refs/heads/master@{#416985}

[modify] https://crrev.com/207e2db51feb6892f1624886191d8a5532fb3516/device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc
[modify] https://crrev.com/207e2db51feb6892f1624886191d8a5532fb3516/device/bluetooth/bluez/bluetooth_audio_sink_bluez_unittest.cc

Project Member

Comment 174 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c948f7a741bcc7b70d6a7114dcb62f176f8b55f

commit 3c948f7a741bcc7b70d6a7114dcb62f176f8b55f
Author: fdoray <fdoray@chromium.org>
Date: Wed Sep 07 21:50:21 2016

Remove calls to deprecated MessageLoop methods in ui.

This CL (hopefully) removes all calls to these methods in ui:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2315003002
Cr-Commit-Position: refs/heads/master@{#417059}

[modify] https://crrev.com/3c948f7a741bcc7b70d6a7114dcb62f176f8b55f/ui/arc/notification/arc_notification_manager_unittest.cc
[modify] https://crrev.com/3c948f7a741bcc7b70d6a7114dcb62f176f8b55f/ui/base/cocoa/menu_controller_unittest.mm

Project Member

Comment 175 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef08228e90549078a45a71c094edd9917640d1f1

commit ef08228e90549078a45a71c094edd9917640d1f1
Author: fdoray <fdoray@chromium.org>
Date: Wed Sep 07 21:59:22 2016

Remove calls to deprecated MessageLoop methods in android_webview.

This CL (hopefully) removes all calls to these methods in android_webview:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2315863002
Cr-Commit-Position: refs/heads/master@{#417069}

[modify] https://crrev.com/ef08228e90549078a45a71c094edd9917640d1f1/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
[modify] https://crrev.com/ef08228e90549078a45a71c094edd9917640d1f1/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/ef08228e90549078a45a71c094edd9917640d1f1/android_webview/browser/test/rendering_test.h

Project Member

Comment 176 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dbfd37b66cea913f60d8069b3f9b0fe593d11a7

commit 1dbfd37b66cea913f60d8069b3f9b0fe593d11a7
Author: fdoray <fdoray@chromium.org>
Date: Thu Sep 08 16:13:45 2016

Remove calls to deprecated MessageLoop methods in ios.

This CL (hopefully) removes all calls to these methods in ios:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2314243002
Cr-Commit-Position: refs/heads/master@{#417305}

[modify] https://crrev.com/1dbfd37b66cea913f60d8069b3f9b0fe593d11a7/ios/chrome/browser/browser_state/test_chrome_browser_state.mm
[modify] https://crrev.com/1dbfd37b66cea913f60d8069b3f9b0fe593d11a7/ios/web/webui/url_data_manager_ios_backend.mm

Project Member

Comment 177 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dce56180ec95f2609b67a40a28c284ef8025dd76

commit dce56180ec95f2609b67a40a28c284ef8025dd76
Author: fdoray <fdoray@chromium.org>
Date: Fri Sep 09 14:52:24 2016

Revert of Remove calls to MessageLoop::current() in ios. (patchset #1 id:1 of https://codereview.chromium.org/2079423002/ )

Reason for revert:
This causes crashes during browser startup.

Original issue's description:
> Remove calls to MessageLoop::current() in ios.
>
> Why?
> The fact that there's a MessageLoop on the thread is an
> unnecessary implementation detail. When browser threads
> are migrated to base/task_scheduler, tasks will no longer
> have access to a MessageLoop.
>
> These changes were generated manually.
>
> BUG=616447
> R=droger@chromium.org
>
> Committed: https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2
> Cr-Commit-Position: refs/heads/master@{#401027}

TBR=sdefresne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=616447

Review-Url: https://codereview.chromium.org/2326053002
Cr-Commit-Position: refs/heads/master@{#417583}

[modify] https://crrev.com/dce56180ec95f2609b67a40a28c284ef8025dd76/ios/web/web_thread_impl.cc

Do we need a different bug to get approval to CP the revert in #177 to M53/M54?
Project Member

Comment 179 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa3834aaf2517ad14f4886ac34195770eb91de2f

commit aa3834aaf2517ad14f4886ac34195770eb91de2f
Author: fdoray <fdoray@chromium.org>
Date: Fri Sep 09 18:19:01 2016

Remove calls to deprecated MessageLoop methods in chrome.

This CL (hopefully) removes all calls to these methods in chrome:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2315443004
Cr-Commit-Position: refs/heads/master@{#417639}

[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/app_shim/chrome_main_app_mode_mac.mm
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/android/download/download_manager_service_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/chromeos/policy/device_quirks_policy_browsertest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/extensions/extension_user_script_loader_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/extensions/menu_manager_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/history/android/android_history_provider_service_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/history/android/sqlite_cursor_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/media/webrtc/desktop_media_list_ash_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/renderer/media/chrome_webrtc_log_message_delegate_unittest.cc
[modify] https://crrev.com/aa3834aaf2517ad14f4886ac34195770eb91de2f/chrome/tools/service_discovery_sniffer/service_discovery_sniffer.cc

Project Member

Comment 180 by bugdroid1@chromium.org, Sep 9 2016

Labels: merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9056af1484bb9ee0a4e49d62613c5bd1f9fb3e90

commit 9056af1484bb9ee0a4e49d62613c5bd1f9fb3e90
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Sep 09 18:29:55 2016

Revert of Remove calls to MessageLoop::current() in ios. (patchset #1 id:1 of https://codereview.chromium.org/2079423002/ )

Reason for revert:
This causes crashes during browser startup.

Original issue's description:
> Remove calls to MessageLoop::current() in ios.
>
> Why?
> The fact that there's a MessageLoop on the thread is an
> unnecessary implementation detail. When browser threads
> are migrated to base/task_scheduler, tasks will no longer
> have access to a MessageLoop.
>
> These changes were generated manually.
>
> BUG=616447
> R=droger@chromium.org
>
> Committed: https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2
> Cr-Commit-Position: refs/heads/master@{#401027}

TBR=sdefresne@chromium.org
BUG=616447

Review-Url: https://codereview.chromium.org/2326053002
Cr-Commit-Position: refs/heads/master@{#417583}
(cherry picked from commit dce56180ec95f2609b67a40a28c284ef8025dd76)

Review URL: https://codereview.chromium.org/2329533002 .

Cr-Commit-Position: refs/branch-heads/2785@{#864}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/9056af1484bb9ee0a4e49d62613c5bd1f9fb3e90/ios/web/web_thread_impl.cc

Project Member

Comment 181 by bugdroid1@chromium.org, Sep 9 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6cdd5581ab37389cdbed12ecc71d76e94b19f95

commit b6cdd5581ab37389cdbed12ecc71d76e94b19f95
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Sep 09 18:37:52 2016

Revert of Remove calls to MessageLoop::current() in ios. (patchset #1 id:1 of https://codereview.chromium.org/2079423002/ )

Reason for revert:
This causes crashes during browser startup.

Original issue's description:
> Remove calls to MessageLoop::current() in ios.
>
> Why?
> The fact that there's a MessageLoop on the thread is an
> unnecessary implementation detail. When browser threads
> are migrated to base/task_scheduler, tasks will no longer
> have access to a MessageLoop.
>
> These changes were generated manually.
>
> BUG=616447
> R=droger@chromium.org
>
> Committed: https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2
> Cr-Commit-Position: refs/heads/master@{#401027}

TBR=sdefresne@chromium.org
BUG=616447,634907

Review-Url: https://codereview.chromium.org/2326053002
Cr-Commit-Position: refs/heads/master@{#417583}
(cherry picked from commit dce56180ec95f2609b67a40a28c284ef8025dd76)

Review URL: https://codereview.chromium.org/2324253002 .

Cr-Commit-Position: refs/branch-heads/2840@{#277}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/b6cdd5581ab37389cdbed12ecc71d76e94b19f95/ios/web/web_thread_impl.cc

Project Member

Comment 182 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5b47fd134d1bf5613c9898c04ea280cd20df544

commit f5b47fd134d1bf5613c9898c04ea280cd20df544
Author: fdoray <fdoray@chromium.org>
Date: Tue Sep 13 14:12:36 2016

Remove calls to deprecated MessageLoop methods in chromeos.

This CL (hopefully) removes all calls to these methods in chromeos:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2314853004
Cr-Commit-Position: refs/heads/master@{#418234}

[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/audio/cras_audio_handler_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/dbus/cras_audio_client_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/dbus/gsm_sms_client_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/dbus/modem_messaging_client_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/dbus/services/service_provider_test_helper.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/dbus/shill_device_client_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/dbus/shill_ipconfig_client_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/dbus/shill_manager_client_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/dbus/shill_profile_client_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/dbus/shill_service_client_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/dbus/shill_third_party_vpn_driver_client_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/disks/disk_mount_manager_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/geolocation/simple_geolocation_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/network/geolocation_handler_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/network/host_resolver_impl_chromeos_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/network/managed_network_configuration_handler_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/network/network_configuration_handler_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/network/network_device_handler_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/network/network_sms_handler_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/network/network_state_handler_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/network/prohibited_technologies_handler_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/network/shill_property_handler_unittest.cc
[modify] https://crrev.com/f5b47fd134d1bf5613c9898c04ea280cd20df544/chromeos/process_proxy/process_proxy_unittest.cc

Project Member

Comment 183 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7532c960faf5f59ef7031e4488fce36b6e1c1cf0

commit 7532c960faf5f59ef7031e4488fce36b6e1c1cf0
Author: fdoray <fdoray@chromium.org>
Date: Tue Sep 13 20:14:37 2016

No destruction observer in file_path_watcher_linux.cc

MessageLoop::current()->Add/RemoveDestructionObserver won't be
supported in base/task_scheduler. This CL removes calls to these
methods from file_path_watcher_linux.cc

Before this CL, FilePathWatcherImpl registered itself to be notified
when the MessageLoop on which the watch was initiated was destroyed.
When that notification was received, it canceled the watch. With this
CL, no cancelation happens when the MessageLoop is destroyed. Instead,
a cancelation happens when the FilePathWatcherImpl is destroyed.

What happens if the MessageLoop is destroyed before the
FilePathWatcherImpl is destroyed?:

If the parent FilePathWatcher is deleted on the MessageLoop thread:
- ~FilePathWatcher calls FilePathWatcherImpl::Cancel() which
  synchronously calls
  FilePathWatcherImpl::CancelOnMessageLoopThreadOrInDestructor().
  That cancels the watch. The FilePathWatcherImpl is destroyed when
  the FilePathWatcher releases its reference.

If the parent FilePathWatcher is deleted on another thread:
- ~FilePathWatcher calls FilePathWatcherImpl::Cancel() which posts
  a FilePathWatcherImpl::CancelOnMessageLoopThread() task to the
  MessageLoop's TaskRunner. Since the MessageLoop has been destroyed,
  the task is dropped. This causes the last reference to
  FilePathWatcherImpl to be released. ~FilePathWatcherImpl is called
  synchronously (and calls
  FilePathWatcher::CancelOnMessageLoopThreadOrInDestructor).
  Since the MessageLoop doesn't exist anymore, there is no
  thread-safety problem.

BUG=616447

Review-Url: https://codereview.chromium.org/2123053004
Cr-Commit-Position: refs/heads/master@{#418349}

[modify] https://crrev.com/7532c960faf5f59ef7031e4488fce36b6e1c1cf0/base/files/file_path_watcher_linux.cc

Project Member

Comment 184 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5ddcaf43656b807bddec683e8c031e46b8c6ffa

commit d5ddcaf43656b807bddec683e8c031e46b8c6ffa
Author: fdoray <fdoray@chromium.org>
Date: Tue Sep 13 20:40:09 2016

Remove calls to deprecated MessageLoop methods in components.

This CL (hopefully) removes all calls to these methods in components:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=caitkp@chromium.org

Review-Url: https://codereview.chromium.org/2315833003
Cr-Commit-Position: refs/heads/master@{#418355}

[modify] https://crrev.com/d5ddcaf43656b807bddec683e8c031e46b8c6ffa/components/exo/gamepad_unittest.cc
[modify] https://crrev.com/d5ddcaf43656b807bddec683e8c031e46b8c6ffa/components/storage_monitor/storage_monitor_chromeos_unittest.cc

Project Member

Comment 185 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81f6ee03502186923da48690101f66441ffe14d6

commit 81f6ee03502186923da48690101f66441ffe14d6
Author: fdoray <fdoray@chromium.org>
Date: Thu Sep 15 14:10:36 2016

Remove calls to deprecated MessageLoop methods in net.

This CL (hopefully) removes all calls to these methods in net:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=agl@chromium.org

Review-Url: https://codereview.chromium.org/2315873002
Cr-Commit-Position: refs/heads/master@{#418861}

[modify] https://crrev.com/81f6ee03502186923da48690101f66441ffe14d6/net/android/network_change_notifier_android_unittest.cc
[modify] https://crrev.com/81f6ee03502186923da48690101f66441ffe14d6/net/dns/dns_config_service_posix_unittest.cc

Project Member

Comment 186 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9a1fd9b3492481bf34076a05dccda8473be2eba0

commit 9a1fd9b3492481bf34076a05dccda8473be2eba0
Author: fdoray <fdoray@google.com>
Date: Thu Sep 15 18:24:09 2016

Project Member

Comment 187 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb7015f91f55995956e2c07d52cef3b95eb60801

commit fb7015f91f55995956e2c07d52cef3b95eb60801
Author: fdoray <fdoray@chromium.org>
Date: Thu Sep 15 18:51:51 2016

Remove calls to deprecated MessageLoop methods in components/previews/.

This CL removes calls to MessageLoop::RunUntilIdle from
components/previews/.

BUG=616447

Review-Url: https://codereview.chromium.org/2348503002
Cr-Commit-Position: refs/heads/master@{#418921}

[modify] https://crrev.com/fb7015f91f55995956e2c07d52cef3b95eb60801/components/previews/previews_io_data_unittest.cc
[modify] https://crrev.com/fb7015f91f55995956e2c07d52cef3b95eb60801/components/previews/previews_ui_service_unittest.cc

Project Member

Comment 188 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a93afc284a6b18b1df8c363c2700ec32f69b56af

commit a93afc284a6b18b1df8c363c2700ec32f69b56af
Author: fdoray <fdoray@chromium.org>
Date: Thu Sep 15 18:59:07 2016

Remove calls to deprecated MessageLoop methods from message_loop_unittest.cc.

This CL removes calls to MessageLoop::Post(Delayed)Task from
message_loop_unittest.cc

BUG=616447

Review-Url: https://codereview.chromium.org/2342903002
Cr-Commit-Position: refs/heads/master@{#418925}

[modify] https://crrev.com/a93afc284a6b18b1df8c363c2700ec32f69b56af/base/message_loop/message_loop_unittest.cc

Project Member

Comment 189 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/aceb6a6d2d857547d8ce5ab07e88c8401c5eb843

commit aceb6a6d2d857547d8ce5ab07e88c8401c5eb843
Author: fdoray <fdoray@google.com>
Date: Fri Sep 16 18:19:51 2016

Btw, comment #125 is awesome. Any chance of documenting how to integrate into the clang-tidy pipeline, similar to how we have https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tool_refactoring.md ?
Project Member

Comment 191 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8f41410b8ae7ace0ed51191668451ab40689233

commit f8f41410b8ae7ace0ed51191668451ab40689233
Author: fdoray <fdoray@chromium.org>
Date: Wed Sep 21 15:45:59 2016

Delete MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon.

These methods are deprecated and are no longer used in Chrome. To post
a task to a MessageLoop, developers should use its TaskRunner:

s/MessageLoop::current()->PostTask/ThreadTaskRunnerHandle::Get()->PostTask/
s/MessageLoop::current()->PostDelayedTask/ThreadTaskRunnerHandle::Get()->PostDelayedTask/
s/MessageLoop::current()->DeleteSoon/ThreadTaskRunnerHandle::Get()->DeleteSoon/
s/MessageLoop::current()->ReleaseSoon/ThreadTaskRunnerHandle::Get()->ReleaseSoon/

s/message_loop->PostTask/message_loop->task_runner()->PostTask/
s/message_loop->PostDelayedTask/message_loop->task_runner()->PostDelayedTask/
s/message_loop->DeleteSoon/message_loop->task_runner()->DeleteSoon/
s/message_loop->ReleaseSoon/message_loop->task_runner()->ReleaseSoon/

BUG=616447

Review-Url: https://codereview.chromium.org/2354053002
Cr-Commit-Position: refs/heads/master@{#420071}

[modify] https://crrev.com/f8f41410b8ae7ace0ed51191668451ab40689233/base/message_loop/message_loop.cc
[modify] https://crrev.com/f8f41410b8ae7ace0ed51191668451ab40689233/base/message_loop/message_loop.h

Project Member

Comment 193 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5e45f6b0a71c2a174bea1219f9a6709191fde50

commit c5e45f6b0a71c2a174bea1219f9a6709191fde50
Author: fdoray <fdoray@chromium.org>
Date: Thu Sep 22 15:06:07 2016

Remove calls to MessageLoop(ForUI|ForIO)::Run/RunUntilIdle.

This CL makes the following replacements:

1.
base::MessageLoopForUIorIO::current()->Run()/RunUntilIdle();
becomes
// This ASSERT_TRUE replaces the DCHECK in
// MessageLoopForUIorIO::current().
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

2.
message_loop_for_ui_or_io.Run()/RunUntilIdle();
becomes
// The ASSERT_TRUE is present only if it isn't obvious that
// the current thread runs a MessageLoopForUIorIO (e.g.
// because it isn't instantiated in the current file).
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

BUG=616447

Review-Url: https://codereview.chromium.org/2354333002
Cr-Commit-Position: refs/heads/master@{#420342}

[modify] https://crrev.com/c5e45f6b0a71c2a174bea1219f9a6709191fde50/base/cancelable_callback.h
[modify] https://crrev.com/c5e45f6b0a71c2a174bea1219f9a6709191fde50/base/memory/memory_pressure_monitor_chromeos_unittest.cc
[modify] https://crrev.com/c5e45f6b0a71c2a174bea1219f9a6709191fde50/chrome/browser/chromeos/login/test/wizard_in_process_browser_test.cc
[modify] https://crrev.com/c5e45f6b0a71c2a174bea1219f9a6709191fde50/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
[modify] https://crrev.com/c5e45f6b0a71c2a174bea1219f9a6709191fde50/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/c5e45f6b0a71c2a174bea1219f9a6709191fde50/chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc
[modify] https://crrev.com/c5e45f6b0a71c2a174bea1219f9a6709191fde50/components/policy/core/common/policy_loader_mac_unittest.cc

Project Member

Comment 196 by bugdroid1@chromium.org, Sep 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdc92d477d3700ef5a8ad34d2098975f832f9ef3

commit cdc92d477d3700ef5a8ad34d2098975f832f9ef3
Author: fdoray <fdoray@chromium.org>
Date: Mon Sep 26 18:52:58 2016

Remove calls to MessageLoop::Run/RunUntilIdle.

These methods are deprecated. RunLoop should be used instead.

BUG=616447
TBR=eugenebut@chromium.org

Review-Url: https://codereview.chromium.org/2361203002
Cr-Commit-Position: refs/heads/master@{#420950}

[modify] https://crrev.com/cdc92d477d3700ef5a8ad34d2098975f832f9ef3/chrome/browser/chromeos/login/oobe_localization_browsertest.cc
[modify] https://crrev.com/cdc92d477d3700ef5a8ad34d2098975f832f9ef3/chrome/browser/media/webrtc/native_desktop_media_list_unittest.cc
[modify] https://crrev.com/cdc92d477d3700ef5a8ad34d2098975f832f9ef3/chrome/utility/importer/firefox_importer_unittest_utils.h
[modify] https://crrev.com/cdc92d477d3700ef5a8ad34d2098975f832f9ef3/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
[modify] https://crrev.com/cdc92d477d3700ef5a8ad34d2098975f832f9ef3/components/previews/core/previews_io_data_unittest.cc
[modify] https://crrev.com/cdc92d477d3700ef5a8ad34d2098975f832f9ef3/components/previews/core/previews_ui_service_unittest.cc
[modify] https://crrev.com/cdc92d477d3700ef5a8ad34d2098975f832f9ef3/ios/web/net/request_tracker_impl_unittest.mm
[modify] https://crrev.com/cdc92d477d3700ef5a8ad34d2098975f832f9ef3/ios/web/public/test/web_test_with_web_state.mm
[modify] https://crrev.com/cdc92d477d3700ef5a8ad34d2098975f832f9ef3/media/audio/android/audio_android_unittest.cc

Project Member

Comment 197 by bugdroid1@chromium.org, Sep 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21ffea60f63de8446367264703e6b3e2fa5a2c4e

commit 21ffea60f63de8446367264703e6b3e2fa5a2c4e
Author: fdoray <fdoray@chromium.org>
Date: Tue Sep 27 01:24:26 2016

Delete MessageLoop::Run()/RunUntilIdle().

These methods are deprecated and no longer used in Chrome.
base::RunLoop must be used instead.

e.g.:

Replace
  message_loop.Run();
With
  base::RunLoop run_loop;
  // Pass |run_loop.QuitClosure()| to an object/task
  // that will quit the RunLoop when appropriate.
  run_loop.Run();

Replace
  message_loop.RunUntilIdle();
With
  base::RunLoop().RunUntilIdle();

BUG=616447

Review-Url: https://codereview.chromium.org/2356383003
Cr-Commit-Position: refs/heads/master@{#421068}

[modify] https://crrev.com/21ffea60f63de8446367264703e6b3e2fa5a2c4e/base/message_loop/message_loop.cc
[modify] https://crrev.com/21ffea60f63de8446367264703e6b3e2fa5a2c4e/base/message_loop/message_loop.h

Status: Fixed (was: Started)
Project Member

Comment 199 by bugdroid1@chromium.org, Sep 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b254e0eeb34a51af29409b7cd3abae5d06f37148

commit b254e0eeb34a51af29409b7cd3abae5d06f37148
Author: fdoray <fdoray@chromium.org>
Date: Tue Sep 27 17:33:05 2016

Remove call to MessageLoop::QuitWhenIdle() in network_time_tracker.cc.

MessageLoop::QuitWhenIdle() is deprecated. RunLoop should be used
instead.

BUG=616447

Review-Url: https://codereview.chromium.org/2376693002
Cr-Commit-Position: refs/heads/master@{#421251}

[modify] https://crrev.com/b254e0eeb34a51af29409b7cd3abae5d06f37148/components/network_time/network_time_tracker.cc
[modify] https://crrev.com/b254e0eeb34a51af29409b7cd3abae5d06f37148/components/network_time/network_time_tracker.h

Project Member

Comment 200 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb4e32fc88050cd82bdb74edc90fb4fe3dfe56e7

commit fb4e32fc88050cd82bdb74edc90fb4fe3dfe56e7
Author: fdoray <fdoray@chromium.org>
Date: Tue Sep 27 20:12:05 2016

Remove call to MessageLoop::QuitWhenIdle() in auto_thread.cc.

MessageLoop::QuitWhenIdle() is deprecated. RunLoop should be used
instead.

BUG=616447

Review-Url: https://codereview.chromium.org/2373033002
Cr-Commit-Position: refs/heads/master@{#421313}

[modify] https://crrev.com/fb4e32fc88050cd82bdb74edc90fb4fe3dfe56e7/remoting/base/auto_thread.cc
[modify] https://crrev.com/fb4e32fc88050cd82bdb74edc90fb4fe3dfe56e7/remoting/base/auto_thread.h

Project Member

Comment 201 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6cdd5581ab37389cdbed12ecc71d76e94b19f95

commit b6cdd5581ab37389cdbed12ecc71d76e94b19f95
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Sep 09 18:37:52 2016

Revert of Remove calls to MessageLoop::current() in ios. (patchset #1 id:1 of https://codereview.chromium.org/2079423002/ )

Reason for revert:
This causes crashes during browser startup.

Original issue's description:
> Remove calls to MessageLoop::current() in ios.
>
> Why?
> The fact that there's a MessageLoop on the thread is an
> unnecessary implementation detail. When browser threads
> are migrated to base/task_scheduler, tasks will no longer
> have access to a MessageLoop.
>
> These changes were generated manually.
>
> BUG=616447
> R=droger@chromium.org
>
> Committed: https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2
> Cr-Commit-Position: refs/heads/master@{#401027}

TBR=sdefresne@chromium.org
BUG=616447,634907

Review-Url: https://codereview.chromium.org/2326053002
Cr-Commit-Position: refs/heads/master@{#417583}
(cherry picked from commit dce56180ec95f2609b67a40a28c284ef8025dd76)

Review URL: https://codereview.chromium.org/2324253002 .

Cr-Commit-Position: refs/branch-heads/2840@{#277}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/b6cdd5581ab37389cdbed12ecc71d76e94b19f95/ios/web/web_thread_impl.cc

Project Member

Comment 202 by bugdroid1@chromium.org, Aug 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1513b3777d69b2683c7f0d749db23bfe8e271dd2

commit 1513b3777d69b2683c7f0d749db23bfe8e271dd2
Author: Dominick Ng <dominickn@chromium.org>
Date: Sat Aug 18 00:07:51 2018

Remove some usage of base::MessageLoopCurrent::SetTaskRunner() in tests.

This is an expanded and leak-fixed reland of crrev.com/c/1177641 and
crrev.com/c/1176894, though it tackles the root of the problem rather than
working around it.

base::MessageLoopCurrent::SetTaskRunner() is deprecated since only owners of
the MessageLoop instance should replace its TaskRunner. Odd things happen in
tests when the message loop task runner is replaced and a profile is
instantiated. This CL removes some more usage of the method in tests where
there is interaction with a TestingProfile object.

BUG=616447

Change-Id: Ic2ad6eb2a8699f103e432af74ad9c71c1dd43656
Reviewed-on: https://chromium-review.googlesource.com/1179111
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584249}
[modify] https://crrev.com/1513b3777d69b2683c7f0d749db23bfe8e271dd2/chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.cc
[modify] https://crrev.com/1513b3777d69b2683c7f0d749db23bfe8e271dd2/chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.h
[modify] https://crrev.com/1513b3777d69b2683c7f0d749db23bfe8e271dd2/chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_unittest.cc
[modify] https://crrev.com/1513b3777d69b2683c7f0d749db23bfe8e271dd2/chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc
[modify] https://crrev.com/1513b3777d69b2683c7f0d749db23bfe8e271dd2/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc

Showing comments 103 - 202 of 202 Older

Sign in to add a comment