New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616443 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Removing pdfium from .gclient and resyncing fails

Project Member Reported by rmis...@chromium.org, Jun 1 2016

Issue description

How to reproduce:

* mkdir /tmp/repos && cd /tmp/repos

* Create a .gclient file with:
"""
solutions = [
  { "name"        : "buildbot",
    "url"         : "https://skia.googlesource.com/buildbot.git",
    "deps_file"   : "DEPS",
    "managed"     : True,
    "custom_deps" : {
    },
    "safesync_url": "",
  },

  { "name"        : "pdfium",                                                   
    "url"         : "https://pdfium.googlesource.com/pdfium.git",               
    "deps_file"   : "DEPS",                                                     
    "managed"     : False,                                                      
    "custom_deps" : {                                                           
    },                                                                          
    "safesync_url": "",                                                         
  },                     
]
"""

* gclient sync

* Edit .gclient file and remove the "pdfium" solution.

* gclient sync


The command fails with:

Error: Command 'git merge-base HEAD origin' returned non-zero exit status 1 in /repos/tmp/repos/pdfium/buildtools/third_party/libc++/trunk



Any ideas?
 

Comment 1 by aga...@chromium.org, Jun 21 2016

Status: Started (was: Available)
The libc++ and libc++abi repos were updated to be direct mirrors of the Git repos which are maintained by upstream, as opposed to be mirrored from SVN by us. The old hashes were preserved (so gclient sync works at all), but they don't share any history with the new master, and so merge-base fails to find anything.

I have a CL to fix it here: https://codereview.chromium.org/2089613003

Comment 2 by aga...@chromium.org, Jun 21 2016

Status: Fixed (was: Started)

Comment 3 by rmis...@google.com, Jun 22 2016

Thanks for the fix Aaron!

Note to self: The fix will not make it into PDFium till they update buildtools_revision in their DEPS to "573942cffe9494e3d9f05ada4c61e1f32a1c58fc".

Sign in to add a comment