Issue metadata
Sign in to add a comment
|
Regression: Unnecessary chevron icon is draggable on Bookmark bar.
Reported by
dmascare...@etouch.net,
Jun 1 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:53.0.2754.0 (Official Build)ab317e073bd7b2cb74c405f23008d0a6d4db6270-refs/heads/master@{#397000} 64 bit OS:Mac (10.10.5 , 10.11.4),Mac Retina (10.11.4) Pre-condition: Bookmark 8-10 webpages. What steps will reproduce the problem? 1. Launch chrome and resize the browser window such that chevron icon should be seen on bookmark. 2. Try drag the chevron icon and observe Actual: Unnecessary chevron icon is draggable on Bookmark bar. Expected: Chevron icon should not be draggable on Bookmark bar . This is regression issue,broken in ‘M 52’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/d195033a24b74413492685d93766932b64ad571e..27ceeaa6e172119ef8c1c7e21f0c61ea824d5e83?pretty=fuller&n=100 Suspecting: r394165 ? Good build:52.0.2739.0 Bad build:52.0.2740.0 Note: Above issue is not reproducible on Windows and Linux OS.
,
Jun 1 2016
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29e90b8c7137c5e83a021a8453de434fc5968255 commit 29e90b8c7137c5e83a021a8453de434fc5968255 Author: shrike <shrike@chromium.org> Date: Thu Jun 02 21:57:57 2016 [Mac][Material Design] Fix regression allowing chevron button dragging. A recent regression left the bookmarks bar's chevron button draggable when it should not be. R=avi@chromium.org BUG= 616412 Review-Url: https://codereview.chromium.org/2035843003 Cr-Commit-Position: refs/heads/master@{#397522} [modify] https://crrev.com/29e90b8c7137c5e83a021a8453de434fc5968255/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
,
Jun 3 2016
dmascarenhas@ please verify in latest canary.
,
Jun 6 2016
With response to comment #4: Above issue seems to be fixed on latest canary version: 53.0.2759.0 (Official Build) 5a1a04452d17cdc3c669949ad74a2f9b6e66b97e-refs/heads/master@{#397936}
,
Jun 6 2016
,
Jun 6 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 6 2016
Please merge your change to M52 branch 2743 before 3:00 PM PST tomorrow, Tuesday (06/07) so we can take it for this week beta release. Thank you.
,
Jun 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2249211da2577996fdea00d5659f6eeaa80c226c commit 2249211da2577996fdea00d5659f6eeaa80c226c Author: Jayson Adams <shrike@chromium.org> Date: Tue Jun 07 01:10:51 2016 [Mac][Material Design] Fix regression allowing chevron button dragging. A recent regression left the bookmarks bar's chevron button draggable when it should not be. R=avi@chromium.org BUG= 616412 Review-Url: https://codereview.chromium.org/2035843003 Cr-Commit-Position: refs/heads/master@{#397522} (cherry picked from commit 29e90b8c7137c5e83a021a8453de434fc5968255) Review URL: https://codereview.chromium.org/2046853002 . Cr-Commit-Position: refs/branch-heads/2743@{#254} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/2249211da2577996fdea00d5659f6eeaa80c226c/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
,
Jun 7 2016
,
Jun 8 2016
Tested the same on mac 10.11 chrome version 52.0.2743.33 - Chevron icon is not draggable on Bookmark bar as expected. Fix works as expected
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2249211da2577996fdea00d5659f6eeaa80c226c commit 2249211da2577996fdea00d5659f6eeaa80c226c Author: Jayson Adams <shrike@chromium.org> Date: Tue Jun 07 01:10:51 2016 [Mac][Material Design] Fix regression allowing chevron button dragging. A recent regression left the bookmarks bar's chevron button draggable when it should not be. R=avi@chromium.org BUG= 616412 Review-Url: https://codereview.chromium.org/2035843003 Cr-Commit-Position: refs/heads/master@{#397522} (cherry picked from commit 29e90b8c7137c5e83a021a8453de434fc5968255) Review URL: https://codereview.chromium.org/2046853002 . Cr-Commit-Position: refs/branch-heads/2743@{#254} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/2249211da2577996fdea00d5659f6eeaa80c226c/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tkonch...@chromium.org
, Jun 1 2016