Issue metadata
Sign in to add a comment
|
Regression: Weird highlight of Apps icon is seen on Bookmark bar.
Reported by
dmascare...@etouch.net,
Jun 1 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:53.0.2754.0 (Official Build)ab317e073bd7b2cb74c405f23008d0a6d4db6270-refs/heads/master@{#397000} 64 bit OS:Mac (10.10.5 , 10.11.4) Test url:https://chrome.google.com/webstore/detail/black-red-shards/jpjlkkaalgfbbegfnjoclhfidancjpch?hl=en Pre-condition:Apply darker theme.(for eg:Black red shards theme using above url) What steps will reproduce the problem? 1. Launch chrome, open NTP and Hover the mouse on Apps icon, then long click on it. 2. Observe highlight. Actual: Weird highlight of Apps icon is seen (i.e. hover highlight is 1 pixel more then the click highlight) Expected: Highlight should be proper. This is regression issue,broken in ‘M 52’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/d195033a24b74413492685d93766932b64ad571e..27ceeaa6e172119ef8c1c7e21f0c61ea824d5e83?pretty=fuller&n=100 Suspecting: r394165 ? Good build:52.0.2739.0 Bad build:52.0.2740.0 Note:1. Above issue is not reproducible on Windows and Linux OS. 2. Above issue is not reproducible on Mac Retina(10.11.4)
,
Jun 1 2016
,
Jun 2 2016
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9cb6c37c2528abe53a22ef943e61764a1de9181 commit f9cb6c37c2528abe53a22ef943e61764a1de9181 Author: shrike <shrike@chromium.org> Date: Thu Jun 02 20:50:26 2016 [Mac][Material Design] Fix strange Apps button highlight in dark themes. The button needs to be set to not show highlighting. R=avi@chromium.org BUG= 616406 Review-Url: https://codereview.chromium.org/2031023002 Cr-Commit-Position: refs/heads/master@{#397502} [modify] https://crrev.com/f9cb6c37c2528abe53a22ef943e61764a1de9181/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
,
Jun 3 2016
dmascarenhas@ please verify in latest canary.
,
Jun 6 2016
With response to comment #5: Above issue seems to be fixed on Latest Canary Version:53.0.2759.0 (Official Build)5a1a04452d17cdc3c669949ad74a2f9b6e66b97e-refs/heads/master@{#397936}
,
Jun 6 2016
dmascarenhas@ Thanks for verifying. shrike@ please request a merge ASAP so that we could take for next beta rc cut @ 4.00 pm tomorrow (06/07 - Tuesday)
,
Jun 7 2016
,
Jun 7 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cc43b3fd96568c32750a3e332fef8624ce2e5a0 commit 6cc43b3fd96568c32750a3e332fef8624ce2e5a0 Author: Jayson Adams <shrike@chromium.org> Date: Wed Jun 08 05:16:42 2016 [Mac][Material Design] Fix strange Apps button highlight in dark themes. The button needs to be set to not show highlighting. R=avi@chromium.org BUG= 616406 Review-Url: https://codereview.chromium.org/2031023002 Cr-Commit-Position: refs/heads/master@{#397502} (cherry picked from commit f9cb6c37c2528abe53a22ef943e61764a1de9181) Review URL: https://codereview.chromium.org/2044923005 . Cr-Commit-Position: refs/branch-heads/2743@{#276} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/6cc43b3fd96568c32750a3e332fef8624ce2e5a0/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
,
Jun 9 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cc43b3fd96568c32750a3e332fef8624ce2e5a0 commit 6cc43b3fd96568c32750a3e332fef8624ce2e5a0 Author: Jayson Adams <shrike@chromium.org> Date: Wed Jun 08 05:16:42 2016 [Mac][Material Design] Fix strange Apps button highlight in dark themes. The button needs to be set to not show highlighting. R=avi@chromium.org BUG= 616406 Review-Url: https://codereview.chromium.org/2031023002 Cr-Commit-Position: refs/heads/master@{#397502} (cherry picked from commit f9cb6c37c2528abe53a22ef943e61764a1de9181) Review URL: https://codereview.chromium.org/2044923005 . Cr-Commit-Position: refs/branch-heads/2743@{#276} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/6cc43b3fd96568c32750a3e332fef8624ce2e5a0/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
,
Jun 15 2016
Tested the issue on Mac 10.11.5 using chrome version 52.0.2743.41.Not observed the weird highlight on APPS icon with long click. Please find the attached screen cast for the same. Adding TE-Verified label. Thanks, |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tkonch...@chromium.org
, Jun 1 2016