Issue metadata
Sign in to add a comment
|
Regression : Traces of Theme is seen on Tab strip of New Profile |
||||||||||||||||||||||
Issue descriptionVersion: 51.0.2704.79 OS: Ubuntu 14.04,Windows URL : https://chrome.google.com/webstore/detail/panda-dumpling/caaclfkfmcnlppkambfehbfhlekhpenf?hl=en-GB What steps will reproduce the problem? (1)Launch Chrome -> Go to above URL to add "Panda-dumpling" Theme (2)After theme is added -> Click on Avatar Icon->Click on 'Switch person' option for User Manager window -> Click on "Add Person"(Say "Person2") (3)Now Go to Person 2 and click on NTP -> Now observe Traces of "Panda-dumpling" Theme on Tab strip (Please refer Video) Expected:No Traces of Theme should be seen on Tab strip of New Profile Actual: Instead Traces of Theme is seen on Tab strip This is Regression Issue broken in M-51 Manual good and Bad Builds: Good Build: 51.0.2666.0 Bad Build: 51.0.2667.0 Below is the Bisect info: CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/a9af97d82c54e699fb369db0fdc8e44923af03d7..e4dae472b2f122a5c93dc3f7338ee946eda677b1 Suspecting https://codereview.chromium.org/1726743003 from Changelog. @jonross: Please feel free to re-assign if its not related to your change
,
Jun 1 2016
The linked change is not the cause. That was being used to track down a crash in the wild, and has since been reverted. +tdanderson@ who leads the Material Design effort. It looks like the tabs are caching the hovered background state, and it's crossing profiles.
,
Jun 1 2016
Handing this over to Peter for a first look - seems most likely to be a tabstrip bug since only the appearance of the tabs change, not the whole top chrome.
,
Jun 1 2016
This reproduces on trunk. It's enough to merely have the two profile windows open and switch themes. The new theme's background tab color is applied to both profiles. Even stranger glitches can be observed by then opening an incognito window in one profile and rapidly hitting ctrl-T a few times, then doing the same in the other profile. Clearly something about how the tabstrip caches the theme images is not realizing that different profiles are involved.
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85c0fcf270d8f28720054c636748ad506e3a4078 commit 85c0fcf270d8f28720054c636748ad506e3a4078 Author: pkasting <pkasting@chromium.org> Date: Tue Jun 21 21:17:38 2016 Fix tab coloring bugs with multiple open profiles which used different colors. Instead of caching based on incognito state, cache based on the actual colors used. This also fixes what I think was a real bug with not paying attention to a changing stroke color. BUG= 616403 TEST=Install theme from bug comment 0, hit ctrl-T several times, open a window from a second, unthemed profile, hit ctrl-T more times, and verify the tab background color in the second wnidow is the default one and not the themed one. Review-Url: https://codereview.chromium.org/2084583004 Cr-Commit-Position: refs/heads/master@{#401109} [modify] https://crrev.com/85c0fcf270d8f28720054c636748ad506e3a4078/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/85c0fcf270d8f28720054c636748ad506e3a4078/chrome/browser/ui/views/tabs/tab_controller.h [modify] https://crrev.com/85c0fcf270d8f28720054c636748ad506e3a4078/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/85c0fcf270d8f28720054c636748ad506e3a4078/chrome/browser/ui/views/tabs/tab_strip.h [modify] https://crrev.com/85c0fcf270d8f28720054c636748ad506e3a4078/chrome/browser/ui/views/tabs/tab_unittest.cc
,
Jun 21 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by brajkumar@chromium.org
, Jun 1 2016