New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616392 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----

Blocking:
issue 618447
issue 490984
issue 618576



Sign in to add a comment

Switch android gpu isolated script tests to use android-chromium instead of content shell.

Project Member Reported by stip@chromium.org, Jun 1 2016

Issue description

Right now the android script tests use content-shell to run isolated script tests, but they should really use android-chromium. This bug tracks that work.
 

Comment 1 by kbr@chromium.org, Jun 1 2016

Blocking: 490984
Cc: cblume@chromium.org
Labels: -Restrict-View-Google
There's not really a need for this to be restricted view, so un-restricting it.

Comment 2 by kbr@chromium.org, Jun 1 2016

Components: -Infra Blink>Infra Internals>GPU>Testing

Comment 3 by kbr@chromium.org, Jun 7 2016

Cc: ynovikov@chromium.org stip@chromium.org
Owner: kbr@chromium.org
I'll help with this. https://codereview.chromium.org/2046833003 up for review.

Comment 4 by kbr@chromium.org, Jun 8 2016

Blocking: 618447
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eefa898fe35430bd07ec1e4d08ca643f740b0c52

commit eefa898fe35430bd07ec1e4d08ca643f740b0c52
Author: kbr <kbr@chromium.org>
Date: Wed Jun 08 22:03:03 2016

Change Android GPU tests to use Chromium instead of content_shell.

As an added benefit, this should allow some of the multi-tab GPU tests
to be enabled on Android.

BUG= 616392 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2046833003
Cr-Commit-Position: refs/heads/master@{#398696}

[modify] https://crrev.com/eefa898fe35430bd07ec1e4d08ca643f740b0c52/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/eefa898fe35430bd07ec1e4d08ca643f740b0c52/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/eefa898fe35430bd07ec1e4d08ca643f740b0c52/tools/perf/chrome_telemetry_build/BUILD.gn

Comment 6 by kbr@chromium.org, Jun 9 2016

Status: Started (was: Assigned)

Comment 7 by kbr@chromium.org, Jun 9 2016

Blocking: 618576
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf7e0e86095da74d0bba682d53823a0334ecbd2c

commit cf7e0e86095da74d0bba682d53823a0334ecbd2c
Author: kbr <kbr@chromium.org>
Date: Thu Jun 09 06:33:27 2016

Add android-chromium as a browser type to GPU test expectations.

Update previous expectations specific to android-content-shell to
include android-chromium.

BUG= 616392 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Review-Url: https://codereview.chromium.org/2050093002
Cr-Commit-Position: refs/heads/master@{#398798}

[modify] https://crrev.com/cf7e0e86095da74d0bba682d53823a0334ecbd2c/content/test/gpu/gpu_tests/test_expectations.py
[modify] https://crrev.com/cf7e0e86095da74d0bba682d53823a0334ecbd2c/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Comment 9 by kbr@chromium.org, Jun 13 2016

Status: Fixed (was: Started)
This is fixed, but the tests are red on the Nexus 5X bots because of the change ( Issue 618576 ). The current plan is to press forward with this change rather than reverting it, so closing it.

Sign in to add a comment