JS exception on clicking Stop in net-internals |
||||
Issue descriptionVersion: 53.0.2754.0 canary (64-bit) OS: Win7 What steps will reproduce the problem? (1) Open chrome://net-internals/#capture (2) Click Stop (3) Check the devtools console. An error is triggered in the code: if (view.isVisible()) in index.js Note: Changing the above to this.viewList_[view].isVisible() makes it work, but then there is another error in the use of option.value later in this.switchToTab(option.value);
,
Jun 1 2016
I may have broken that on my last refactor, where I bought back the side tab. I can't repro this, curiously. I may look into this at some point, but have enough in my queue that it's quite possible I'll never get around to it.
,
Jul 4 2016
You have to be in the "Capture" view and then click Stop to reproduce.
,
Jul 6 2016
FYI discussion happening on code review. The root of the problem was mistakenly using "for (var x in array)" to iterate over the values of an array. It doesn't, but rather iterates the indices of the array.
,
Jul 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc50caf6b42799a0f3a532872750a09ac4dacc6e commit dc50caf6b42799a0f3a532872750a09ac4dacc6e Author: rchlodnicki <rchlodnicki@opera.com> Date: Sat Jul 16 10:07:46 2016 [net-internals] Fix JS exception on stopping capturing while in Capture view Store a map of link enabled states so that we can use it to enable next visibile view on hidding active view. Map is ordered so it works to iterate it. BUG= 616382 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2121763002 Cr-Commit-Position: refs/heads/master@{#405942} [modify] https://crrev.com/dc50caf6b42799a0f3a532872750a09ac4dacc6e/chrome/browser/resources/net_internals/tab_switcher_view.js
,
Aug 8 2016
Was fixed many days ago. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ha...@opera.com
, Jun 1 2016