New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616370 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

CRAS: Monitor mandatory UCM patches

Project Member Reported by cychiang@chromium.org, Jun 1 2016

Issue description

We have a large refactoring of mixer controls starting from
https://chromium-review.googlesource.com/#/c/343041/9

We need to monitor if there is any regression.

Especially, we need to monitor these tests on dashboard
audio_AudioVolume.speaker (need to check nyan)
audio_AudioVolume.headphone (mostly stable)
audio_AudioVolume.usb (mostly stable)
audio_AudioVolume.hdmi (not stable because of HDMI receiver)

https://wmatrix.googleplex.com/matrix/unfiltered?tests=audio_AudioVolume.headphone&days_back=20&hide_missing=True

https://wmatrix.googleplex.com/matrix/unfiltered?tests=audio_AudioVolume.speaker&days_back=20&hide_missing=True

https://wmatrix.googleplex.com/matrix/unfiltered?tests=audio_AudioVolume.usb&days_back=20&hide_missing=True

https://wmatrix.googleplex.com/matrix/unfiltered?tests=audio_AudioVolume.hdmi&days_back=20&hide_missing=True

I will stabilize these tests and look out for regression.


 
Need to check cyan and jerry external mic. They are not detected.

https://wmatrix.googleplex.com/matrix/unfiltered?suites=chameleon_audio_perbuild&days_back=20&hide_missing=True

I will take a look today. It might be related to the refactoring.
Just tested locally on cyan using 8400.0 image, the issue is confirmed.

Comment 4 by muirj@google.com, Jun 3 2016

Are there logs that indicate that the problem did not exist before these patches? If not, can you test after reverting the changes locally?

Comment 6 by muirj@google.com, Jun 3 2016

Dylan, is there a veyron_jerry available to borrow?
ping me tomorrow and I'll find you one.  Does it have to be a jerry, or will any veyron work?

No worry John, I will check it today. It should not to be too hard to track it down. Thanks!
This should fix it https://chromium-review.googlesource.com/349391.
Thanks!

Comment 10 by muirj@google.com, Jun 3 2016

I guess any veyron should work (audio hardware must be similar for the entire architecture?). Anyway, I can test Jimmy's fix on it. I'll ping you in the AM.
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/9b309795f80f80a001d9051a580f3251bd326e61

commit 9b309795f80f80a001d9051a580f3251bd326e61
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Fri Jun 03 04:26:21 2016

CRAS: alsa_jack - Fix name matching for microphone jack

On some board the microphone jack is "Headset Jack".

BUG= chromium:616370 
TEST=build on cyan, check microphone node is enumerated
TEST=make check

Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
Change-Id: I41da8689cb7a7a3e749721d8136561814f5e2a8a
Reviewed-on: https://chromium-review.googlesource.com/349391

[modify] https://crrev.com/9b309795f80f80a001d9051a580f3251bd326e61/cras/src/server/cras_alsa_jack.c
[modify] https://crrev.com/9b309795f80f80a001d9051a580f3251bd326e61/cras/src/tests/alsa_jack_unittest.cc

Cc: helenzhang@chromium.org sontis@chromium.org shrawan@chromium.org cychiang@chromium.org
 Issue 617259  has been merged into this issue.
Status: Verified (was: Started)

Sign in to add a comment