Issue metadata
Sign in to add a comment
|
Regression: Browser crash is observed on fullscreen ‘chrome://kill' page.
Reported by
dmascare...@etouch.net,
Jun 1 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:53.0.2753.0 (Official Build)bb0c85e1aaa882aa7c4c40b0e3da609573f07d8f-refs/heads/master@{#396745} OS: Mac(10.10.5,10.11.4) What steps will reproduce the problem? 1. Launch chrome and go to NTP or any page. 2. Kill the above page using chrome://kill and click on fullscreen icon from wrench. 3. Observe. Actual: Browser crashes. Expected: Browser should not crash. Crash id: Crash ID 043892a600000000 (79dca5b3-5b15-44af-aa4f-528e7c61b8d5) This is regression issue, broken in ‘M 53’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/7bdc0a395cbdfe329aaab71579e769fa0a6c6fa8..d876a6483cc612153b246577e80fe2d0dc544847?pretty=fuller&n=100 Suspecting: r395457 Good build:53.0.2746.0 Bad build:53.0.2747.0 Note: Above issue is not reproducible on Windows and Linux OS.
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15c873daec19bf34e8b3d4925c9668faaba5e634 commit 15c873daec19bf34e8b3d4925c9668faaba5e634 Author: ccameron <ccameron@chromium.org> Date: Fri Jun 10 08:26:26 2016 Mac fullscreen low power: Add unittests Fix a bug in ChildWindowsChanged, discovered by those tests. Move command line check to controller, to make unittests work. Don't allow entering low power mode until the fullscreen low power layer has been valid for 15 frames. This ensures that we won't get flashes of invalid content. BUG= 616364 Review-Url: https://codereview.chromium.org/2047103003 Cr-Commit-Position: refs/heads/master@{#399135} [modify] https://crrev.com/15c873daec19bf34e8b3d4925c9668faaba5e634/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/15c873daec19bf34e8b3d4925c9668faaba5e634/chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.h [modify] https://crrev.com/15c873daec19bf34e8b3d4925c9668faaba5e634/chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.mm [add] https://crrev.com/15c873daec19bf34e8b3d4925c9668faaba5e634/chrome/browser/ui/cocoa/fullscreen_low_power_coordinator_unittest.mm [modify] https://crrev.com/15c873daec19bf34e8b3d4925c9668faaba5e634/chrome/chrome_tests_unit.gypi
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15c873daec19bf34e8b3d4925c9668faaba5e634 commit 15c873daec19bf34e8b3d4925c9668faaba5e634 Author: ccameron <ccameron@chromium.org> Date: Fri Jun 10 08:26:26 2016 Mac fullscreen low power: Add unittests Fix a bug in ChildWindowsChanged, discovered by those tests. Move command line check to controller, to make unittests work. Don't allow entering low power mode until the fullscreen low power layer has been valid for 15 frames. This ensures that we won't get flashes of invalid content. BUG= 616364 Review-Url: https://codereview.chromium.org/2047103003 Cr-Commit-Position: refs/heads/master@{#399135} [modify] https://crrev.com/15c873daec19bf34e8b3d4925c9668faaba5e634/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/15c873daec19bf34e8b3d4925c9668faaba5e634/chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.h [modify] https://crrev.com/15c873daec19bf34e8b3d4925c9668faaba5e634/chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.mm [add] https://crrev.com/15c873daec19bf34e8b3d4925c9668faaba5e634/chrome/browser/ui/cocoa/fullscreen_low_power_coordinator_unittest.mm [modify] https://crrev.com/15c873daec19bf34e8b3d4925c9668faaba5e634/chrome/chrome_tests_unit.gypi
,
Jun 15 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tkonch...@chromium.org
, Jun 1 2016