chromeos-3.18: mediatek thermal driver build errors |
||||
Issue descriptionThe following build errors are seen with 0day test builds of chromeos-3.18. drivers/thermal/mtk_thermal.c: In function 'mtk_svs_hw_init': drivers/thermal/mtk_thermal.c:1107:3: error: implicit declaration of function 'cpufreq_get_policy' drivers/thermal/mtk_thermal.c:1136:3: error: implicit declaration of function 'cpufreq_update_policy' drivers/thermal/mtk_thermal.c: At top level: >> drivers/thermal/mtk_thermal.c:1485:1: error: redefinition of '__inittest' drivers/thermal/mtk_thermal.c:1281:1: note: previous definition of '__inittest' was here >> drivers/thermal/mtk_thermal.c:1485:1: error: redefinition of 'init_module' drivers/thermal/mtk_thermal.c:1281:1: note: previous definition of 'init_module' was here
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/fe79d8b413ba9ce750d139ec280b141655faee9f commit fe79d8b413ba9ce750d139ec280b141655faee9f Author: Eduardo Valentin <edubezval@gmail.com> Date: Tue Mar 08 21:32:48 2016 UPSTREAM: thermal: mtk: allow compile testing on UM Following the fix on thermal Kconfig, this patch adds dependency on HAS_IOMEM so driver properly compile test on UM arch. BUG= chromium:616355 TEST=Try to build for UM target Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: Zhang Rui <rui.zhang@intel.com> Cc: Matthias Brugger <matthias.bgg@gmail.com> Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Eduardo Valentin <edubezval@gmail.com> (cherry picked from commit 74e5053cd71bdfe9b390000edb5a63dcf1607305) Signed-off-by: Guenter Roeck <groeck@chromium.org> Change-Id: Ifd44bd27925e02f9a04d4078a56d9dcb82601b08 Reviewed-on: https://chromium-review.googlesource.com/348458 Commit-Ready: Guenter Roeck <groeck@chromium.org> Tested-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/fe79d8b413ba9ce750d139ec280b141655faee9f/drivers/thermal/Kconfig
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/19174f248337f9a7dada6a71011526c3bcb9045a commit 19174f248337f9a7dada6a71011526c3bcb9045a Author: Guenter Roeck <groeck@chromium.org> Date: Wed Jun 01 05:03:54 2016 CHROMIUM: thermal: mtk driver depends on CPU_FREQ and must be built into kernel The folowing build errors are seen on test builds trying to build the mediatek thermal driver as module and with CPU_FREQ not enabled. drivers/thermal/mtk_thermal.c: In function 'mtk_svs_hw_init': drivers/thermal/mtk_thermal.c:1107:3: error: implicit declaration of function 'cpufreq_get_policy' drivers/thermal/mtk_thermal.c:1136:3: error: implicit declaration of function 'cpufreq_update_policy' drivers/thermal/mtk_thermal.c: At top level: drivers/thermal/mtk_thermal.c:1485:1: error: redefinition of '__inittest' drivers/thermal/mtk_thermal.c:1281:1: note: previous definition of '__inittest' was here drivers/thermal/mtk_thermal.c:1485:1: error: redefinition of 'init_module' drivers/thermal/mtk_thermal.c:1281:1: note: previous definition of 'init_module' was here Commit 5be71f4c13d3 ("BACKPORT: FROMLIST: PM / AVS: thermal: MT8173: Introduce support for SVS engine") introduces calls into the CPU frequency code, thus adding a dependency of the Mediatek thermal driver on CPU_FREQ. It also adds a late_initcall(), which in modular builds is mapped to module_init(). This conflicts with the already existing module initialization. BUG= chromium:616355 TEST=Try to build as module; try to build with CPU_FREQ disabled Fixes: 5be71f4c13d3 ("BACKPORT: FROMLIST: PM / AVS: thermal: MT8173: Introduce support for SVS engine") Change-Id: I7dd703e38c68306eb10b19ffbacb59885134acf2 Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/348651 Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> [modify] https://crrev.com/19174f248337f9a7dada6a71011526c3bcb9045a/drivers/thermal/Kconfig
,
Jun 3 2016
,
Jun 17 2016
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/2ed8bc7e059aff305322c6844672c5bfcdf5ca75 commit 2ed8bc7e059aff305322c6844672c5bfcdf5ca75 Author: Eduardo Valentin <edubezval@gmail.com> Date: Tue Mar 08 21:32:48 2016 UPSTREAM: thermal: mtk: allow compile testing on UM Following the fix on thermal Kconfig, this patch adds dependency on HAS_IOMEM so driver properly compile test on UM arch. Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: Zhang Rui <rui.zhang@intel.com> Cc: Matthias Brugger <matthias.bgg@gmail.com> Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Eduardo Valentin <edubezval@gmail.com> (cherry picked from commit 74e5053cd71bdfe9b390000edb5a63dcf1607305) Signed-off-by: Daniel Kurtz <djkurtz@chromium.org> BUG=chrome-os-partner:60805 TEST=build chromeos-4.4 for elm and boot TEST=build chromeos-4.4 for kevin and boot BUG= chromium:616355 TEST=Try to build for UM target Reviewed-on: https://chromium-review.googlesource.com/348458 Commit-Ready: Guenter Roeck <groeck@chromium.org> Tested-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> Change-Id: Idff35135545dc8156b15a48472e68fcafba1ba54 Reviewed-on: https://chromium-review.googlesource.com/423845 Commit-Ready: Daniel Kurtz <djkurtz@chromium.org> Tested-by: Daniel Kurtz <djkurtz@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> [modify] https://crrev.com/2ed8bc7e059aff305322c6844672c5bfcdf5ca75/drivers/thermal/Kconfig
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/770efcb6b39f593ef5bdca364b5269fe38b5f289 commit 770efcb6b39f593ef5bdca364b5269fe38b5f289 Author: Johannes Berg <johannes.berg@intel.com> Date: Thu Apr 14 13:15:20 2016 UPSTREAM: thermal: fix Mediatek thermal controller build At least with CONFIG_COMPILE_TEST, there's no reason to assume that CONFIG_RESET_CONTROLLER is set, but the code for this controller requires it since it calls device_reset(). Make CONFIG_MTK_THERMAL properly depend on CONFIG_RESET_CONTROLLER. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Eduardo Valentin <edubezval@gmail.com> (cherry picked from commit a6f4850dbca66e46a73b8774e85aaf9fc0caf265) Signed-off-by: Daniel Kurtz <djkurtz@chromium.org> BUG= chromium:616355 TEST=Try to configure with CONFIG_RESET_CONTROLLER=n Reviewed-on: https://chromium-review.googlesource.com/348650 Commit-Ready: Guenter Roeck <groeck@chromium.org> Tested-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> Change-Id: I92c35e60b0cfd30f7764ce4829345af3e8c36915 Reviewed-on: https://chromium-review.googlesource.com/423848 Commit-Ready: Daniel Kurtz <djkurtz@chromium.org> Tested-by: Daniel Kurtz <djkurtz@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> [modify] https://crrev.com/770efcb6b39f593ef5bdca364b5269fe38b5f289/drivers/thermal/Kconfig |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jun 3 2016