Shorthand serialization should check for variable references in longhands |
||
Issue descriptionIf any subproperty of a shorthand has been set to a variable reference, the shorthand should serialize as empty string. StylePropertySerializer::commonShorthandChecks needs to handle this case. > $0.style.cssText = 'margin: 1px 2px; margin-top: var(--x);' "margin: 1px 2px; margin-top: var(--x);" > $0.style.margin "var(--x) 2px 1px" (should be "") > $0.style.cssText "margin: var(--x) 2px 1px;" (should have all longhands separately) Firefox handles the above case correctly.
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d82848bccbc6dbd246cbc329401774f97f5fa1c commit 2d82848bccbc6dbd246cbc329401774f97f5fa1c Author: ramya.v <ramya.v@samsung.com> Date: Wed Jun 22 13:16:32 2016 Shorthand serialization should check for var in longhands. If any subproperty of a shorthand has been set to a variable reference, shorthand is serialized as empty string. BUG= 616341 Review-Url: https://codereview.chromium.org/2083703005 Cr-Commit-Position: refs/heads/master@{#401267} [modify] https://crrev.com/2d82848bccbc6dbd246cbc329401774f97f5fa1c/third_party/WebKit/LayoutTests/fast/css/cssText-shorthand.html [modify] https://crrev.com/2d82848bccbc6dbd246cbc329401774f97f5fa1c/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
,
Jun 23 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by ramy...@samsung.com
, Jun 22 2016Status: Assigned (was: Available)