Issue 616313 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	chanli@chromium.org
Closed:	Jun 2016
Cc:	lijeffrey@chromium.org st...@chromium.org █ robert...@chromium.org chanli@chromium.org liaoyuke@chromium.org
Components:	Tools>Test>FindIt
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	----
Findit

[Findit] try job and heuristic mismatch

Project Member Reported by chanli@chromium.org, Jun 1 2016

Issue description

Url to the build Failure:
https://build.chromium.org/p/chromium.linux/builders/Linux Tests (dbg)(1)(32)/builds/29330

What is the bug or feature:
1. Findit includes 'skipped' tests in reliable failures
2. the try jobs and tests are mismatched
3. Findit displays a flaky test but it's not in the list of failed tests

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/5267507e65d388cc288f57a44f9fe042112a90d7

commit 5267507e65d388cc288f57a44f9fe042112a90d7
Author: chanli <chanli@chromium.org>
Date: Fri Jun 17 20:41:21 2016

[Findit] don't included skipped or unknown tests in swarming tasks into failed tests.

When record failed tests in detect_first_failure pipeline and check flakiness in swarming rerun, don't include skipped or unknown tests as failed.

BUG= 616313 

Review-Url: https://codereview.chromium.org/2027333002

[modify] https://crrev.com/5267507e65d388cc288f57a44f9fe042112a90d7/appengine/findit/handlers/handlers_util.py
[modify] https://crrev.com/5267507e65d388cc288f57a44f9fe042112a90d7/appengine/findit/handlers/test/handlers_util_test.py
[modify] https://crrev.com/5267507e65d388cc288f57a44f9fe042112a90d7/appengine/findit/model/test/wf_swarming_task_test.py
[modify] https://crrev.com/5267507e65d388cc288f57a44f9fe042112a90d7/appengine/findit/model/wf_swarming_task.py
[modify] https://crrev.com/5267507e65d388cc288f57a44f9fe042112a90d7/appengine/findit/waterfall/detect_first_failure_pipeline.py
[modify] https://crrev.com/5267507e65d388cc288f57a44f9fe042112a90d7/appengine/findit/waterfall/swarming_tasks_to_try_job_pipeline.py
[modify] https://crrev.com/5267507e65d388cc288f57a44f9fe042112a90d7/appengine/findit/waterfall/test/swarming_tasks_to_try_job_pipeline_test.py

Comment 2 by chanli@chromium.org, Jun 27 2016

Status: Verified (was: Assigned)

►

Issue 616313 link

Issue metadata

[Findit] try job and heuristic mismatch

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 17 2016

Comment 1 Deleted

Comment 2 by chanli@chromium.org, Jun 27 2016

Comment 2 Deleted

Sign in to add a comment