New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616312 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

restrict blocking of doc.written scripts to resources loaded over http or https

Project Member Reported by bmcquade@chromium.org, Jun 1 2016

Issue description

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we restrict
to http and https scripts.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96268153217282dfd921387cb033f83e7f583d60

commit 96268153217282dfd921387cb033f83e7f583d60
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Jun 02 15:39:50 2016

Only block http or https doc.written scripts.

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we restrict
to http and https scripts.

This change doesn't include tests, since there isn't actually any behavior change
here that I can detect. Even though shouldDisallow will return true for data: URLs,
the script will continue to execute. However, it's useful for us to return false
in the blocking method, since that allows us to avoid having the
didObserveLoadingBehavior method get called, which could cause our metrics to be
incorrect.

BUG= 616312 

Review-Url: https://codereview.chromium.org/2026983002
Cr-Commit-Position: refs/heads/master@{#397419}

[modify] https://crrev.com/96268153217282dfd921387cb033f83e7f583d60/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Status: Fixed (was: Untriaged)

Sign in to add a comment