@abodenha, do you know why the Docs app icon doesn't stay focused over Drive? Is this something the Docs team decided to do? It's a common user complaint and doesn't fit well with the usual v1 app model.

No clue.  Does seem odd.

warx@ can you investigate?

So I assume the requirement is we should move the focus to docs/sheets/slides icon, instead of chrome/drive, right?

cc some people who might know better on extension, do you have a clue on why https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc?sq=package:chromium&l=561 returns kDriveHostedAppId instead of kGoogleDocAppId for Docs App? Thanks.

My understanding is that drive, docs etc. all share the same origin on the web. Only one hosted app can claim a particular origin, so drive is an actual hosted app and the others are weird v2 legacy packaged apps which just redirect to the correct URL. As this URL is owned by the drive hosted app, the launcher would think that it is kDriveHostedAppId.

This is quite old. Is it still relevant? Alex, can you take a look?

This is probably still a bug. Moving these off the old legacy chrome apps tech to installed web apps should fix the problem. We might be able to do this in M72-ish.

I think Vlad has looked into this class of issues recently?

The current ToT behavior is slightly different than in the original description. Upon launching Docs from a pinned shelf icon, the activity indicator flashes briefly under the Docs icon, but then goes to Chrome. Drive icon does not get the activity indicator.

I think this improvement is the result of  Issue 883130  being fixed recently.
However, the main problem described in the bug's title still persists. Looking into it.

The broken behavior looks similar to Issue 908639. However, the fix for that issue (http://crrev.com/c/1392268) does not help here, since from_bookmark() returns false for Docs/Sheets/Slides. And even if it was true, extensions::AppLaunchInfo::GetLaunchWebURL is empty.
So the tab URL ends up being matched against an empty web_extent.

Dominick, can you help me figure out the solution here?

In this case, Docs/Sheets/Slides are probably platform apps or legacy packaged apps, not bookmark apps. They launch a chrome://extension URL which redirects to Docs, which is why the fix from http://crrev.com/c/1392268 doesn't help. There is no launch web URL because the redirection is done within the app.

I'm not too familiar with the details of how these apps are built - it may be necessary to hardcode in the right behaviour mapping the extension ID -> URL for them.

Oh these. Sorry it didn't click what sort of apps these are ... they are indeed v1 apps and are horrible hacks. They basically have an internal packaged page, but it just navigates to a different URL. This was done because it is not allowed to have multiple hosted apps with overlapping extents.

The right fix here is to replace these with actually supported apps. We could replace them now with installed web shortcuts, we just need the sites to add web manifests and appropriate icons.

(huh actually that's pretty much what i said in #12)

Ben, is your team willing to own this?

Yep, it's already on our OKRs (although more general). Reassigning to raymes who is a better owner for this.