Stop using CRWWebController outside of web// |
|||||
Issue descriptionCRWWebController is private for web// layer and should not be used enywhere else
,
Dec 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4e617ae3c13cb02ac784df04deb8e44b82de395 commit d4e617ae3c13cb02ac784df04deb8e44b82de395 Author: eugenebut <eugenebut@chromium.org> Date: Wed Dec 28 16:45:25 2016 [ios] Do not use CRWWebController in MainController. New code uses web::NavigationManager which is the same program flow. Old code would tolerate nil CRWWebController, while the new code will crash (which should not happen in practice). BUG= 616288 Review-Url: https://codereview.chromium.org/2600963002 Cr-Commit-Position: refs/heads/master@{#440854} [modify] https://crrev.com/d4e617ae3c13cb02ac784df04deb8e44b82de395/ios/chrome/app/DEPS [modify] https://crrev.com/d4e617ae3c13cb02ac784df04deb8e44b82de395/ios/chrome/app/main_controller.mm
,
Apr 19 2017
,
Apr 19 2017
,
Apr 20 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2018
We already have specific bugs for every use of private ios/web API. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by eugene...@chromium.org
, Jun 1 2016