New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616277 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 681902



Sign in to add a comment

deploy_production_local.py should remove .pyc files after syncing code.

Project Member Reported by dgarr...@chromium.org, May 31 2016

Issue description

We should remove stale .pyc files after syncing code. They can cause removed libraries to still appear to be present, and can be corrupt in a variety of ways.

I believe it the correct fix is to do this right after the "repo_sync()" method in deploy_production_local.py.

Something similar to:
  find -iname \*.pyc | xargs --no-run-if-empty rm
 
Labels: -current-issue
Owner: shuqianz@chromium.org
Owner: pprabhu@chromium.org
Status: Assigned (was: Untriaged)
I'm working on a few cosmetic test_push changes this week.
Blocking: 681902
Labels: -Pri-2 Hotlist-Fixit Pri-1
Owner: ----
Status: Available (was: Assigned)
I think this is a good candidate for the coming Fixit. This has broken test_push multiple times, and we have had to rollback changes because we weren't sure if the same issue will occur in prod.
Owner: shuqianz@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/269242ad597f79932d08bc27699799992663fd10

commit 269242ad597f79932d08bc27699799992663fd10
Author: Shuqian Zhao <shuqianz@chromium.org>
Date: Mon Jan 30 23:35:33 2017

[autotest] remove .pyc files during server deployment

Remove stale .pyc files after syncing code.

BUG= chromium:616277 
TEST=Test locally

Change-Id: Ic3a61ad72ab31f345c4dfc11357ad6e48b9ac443
Reviewed-on: https://chromium-review.googlesource.com/434859
Tested-by: Shuqian Zhao <shuqianz@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>

[modify] https://crrev.com/269242ad597f79932d08bc27699799992663fd10/site_utils/deploy_server_local.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ec26bd73d1a30576b501728797e3949c4f3be249

commit ec26bd73d1a30576b501728797e3949c4f3be249
Author: Shuqian Zhao <shuqianz@chromium.org>
Date: Tue Jan 31 18:17:25 2017

[autotest] remove .pyc files during server deployment

Remove stale .pyc files after syncing code.

BUG= chromium:616277 
TEST=Test locally and unittest

Change-Id: Ie7cc55d71b1ccc84efe7704d60db476e284cf662
Reviewed-on: https://chromium-review.googlesource.com/435041
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>
Tested-by: Shuqian Zhao <shuqianz@chromium.org>

[modify] https://crrev.com/ec26bd73d1a30576b501728797e3949c4f3be249/site_utils/deploy_server_local_unittest.py
[modify] https://crrev.com/ec26bd73d1a30576b501728797e3949c4f3be249/site_utils/deploy_server_local.py

Labels: cros-infra-fixedit-q117
Status: Fixed (was: Available)

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment