ios_internal/ must not use ios/web, only ios/web/public
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/3c796864f9d02fcc9aec1684fc0bd9b61869ef06 commit 3c796864f9d02fcc9aec1684fc0bd9b61869ef06 Author: eugenebut <eugenebut@google.com> Date: Thu Jun 02 05:53:53 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2924a66000830f14055b5c087c0861a532c6a7fb commit 2924a66000830f14055b5c087c0861a532c6a7fb Author: eugenebut <eugenebut@chromium.org> Date: Fri Jun 03 16:25:08 2016 [ios] Added WebTestWithWebController::web_state. Subclasses of WebTestWithWebController should use WebState where possible. BUG=616244 Review-Url: https://codereview.chromium.org/2032903002 Cr-Commit-Position: refs/heads/master@{#397723} [modify] https://crrev.com/2924a66000830f14055b5c087c0861a532c6a7fb/ios/web/test/web_test.h [modify] https://crrev.com/2924a66000830f14055b5c087c0861a532c6a7fb/ios/web/test/web_test.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/32d389bb6e315b381e52154a6ed139c391afc717 commit 32d389bb6e315b381e52154a6ed139c391afc717 Author: eugenebut <eugenebut@google.com> Date: Mon Jun 06 21:11:57 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0f8ef15b23f8514a415928737b01770803a5218d commit 0f8ef15b23f8514a415928737b01770803a5218d Author: eugenebut <eugenebut@google.com> Date: Thu Jun 09 20:05:03 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ca68bf09e8f52d618c7092a55745193d571f0526 commit ca68bf09e8f52d618c7092a55745193d571f0526 Author: eugenebut <eugenebut@google.com> Date: Fri Jun 10 00:20:50 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/8d484ac4eb2d934a7f92180353316c4669b84000 commit 8d484ac4eb2d934a7f92180353316c4669b84000 Author: eugenebut <eugenebut@google.com> Date: Fri Jun 10 00:21:15 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/092f834e531307d4836b0cb5293ddd94a9565386 commit 092f834e531307d4836b0cb5293ddd94a9565386 Author: eugenebut <eugenebut@google.com> Date: Fri Jun 10 07:35:57 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ef310e5333ee523920d6a7988d374842d1c9d68b commit ef310e5333ee523920d6a7988d374842d1c9d68b Author: eugenebut <eugenebut@google.com> Date: Fri Jun 10 14:15:02 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/592a7be060916424269e55c96799b9ebedc3aa71 commit 592a7be060916424269e55c96799b9ebedc3aa71 Author: gambard <gambard@google.com> Date: Fri Jun 10 14:57:16 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/58dbcfbacb4bf35ec1746bf7d6ed507433a240f7 commit 58dbcfbacb4bf35ec1746bf7d6ed507433a240f7 Author: eugenebut <eugenebut@google.com> Date: Fri Jun 10 15:33:56 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0cda8182ac979592051f0ed5c458fa107b9344f7 commit 0cda8182ac979592051f0ed5c458fa107b9344f7 Author: eugenebut <eugenebut@google.com> Date: Mon Jun 13 15:45:13 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/5acecbd23d74c22c66d3d09a3b0c44252bbd133c commit 5acecbd23d74c22c66d3d09a3b0c44252bbd133c Author: eugenebut <eugenebut@google.com> Date: Tue Jun 14 05:01:36 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/b2b5c833d620a6dfea0dac1cc95cde6ec49e5973 commit b2b5c833d620a6dfea0dac1cc95cde6ec49e5973 Author: eugenebut <eugenebut@google.com> Date: Tue Jun 14 05:10:56 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ac64d7d68d62b5a3c68840b16d9ea92b957fe707 commit ac64d7d68d62b5a3c68840b16d9ea92b957fe707 Author: eugenebut <eugenebut@google.com> Date: Tue Jun 14 05:12:55 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f3d39f09882b09d6b675c9751777854639a647c6 commit f3d39f09882b09d6b675c9751777854639a647c6 Author: eugenebut <eugenebut@google.com> Date: Wed Jun 15 00:28:48 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/46e3b65ae902918aaac2e8bb2bcdc7881ce851d2 commit 46e3b65ae902918aaac2e8bb2bcdc7881ce851d2 Author: eugenebut <eugenebut@google.com> Date: Wed Jun 15 00:28:58 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/2d9405cc6373f2f6221555903bded097d22388a8 commit 2d9405cc6373f2f6221555903bded097d22388a8 Author: eugenebut <eugenebut@google.com> Date: Wed Jun 15 00:30:55 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/2912fc975e8b613e2de402d5a5fad4a5a2ce92b6 commit 2912fc975e8b613e2de402d5a5fad4a5a2ce92b6 Author: eugenebut <eugenebut@google.com> Date: Wed Jun 15 00:31:00 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/dbd35c592dcaf2aa31dae9012cb6ad9c9f54d84b commit dbd35c592dcaf2aa31dae9012cb6ad9c9f54d84b Author: eugenebut <eugenebut@google.com> Date: Wed Jun 15 18:19:20 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f862daca4d5f12ff8cecea53970f1391b3ee52d1 commit f862daca4d5f12ff8cecea53970f1391b3ee52d1 Author: eugenebut <eugenebut@google.com> Date: Thu Jun 16 16:32:08 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/aadc80df7cd4c4c8a74821d5ac3ecf589f532ef9 commit aadc80df7cd4c4c8a74821d5ac3ecf589f532ef9 Author: eugenebut <eugenebut@google.com> Date: Fri Jun 17 02:41:27 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d5a21798dd897232043608a3ad08c88c3e2fe729 commit d5a21798dd897232043608a3ad08c88c3e2fe729 Author: eugenebut <eugenebut@google.com> Date: Fri Jun 17 07:57:10 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/a8cdcf8af2d3024238a9e09242317022bdaf0abd commit a8cdcf8af2d3024238a9e09242317022bdaf0abd Author: eugenebut <eugenebut@google.com> Date: Fri Jun 17 18:47:10 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/49ac136d75d619662a2d8743e6270ae6d4d69733 commit 49ac136d75d619662a2d8743e6270ae6d4d69733 Author: eugenebut <eugenebut@google.com> Date: Mon Jun 20 08:14:34 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/05d2128f7ba0e732ad68d89d94019dd640de1131 commit 05d2128f7ba0e732ad68d89d94019dd640de1131 Author: eugenebut <eugenebut@google.com> Date: Tue Jun 21 04:38:06 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/8265cc87bf69b17b3e098f33873f6d9a3664369d commit 8265cc87bf69b17b3e098f33873f6d9a3664369d Author: eugenebut <eugenebut@google.com> Date: Tue Jun 21 19:32:29 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d007c9ceac3d4c5a77b8c2da80d9ea045112f7dc commit d007c9ceac3d4c5a77b8c2da80d9ea045112f7dc Author: eugenebut <eugenebut@google.com> Date: Wed Jun 22 19:47:45 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/c13fe098921aa8f0d59fd05814023826e115b016 commit c13fe098921aa8f0d59fd05814023826e115b016 Author: eugenebut <eugenebut@google.com> Date: Thu Jun 23 01:09:38 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e773debc33b66964918c26aaea68ad6132599cff commit e773debc33b66964918c26aaea68ad6132599cff Author: eugenebut <eugenebut@google.com> Date: Thu Jun 23 15:21:15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26b402b376aabbb5873a9c129adf74b60d033fda commit 26b402b376aabbb5873a9c129adf74b60d033fda Author: eugenebut <eugenebut@chromium.org> Date: Fri Jun 24 07:57:40 2016 [ios] Moved web_test_suite.h to ios/web/public. This header is used by chrome_test_suite. BUG=616244 Review-Url: https://codereview.chromium.org/2087233006 Cr-Commit-Position: refs/heads/master@{#401833} [modify] https://crrev.com/26b402b376aabbb5873a9c129adf74b60d033fda/ios/web/BUILD.gn [modify] https://crrev.com/26b402b376aabbb5873a9c129adf74b60d033fda/ios/web/ios_web.gyp [add] https://crrev.com/26b402b376aabbb5873a9c129adf74b60d033fda/ios/web/public/test/web_test_suite.h [modify] https://crrev.com/26b402b376aabbb5873a9c129adf74b60d033fda/ios/web/test/run_all_unittests.cc [modify] https://crrev.com/26b402b376aabbb5873a9c129adf74b60d033fda/ios/web/test/web_test_suite.h [modify] https://crrev.com/26b402b376aabbb5873a9c129adf74b60d033fda/ios/web/test/web_test_suite.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/2be56dd4dec1cf8db29993a2c4628c485ccb9cc1 commit 2be56dd4dec1cf8db29993a2c4628c485ccb9cc1 Author: eugenebut <eugenebut@google.com> Date: Mon Jun 27 18:55:49 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d48c6d9930a7c43a5d94106fa7853df2a5357b67 commit d48c6d9930a7c43a5d94106fa7853df2a5357b67 Author: eugenebut <eugenebut@chromium.org> Date: Tue Jun 28 08:27:42 2016 Removed private web_test_suite.h header as unused. BUG=616244 Review-Url: https://codereview.chromium.org/2098583003 Cr-Commit-Position: refs/heads/master@{#402424} [modify] https://crrev.com/d48c6d9930a7c43a5d94106fa7853df2a5357b67/ios/web/BUILD.gn [modify] https://crrev.com/d48c6d9930a7c43a5d94106fa7853df2a5357b67/ios/web/ios_web.gyp [delete] https://crrev.com/9afc91518d0b52587817d0dc743f42453b0564f5/ios/web/test/web_test_suite.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14116a28e90449a80e4ea597aad3c3b6f0193319 commit 14116a28e90449a80e4ea597aad3c3b6f0193319 Author: eugenebut <eugenebut@chromium.org> Date: Tue Jun 28 20:27:20 2016 [ios] Added DialogsSuppression public API to WebState. BUG=616244, 546231 Review-Url: https://codereview.chromium.org/2094633004 Cr-Commit-Position: refs/heads/master@{#402529} [modify] https://crrev.com/14116a28e90449a80e4ea597aad3c3b6f0193319/ios/web/public/test/test_web_state.h [modify] https://crrev.com/14116a28e90449a80e4ea597aad3c3b6f0193319/ios/web/public/test/test_web_state.mm [modify] https://crrev.com/14116a28e90449a80e4ea597aad3c3b6f0193319/ios/web/public/web_state/web_state.h [modify] https://crrev.com/14116a28e90449a80e4ea597aad3c3b6f0193319/ios/web/web_state/web_state_impl.h [modify] https://crrev.com/14116a28e90449a80e4ea597aad3c3b6f0193319/ios/web/web_state/web_state_impl.mm [modify] https://crrev.com/14116a28e90449a80e4ea597aad3c3b6f0193319/ios/web/web_state/web_state_impl_unittest.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/14cd12c4aec0bbc13ae060f6a86cc7a33ab91664 commit 14cd12c4aec0bbc13ae060f6a86cc7a33ab91664 Author: eugenebut <eugenebut@google.com> Date: Wed Jun 29 15:56:40 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c64e082dd44826a935ec54019cfd2ea794808233 commit c64e082dd44826a935ec54019cfd2ea794808233 Author: eugenebut <eugenebut@chromium.org> Date: Tue Dec 13 23:19:25 2016 [ios] Removed unused CRWWebControllerObserver methods. Removed |handleCommand:webController:userIsInteracting:originURL:| and |commandPrefix| methods. BUG=616244 Review-Url: https://codereview.chromium.org/2567303003 Cr-Commit-Position: refs/heads/master@{#438331} [modify] https://crrev.com/c64e082dd44826a935ec54019cfd2ea794808233/ios/web/BUILD.gn [modify] https://crrev.com/c64e082dd44826a935ec54019cfd2ea794808233/ios/web/public/web_state/crw_web_controller_observer.h [modify] https://crrev.com/c64e082dd44826a935ec54019cfd2ea794808233/ios/web/test/crw_fake_web_controller_observer.h [modify] https://crrev.com/c64e082dd44826a935ec54019cfd2ea794808233/ios/web/test/crw_fake_web_controller_observer.mm [delete] https://crrev.com/2f0ed9de3071a21b3bcf55f3c74adb09bd0c7036/ios/web/test/crw_fake_web_controller_observer_unittest.mm [modify] https://crrev.com/c64e082dd44826a935ec54019cfd2ea794808233/ios/web/web_state/ui/crw_web_controller_observer_unittest.mm [modify] https://crrev.com/c64e082dd44826a935ec54019cfd2ea794808233/ios/web/web_state/ui/crw_web_controller_unittest.mm [modify] https://crrev.com/c64e082dd44826a935ec54019cfd2ea794808233/ios/web/web_state/web_controller_observer_bridge.h [modify] https://crrev.com/c64e082dd44826a935ec54019cfd2ea794808233/ios/web/web_state/web_controller_observer_bridge.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f9dd59471dcf2b1e6968b861168897d4a0d4695 commit 0f9dd59471dcf2b1e6968b861168897d4a0d4695 Author: eugenebut <eugenebut@chromium.org> Date: Fri Dec 16 22:09:02 2016 [ios] Added deprecation comments and TODOs for ios/web classes/protocols The following classes/protocols are deprecated: - CRWSessionController - CRWSessionEntry - CRWWebDelegate - CRWWebUserInterfaceDelegate - CRWWebControllerObserver BUG=616244 Review-Url: https://codereview.chromium.org/2582843002 Cr-Commit-Position: refs/heads/master@{#439208} [modify] https://crrev.com/0f9dd59471dcf2b1e6968b861168897d4a0d4695/ios/web/navigation/crw_session_controller.h [modify] https://crrev.com/0f9dd59471dcf2b1e6968b861168897d4a0d4695/ios/web/navigation/crw_session_entry.h [modify] https://crrev.com/0f9dd59471dcf2b1e6968b861168897d4a0d4695/ios/web/public/web_state/crw_web_controller_observer.h [modify] https://crrev.com/0f9dd59471dcf2b1e6968b861168897d4a0d4695/ios/web/public/web_state/crw_web_user_interface_delegate.h [modify] https://crrev.com/0f9dd59471dcf2b1e6968b861168897d4a0d4695/ios/web/public/web_state/ui/crw_web_delegate.h
Issue 583685 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da4f211de7a88b443033d238891d4b9bb92b10df commit da4f211de7a88b443033d238891d4b9bb92b10df Author: eugenebut <eugenebut@chromium.org> Date: Tue Jul 11 16:21:36 2017 Cleaned up webWillAddPendingURL:transition: callback. Disable fullscreen inside webState:didStartNavigation: instead of webWillAddPendingURL:transition: BUG=616244 Review-Url: https://codereview.chromium.org/2969273002 Cr-Commit-Position: refs/heads/master@{#485646} [modify] https://crrev.com/da4f211de7a88b443033d238891d4b9bb92b10df/ios/chrome/browser/tabs/tab.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10 commit 61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10 Author: Eugene But <eugenebut@chromium.org> Date: Thu Aug 03 15:15:47 2017 Added WasShown/WasHidden WebState and WebStateObserver API. WebState's WasShown/WasHidden is called from Tab, so WebStateObserver callbacks are actually work. WebStateObserver's WasShown/WasHidden callbacks will allow to move code from Tab to TabHelpers. Bug: 616244 Change-Id: I2d8f3eb0f5854dd7204b9aec6db2aac593309638 Reviewed-on: https://chromium-review.googlesource.com/596783 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#491739} [modify] https://crrev.com/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10/ios/web/public/test/fakes/test_web_state.h [modify] https://crrev.com/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10/ios/web/public/test/fakes/test_web_state.mm [modify] https://crrev.com/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10/ios/web/public/test/fakes/test_web_state_observer.h [modify] https://crrev.com/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10/ios/web/public/test/fakes/test_web_state_observer.mm [modify] https://crrev.com/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10/ios/web/public/test/fakes/test_web_state_observer_util.h [modify] https://crrev.com/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10/ios/web/public/web_state/web_state.h [modify] https://crrev.com/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10/ios/web/public/web_state/web_state_observer.h [modify] https://crrev.com/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10/ios/web/web_state/web_state_impl.h [modify] https://crrev.com/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10/ios/web/web_state/web_state_impl.mm [modify] https://crrev.com/61ec9b3ef20c9e7f2132a033ae6f2bfad2043e10/ios/web/web_state/web_state_impl_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ffb61b2499a9f65399042eddbf25f4e4926f847 commit 0ffb61b2499a9f65399042eddbf25f4e4926f847 Author: Eugene But <eugenebut@google.com> Date: Fri Aug 04 19:30:35 2017 PagePlaceholderTabHelper. ios/web allows displaying Placeholder Overlay view using these APIs: - CRWWebController.usePlaceholderOverlay - CRWWebController.canUseViewForGeneratingOverlayPlaceholderView - [CRWWebController setOverlayPreviewMode:] - [CRWWebDelegate webController:retrievePlaceholderOverlayImage:] There are 2 problems with this approach: 1.) Placeholder Overlay is pure UI feature which allows to display the the grey/colored snapshot of the web page during the page load (e.g. on Tab restoration after cold launch). 2.) ios/web already provides enough callbacks to support Placeholder Overlay by embedder and there is no need for another 4 methods just to support one minor feature. This CL creates PagePlaceholderTabHelper which will replace all existing Placeholder Overlay APIs and can be used in the new architecture. Bug: 616244 Change-Id: I307460b8ac06e2f87f3c966c7fbb4c96591ce266 Reviewed-on: https://chromium-review.googlesource.com/585221 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#492100} [modify] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/ios/chrome/browser/tabs/tab.h [modify] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/ios/chrome/browser/tabs/tab_helper_util.mm [modify] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/ios/chrome/browser/web/BUILD.gn [add] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/ios/chrome/browser/web/page_placeholder_tab_helper.h [add] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/ios/chrome/browser/web/page_placeholder_tab_helper.mm [add] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/ios/chrome/browser/web/page_placeholder_tab_helper_delegate.h [add] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/ios/chrome/browser/web/page_placeholder_tab_helper_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44835133e5dae4bbc458a7f75a0caa453791342a commit 44835133e5dae4bbc458a7f75a0caa453791342a Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Dec 27 12:27:10 2017 Use PagePlaceholderTabHelper to present overlay. USe PagePlaceholderTabHelper to present the grey image overlay instead of the CRWWebController implementation. Bug: 616244, 620939 Change-Id: I60589825448892ff25edd37b6cdf681b3c253892 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/836989 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#526219} [modify] https://crrev.com/44835133e5dae4bbc458a7f75a0caa453791342a/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/44835133e5dae4bbc458a7f75a0caa453791342a/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/44835133e5dae4bbc458a7f75a0caa453791342a/ios/chrome/browser/ui/side_swipe/DEPS [modify] https://crrev.com/44835133e5dae4bbc458a7f75a0caa453791342a/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm [modify] https://crrev.com/44835133e5dae4bbc458a7f75a0caa453791342a/ios/chrome/browser/ui/tab_switcher/BUILD.gn [modify] https://crrev.com/44835133e5dae4bbc458a7f75a0caa453791342a/ios/chrome/browser/ui/tab_switcher/tab_switcher_cache.mm [modify] https://crrev.com/44835133e5dae4bbc458a7f75a0caa453791342a/ios/chrome/browser/web/page_placeholder_tab_helper.h [modify] https://crrev.com/44835133e5dae4bbc458a7f75a0caa453791342a/ios/chrome/browser/web/page_placeholder_tab_helper.mm [modify] https://crrev.com/44835133e5dae4bbc458a7f75a0caa453791342a/ios/chrome/browser/web/page_placeholder_tab_helper_unittest.mm [modify] https://crrev.com/44835133e5dae4bbc458a7f75a0caa453791342a/ios/web/public/web_state/ui/crw_web_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5964f7a0213d68a9ebb91fcbc80ce925fe785e6a commit 5964f7a0213d68a9ebb91fcbc80ce925fe785e6a Author: Eugene But <eugenebut@google.com> Date: Tue Jun 05 15:09:54 2018 Removed extra public_deps from //ios/web:web target. Bug: 616244 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3ca25359d999e8d44ec2c8e7994a5e0240c6d19a Reviewed-on: https://chromium-review.googlesource.com/1073681 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#564503} [modify] https://crrev.com/5964f7a0213d68a9ebb91fcbc80ce925fe785e6a/ios/web/BUILD.gn [modify] https://crrev.com/5964f7a0213d68a9ebb91fcbc80ce925fe785e6a/ios/web/public/test/BUILD.gn
