New issue
Advanced search Search tips

Issue 616227 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocking:
issue 604105



Sign in to add a comment

ItemChooserDialog should adjust size on screen size changes

Project Member Reported by jyasskin@chromium.org, May 31 2016

Issue description

The ItemChooserDialog sets its height once on construction and then doesn't update it if the size of the screen changes: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java&q=setLayoutParams%20file:ItemChooserDialog

This can happen if the screen is rotated or the user changes the size of the multi-window split.
 
Cc: finnur@chromium.org

Comment 2 by finnur@chromium.org, May 31 2016

It's been a while, so I might be recalling this incorrectly, but didn't we pick a size that should work in both landscape and portrait mode?

(multi-window split is another deal).
Components: Blink>Bluetooth Blink>USB
We use 30% of the screen height, which tends to work in both landscape and portrait, but it's odd that closing and re-opening the dialog makes it change size. 30% does break when you go from portrait to a small multi-window split.
Cc: juncai@chromium.org
 Issue 629066  has been merged into this issue.
From 629066, the width is also not updating on rotations, which is surprising because that's explicitly set to MATCH_PARENT in https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java?l=394-401.
Summary: ItemChooserDialog should adjust size on screen size changes (was: ItemChooserDialog should adjust height on screen size changes)

Comment 7 by scheib@chromium.org, Oct 17 2016

Labels: Type-Feature

Comment 8 by ortuno@chromium.org, Mar 29 2017

Blocking: -436280 604105
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment