ItemChooserDialog should adjust size on screen size changes |
||||||
Issue descriptionThe ItemChooserDialog sets its height once on construction and then doesn't update it if the size of the screen changes: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java&q=setLayoutParams%20file:ItemChooserDialog This can happen if the screen is rotated or the user changes the size of the multi-window split.
,
May 31 2016
It's been a while, so I might be recalling this incorrectly, but didn't we pick a size that should work in both landscape and portrait mode? (multi-window split is another deal).
,
May 31 2016
We use 30% of the screen height, which tends to work in both landscape and portrait, but it's odd that closing and re-opening the dialog makes it change size. 30% does break when you go from portrait to a small multi-window split.
,
Jul 20 2016
,
Jul 20 2016
From 629066, the width is also not updating on rotations, which is surprising because that's explicitly set to MATCH_PARENT in https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java?l=394-401.
,
Jul 20 2016
,
Oct 17 2016
,
Apr 12 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jyasskin@chromium.org
, May 31 2016