New issue
Advanced search Search tips

Issue 616223 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
szager@chromium.org
skyos...@chromium.org
e...@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clean layout for layout -> frameViewResize -> needsLayout

Project Member Reported by wangxianzhu@chromium.org, May 31 2016 
FrameView::adjustViewSize() called from FrameView::layout() after FrameView::performLayout() may again setNeedsLayout(). Not handling the needsLayout will violate the FrameView::layout()'s protocol that layout should be clean after it. WebViewImpl::layoutUpdated() handles resize of the local root frame but doesn't handle other frame views.

This might be the main cause of bug 590856 (which can be reproduced with the case in bug 611290). 

This also causes assertion failures of the code executed after adjustViewSize() and before WebViewImpl::layoutUpdated(), e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=611290#c2.

We can force a layout in adjustViewSize() to make layout clean after it. We can also let WebViewImpl::layoutUpdated() handle resize of all FrameViews, but need to adjust the sequence of layoutUpdated() and other code to avoid assertion failures before it.
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 1 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by e...@chromium.org, Jun 5 2017

Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 6 2018

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by e...@chromium.org, Jun 7 2018

Components: Blink>PageLifecycle
Status: Available (was: Untriaged)

Comment 5 by panicker@chromium.org, Sep 12

Components: -Blink>PageLifecycle
►

Sign in to add a comment