bluetooth: Double-tapping a button that opens the requestDevice() chooser crashes Chrome |
||||
Issue descriptionGo to https://googlechrome.github.io/samples/web-bluetooth/gap-characteristics.html and press the "Get Bluetooth Device's GAP Characteristics" button twice before the chooser has a chance to open. Chrome crashes in WebBluetoothServiceImpl::RequestDeviceImpl() at CHECK(!device_chooser_controller_.get());
,
May 31 2016
I've seen it on Android, but the Mac chooser doesn't close on clicks outside it at all, so it'll probably happen there too.
,
May 31 2016
I was not aware that mac had a different set of rules for closing the chooser D: I think the android problem falls under Issue 588127 .
,
May 31 2016
Issue 588127 is a little different: this one's about the second gesture happening before the chooser opens in the first place, so there's nothing to close yet when the second gesture happens.
,
Jun 1 2016
,
Jun 2 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8eba1a9d135b69979dd20c1c8c49f4cfdb3ee6d7 commit 8eba1a9d135b69979dd20c1c8c49f4cfdb3ee6d7 Author: ortuno <ortuno@chromium.org> Date: Wed Jun 15 04:18:52 2016 bluetooth: Handle two consecutives requestDevice calls. WebBluetoothServiceImpl will close any open choosers when calling RequestDevice. BluetoothDeviceChooserController runs its error callback when being destroyed if there are any open chooser. BUG= 616222 Review-Url: https://codereview.chromium.org/2030973002 Cr-Commit-Position: refs/heads/master@{#399836} [modify] https://crrev.com/8eba1a9d135b69979dd20c1c8c49f4cfdb3ee6d7/content/browser/bluetooth/bluetooth_device_chooser_controller.cc [modify] https://crrev.com/8eba1a9d135b69979dd20c1c8c49f4cfdb3ee6d7/content/browser/bluetooth/web_bluetooth_service_impl.cc [add] https://crrev.com/8eba1a9d135b69979dd20c1c8c49f4cfdb3ee6d7/third_party/WebKit/LayoutTests/bluetooth/requestDevice/consecutive-calls.html
,
Jun 15 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ortuno@chromium.org
, May 31 2016