New issue
Advanced search Search tips

Issue 616219 link

Starred by 1 user
Status: Fixed
Owner:
csharrison@chromium.org
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The net predictor should apply HSTS when learning referrers

Project Member Reported by csharrison@chromium.org, May 31 2016 
The current behavior applies the HSTS when *predicting* but not learning. This yield the following mistake:

1. Navigate to http://A.com, which redirects to https://A.com
2. A.com loads B.com/script.js, with referrer back to http://A.com, we learn http://A.com => B.com.
...
...
3. Navigate again to http://A.com, we apply the HSTS and check if we have any subresources with referrer https://A.com. We find none and perform no preconnects.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ffc3b20c2f695960e97696e750397e0bae4f1ea

commit 1ffc3b20c2f695960e97696e750397e0bae4f1ea
Author: csharrison <csharrison@chromium.org>
Date: Wed Jun 01 21:35:22 2016

[predictor] Apply HSTS redirects when learning referrers.

The net predictor skips HSTS redirects when issuing preconnects,
but doesn't do so when learning them. This patch changes
behavior such that if http://a.com shows up as a referrer
for b.com, we properly learn https://a.com => b.com if we know
that http://a.com redirects to https://a.com.

BUG= 616219 

Review-Url: https://codereview.chromium.org/2022963003
Cr-Commit-Position: refs/heads/master@{#397254}

[modify] https://crrev.com/1ffc3b20c2f695960e97696e750397e0bae4f1ea/chrome/browser/net/predictor.cc
[modify] https://crrev.com/1ffc3b20c2f695960e97696e750397e0bae4f1ea/chrome/browser/net/predictor_unittest.cc

Comment 2 by csharrison@chromium.org, Jun 1 2016

Status: Fixed (was: Started)
►

Sign in to add a comment