New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616216 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 616753



Sign in to add a comment

CQ should understand git footers

Project Member Reported by martiniss@chromium.org, May 31 2016

Issue description

See https://chromium.googlesource.com/chromium/tools/build/+/2153f5593af1cb1e25847fc5a483cc9f10ff95db for an example; it should have both git footer tags in one paragraph, which is the way they're defined.

It shouldn't add a newline to the above commit message.
 
Blocking: 616753
Owner: tandrii@chromium.org
Status: Assigned (was: Unconfirmed)
Status: Started (was: Assigned)
https://chromereviews.googleplex.com/445687013 and https://chromereviews.googleplex.com/440307013 should fix this.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/2c0e58bcde59dc9ef076a25449725a4867818698

commit 2c0e58bcde59dc9ef076a25449725a4867818698
Author: tandrii <tandrii@google.com>
Date: Fri Jun 03 16:11:30 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/64e60a3d753ca8e421d33302531a0263c24c1cce

commit 64e60a3d753ca8e421d33302531a0263c24c1cce
Author: tandrii <tandrii@google.com>
Date: Fri Jun 03 17:30:28 2016

Ok initial import of new git_cl and git_footers into CQ didn't fail. So, this bug should be fixed, but to be sure - here is a test: https://codereview.chromium.org/2030343003
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 3 2016

Status: Fixed (was: Started)
Perfect!

Sign in to add a comment