New issue
Advanced search Search tips

Issue 616185 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Advertise the presence of origin trials when accessed while disabled.

Project Member Reported by iclell...@chromium.org, May 31 2016

Issue description

The fix for  issue 584367  also removed the console message that was emitted when disabled origin trial attributes were accessed.

We should be able to add that functionality back, without actually adding symbols to the global namespace (or navigator, or internals, or any other objects) by watching for access to specific names on window or navigator, and issuing a console message if code attempts to use them.

I believe that this is possible by hooking into the namedPropertyGetter for V8Window, which will not add any properties to the object, and will not cause expressions like 'property in window' to become true, but can have other side effects, like logging to the console.
 
Cc: haraken@chromium.org adamk@chromium.org
This is only possible for things that already have an interceptor, so yeah we can probably do it for V8Window, I don't think we can do it for navigator though.
Components: Blink>Bindings
Is adding an interceptor for V8Navigator out of the question?

I'm sure that access to navigator is performance-sensitive, but then I would expect window to be as well.

Project Member

Comment 4 by sheriffbot@chromium.org, Jul 7 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by cha...@chromium.org, Mar 31 2017

Labels: -M-54 -MovedFrom-53
Owner: ----
Status: Available (was: Started)

Comment 6 by cha...@chromium.org, Aug 16 2017

Labels: -Type-Bug Type-Feature

Comment 7 by cha...@chromium.org, Aug 17 2017

Labels: Needs-Feedback

Comment 8 by cha...@chromium.org, Aug 17 2017

Labels: -Needs-Feedback
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 20

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)

Sign in to add a comment