New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616179 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Restore windows chrome icon has no running status indication bar on shelf

Project Member Reported by warx@chromium.org, May 31 2016

Issue description

Version: 53.0.2751.0
OS: chromeos

What steps will reproduce the problem?
(1) Choose one window such as "chrome web store", and select "open as window" mode
(2) Open a blank browser window
(3) Open chrome web store as new window
(4) see attachment one
(5) reboot system
(6) only chrome web store has running status indication bar on shelf. Chrome icon is missing

What is the expected output?
attachment 2 should be the same as attachment 1.

 
before restore.png
739 KB View Download
after restore.png
896 KB View Download

Comment 1 by warx@chromium.org, May 31 2016

Labels: -Pri-3 Pri-2
I met the same/close issue when solving  crbug.com/314226 , that is minimized chrome doesn't have running status bar on chrome icon on shelf like pic 2. So vote for p2.
Owner: warx@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by warx@chromium.org, Jun 7 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f5c5f44fbaf89a0b53c95adc55264362624811a

commit 0f5c5f44fbaf89a0b53c95adc55264362624811a
Author: warx <warx@chromium.org>
Date: Wed Jun 08 21:56:57 2016

Fix restore windows chrome icon has no running status bar on shelf

The edge case in crbug/616179 happens when browser window is not active, which means browser_list->begin_last_active() to end_last_active() cannot track it.

BUG= 616179 
TEST=manually test sees bug fixed

Review-Url: https://codereview.chromium.org/2051503002
Cr-Commit-Position: refs/heads/master@{#398695}

[modify] https://crrev.com/0f5c5f44fbaf89a0b53c95adc55264362624811a/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/0f5c5f44fbaf89a0b53c95adc55264362624811a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

Comment 5 by warx@chromium.org, Jun 8 2016

Status: Fixed (was: Started)
Labels: VerifyIn-53
Status: Verified (was: Fixed)
Chrome Os 53.02785.55/8530.49.0 cyan

Sign in to add a comment