New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616176 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue angleproject:1407

Blocking:
issue 429053



Sign in to add a comment

RGB565 and RGB565_A1 doesn't work on Win8

Project Member Reported by zmo@chromium.org, May 31 2016

Issue description

Looking at webgl2_conformance_test_expectations.py, there are a list of win8 specific failures that are related to RGB565 and RGB565_A1 formats.
 
Suppressions added here: https://codereview.chromium.org/1343393006

We'll have to verify if they still apply.
Blockedon: angleproject:1407
Owner: jmad...@chromium.org
Status: Started (was: Available)
Working on associated ANGLE issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/6e4d1d21f702319414b9d0c45c5f3ea6ead54526

commit 6e4d1d21f702319414b9d0c45c5f3ea6ead54526
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Jun 08 20:32:27 2016

D3D11: Simplify load function table init.

Now that C++11 constructor syntax is allowed, we can use a much
simpler scheme.

BUG= angleproject:1407 
BUG= chromium:616176 

Change-Id: Ida5f235c3ed1429564af5213a5fead6c3b896080
Reviewed-on: https://chromium-review.googlesource.com/350903
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/6e4d1d21f702319414b9d0c45c5f3ea6ead54526/src/libANGLE/renderer/d3d/d3d11/load_functions_table_autogen.cpp
[modify] https://crrev.com/6e4d1d21f702319414b9d0c45c5f3ea6ead54526/src/libANGLE/renderer/d3d/d3d11/gen_load_functions_table.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb7def6d87f94193ab7973b69b3dcf312d4a04e6

commit cb7def6d87f94193ab7973b69b3dcf312d4a04e6
Author: geofflang <geofflang@chromium.org>
Date: Tue Jun 14 19:55:01 2016

Roll ANGLE 768996c..dfde6ab

https://chromium.googlesource.com/angle/angle.git/+log/768996c..dfde6ab

BUG= chromium:616176 

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2062173002
Cr-Commit-Position: refs/heads/master@{#399767}

[modify] https://crrev.com/cb7def6d87f94193ab7973b69b3dcf312d4a04e6/DEPS

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb7def6d87f94193ab7973b69b3dcf312d4a04e6

commit cb7def6d87f94193ab7973b69b3dcf312d4a04e6
Author: geofflang <geofflang@chromium.org>
Date: Tue Jun 14 19:55:01 2016

Roll ANGLE 768996c..dfde6ab

https://chromium.googlesource.com/angle/angle.git/+log/768996c..dfde6ab

BUG= chromium:616176 

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2062173002
Cr-Commit-Position: refs/heads/master@{#399767}

[modify] https://crrev.com/cb7def6d87f94193ab7973b69b3dcf312d4a04e6/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e236fa651cd2deadbcecad991ead35b00e6e9a1f

commit e236fa651cd2deadbcecad991ead35b00e6e9a1f
Author: cwallez <cwallez@chromium.org>
Date: Wed Jun 15 17:09:39 2016

Roll ANGLE dfde6ab..9fc7b4c

https://chromium.googlesource.com/angle/angle.git/+log/dfde6ab..9fc7b4c

BUG= chromium:616176 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2062403002
Cr-Commit-Position: refs/heads/master@{#399933}

[modify] https://crrev.com/e236fa651cd2deadbcecad991ead35b00e6e9a1f/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d16d24232e74ec53ad4f8e2122522438cc5cfd79

commit d16d24232e74ec53ad4f8e2122522438cc5cfd79
Author: zmo <zmo@chromium.org>
Date: Wed Jun 15 17:14:12 2016

Remove failing Win8 tests related with RGB565 formats.

BUG= 616176 
TEST=win8 gpu bots
TBR=jmadill@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2070073002
Cr-Commit-Position: refs/heads/master@{#399937}

[modify] https://crrev.com/d16d24232e74ec53ad4f8e2122522438cc5cfd79/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b21579379491b38288d5772d210937b62f2332c

commit 6b21579379491b38288d5772d210937b62f2332c
Author: zmo <zmo@chromium.org>
Date: Thu Jun 16 00:36:36 2016

Enable RGB5_A1 format related webgl2 conformance tests.

BUG= 616176 
TEST=win8 gpu bot
TBR=jmadill@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2066603006
Cr-Commit-Position: refs/heads/master@{#400061}

[modify] https://crrev.com/6b21579379491b38288d5772d210937b62f2332c/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/230d95616d1309914a6703e27a797a440806dd02

commit 230d95616d1309914a6703e27a797a440806dd02
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Jun 15 22:11:52 2016

D3D11: Fix readback of BGRA-backed formats.

For some BGRA-backed formats (RGBA4, R5G6B5, RGB5A1), our ReadPixels
implementation wasn't aware the BGRA format didn't exactly match the
RGBA format. For these it would do the 'fast path' memcpy method, when
it should stop and do the slow pixel-by-pixel packing method.

BUG= angleproject:1407 
BUG= chromium:616176 

Change-Id: Ie24758513af6f9ef87f0aa503135456c96493701
Reviewed-on: https://chromium-review.googlesource.com/352252
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/230d95616d1309914a6703e27a797a440806dd02/src/libANGLE/renderer/d3d/d3d11/texture_format_data.json
[modify] https://crrev.com/230d95616d1309914a6703e27a797a440806dd02/src/tests/test_utils/ANGLETest.h
[modify] https://crrev.com/230d95616d1309914a6703e27a797a440806dd02/src/libANGLE/renderer/d3d/d3d11/texture_format_table.h
[modify] https://crrev.com/230d95616d1309914a6703e27a797a440806dd02/src/tests/test_utils/ANGLETest.cpp
[modify] https://crrev.com/230d95616d1309914a6703e27a797a440806dd02/src/tests/gl_tests/SixteenBppTextureTest.cpp
[modify] https://crrev.com/230d95616d1309914a6703e27a797a440806dd02/src/common/angleutils.h
[modify] https://crrev.com/230d95616d1309914a6703e27a797a440806dd02/src/libANGLE/renderer/imageformats.h
[modify] https://crrev.com/230d95616d1309914a6703e27a797a440806dd02/src/libANGLE/renderer/d3d/d3d11/gen_texture_format_table.py
[modify] https://crrev.com/230d95616d1309914a6703e27a797a440806dd02/src/libANGLE/renderer/d3d/d3d11/texture_format_table_autogen.cpp
[modify] https://crrev.com/230d95616d1309914a6703e27a797a440806dd02/src/libANGLE/renderer/d3d/d3d11/Framebuffer11.cpp

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e973b43fd81bb5066ec3c95034e8290cde5068eb

commit e973b43fd81bb5066ec3c95034e8290cde5068eb
Author: jmadill <jmadill@chromium.org>
Date: Thu Jun 16 21:19:09 2016

Roll ANGLE 9fc7b4c..cd1b122

https://chromium.googlesource.com/angle/angle.git/+log/9fc7b4c..cd1b122

BUG= chromium:616176 , 620687 

TEST=bots
TBR=geofflang@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2076523003
Cr-Commit-Position: refs/heads/master@{#400258}

[modify] https://crrev.com/e973b43fd81bb5066ec3c95034e8290cde5068eb/DEPS

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 20 2016

Comment 16 by zmo@chromium.org, Jul 1 2016

Status: Fixed (was: Started)
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/ec0b580d650ee36005c8259ea115f6fb30a4c3ac

commit ec0b580d650ee36005c8259ea115f6fb30a4c3ac
Author: Jamie Madill <jmadill@chromium.org>
Date: Mon Jul 04 17:11:59 2016

Re-land "D3D11: Fix readback of BGRA-backed formats."

For some BGRA-backed formats (RGBA4, R5G6B5, RGB5A1), our ReadPixels
implementation wasn't aware the BGRA format didn't exactly match the
RGBA format. For these it would do the 'fast path' memcpy method, when
it should stop and do the slow pixel-by-pixel packing method.

Fixes conformance2/reading/read-pixels-from-fbo-test.html.

Reland: fix empty format info that was causing us to only see the
first pixel in the FBO in a ReadPixels call. Also fix bugs in the
unorm 16-bit format readback code, and add ASSERTs to catch bugs in
subsequent new formats.

BUG= angleproject:1407 
BUG= chromium:616176 

Change-Id: I9fd55b9e1dd6a306eb4db195d775c02a1eb1f93f
Reviewed-on: https://chromium-review.googlesource.com/357132
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/d3d/d3d11/texture_format_data.json
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/d3d/loadimage.cpp
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/tests/test_utils/ANGLETest.h
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/tests/test_utils/ANGLETest.cpp
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/tests/gl_tests/SixteenBppTextureTest.cpp
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/d3d/d3d11/load_functions_data.json
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/formatutils.cpp
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/renderer_utils.cpp
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/d3d/d3d11/texture_format_map.json
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/d3d/d3d11/load_functions_table_autogen.cpp
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/imageformats.h
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/common/angleutils.h
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/d3d/d3d11/texture_format_table.h
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/d3d/loadimage.h
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/d3d/d3d11/gen_texture_format_table.py
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/d3d/d3d11/texture_format_table_autogen.cpp
[modify] https://crrev.com/ec0b580d650ee36005c8259ea115f6fb30a4c3ac/src/libANGLE/renderer/d3d/d3d11/Framebuffer11.cpp

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f88ffc45920456f0840acf3299c0a5e24bdebc9

commit 6f88ffc45920456f0840acf3299c0a5e24bdebc9
Author: geofflang <geofflang@chromium.org>
Date: Tue Jul 05 16:21:08 2016

Roll ANGLE 474a08c..3820e9c

https://chromium.googlesource.com/angle/angle.git/+log/474a08c..3820e9c

BUG= chromium:625363 , 612205 , chromium:616176 , 407309 

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2126623002
Cr-Commit-Position: refs/heads/master@{#403788}

[modify] https://crrev.com/6f88ffc45920456f0840acf3299c0a5e24bdebc9/DEPS

Components: -Internals>GPU>WebGL Blink>WebGL

Sign in to add a comment