New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616135 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

When DownloadDirectory is set, "Save Link As" downloads files without prompting for location

Reported by azale...@greatneck.k12.ny.us, May 31 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/601.6.17 (KHTML, like Gecko) Version/9.1.1 Safari/601.6.17

Steps to reproduce the problem:
1. Force the DownloadDirectory preference via a profile.
2. Browse to any page that contains a link.
3. Right-click or control-click the link and select "Save Link As..."

What is the expected behavior?
A modal save sheet should appear, allowing the user to pick where they want to save the file to.

What went wrong?
The download begins immediately, saving to the location set in the DownloadDirectory preference.

Did this work before? N/A 

Chrome version: 51.0.2704.63  Channel: stable
OS Version: OS X 10.11.5
Flash Version: 21.0.0.242

I understand that by forcing the DownloadDirectory preference the implication is that an administrator wants to disallow saving to any other folder. However, Safari allows a default download directory to be set by a profile but also allows users to save to a location of their choosing on a case-by-case basis if they right/control-click on a link and select "Save Linked File As...". Users with network homes are then able to select a local destination to save very large files instead of hitting their network home space quota.
 

Comment 1 by mef@chromium.org, May 31 2016

Components: UI>Browser>Downloads

Comment 2 by asanka@chromium.org, May 31 2016

Labels: Needs-Feedback
You are correct that setting DownloadDirectory restricts downloads to the specified directory. Otherwise, Chrome uses the default downloads directory as a starting point and allows the user to set their own downloads directory.

Can you explain why leaving the DownloadDirectory unset is not an option?


Cc: georgesak@chromium.org
Labels: -Type-Bug Type-Feature
Looks like a feature request to match Safari behavior, not a bug per se.
Labels: Enterprise-triaged

Comment 5 by mmenke@chromium.org, Jun 23 2016

azaleski:  Mind answering asanka's question on why just not setting DownloadDirectory doesn't work for you?

I'm not sure we really want to be relaxing how enterprise policy behaves.
The download directory for our network users is not the default location of /Users/$user/Downloads, so not setting DownloadDirectory is not an option for us. 
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 24 2016

Labels: -Needs-Feedback Needs-Review
Owner: asanka@chromium.org
Thank you for providing more feedback. Adding requester "asanka@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by asanka@chromium.org, Jun 24 2016

Cc: asanka@chromium.org
Labels: -Pri-2 Pri-3
Owner: ----
I'll defer to enterprise on this one.

I don't think relaxing the constraints imposed by the policy will be fair to those who've relied on its documented behavior. We may need to introduce something else that'll control whether the profile defined download directory can be overridden by the user.
Cc: blumberg@chromium.org
Labels: OS-Chrome OS-Linux OS-Windows
Cc: -georgesak@chromium.org
Owner: georgesak@chromium.org
Status: Available (was: Unconfirmed)
I agree that we shouldn't change the existing policy as it's already well documented and working as intended.

We'll evaluate whether we add a new policy (DefaultDownloadDirectory?) that allows overriding of the default location.

Comment 11 by mad@chromium.org, Jan 24 2017

Should this be included in  Issue 683797  ?
Labels: -Needs-Review
Cleaning up sheriffbot label "Needs-Review" label as a part of modified "Needs-Feedback" sheriffbot rule. [ref bug for cleanup 684919]
Labels: Hotlist-Fixit-PE2017
Cc: georgesak@chromium.org
Owner: macourteau@chromium.org
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7191b800f101e959801c95b75329ec89a7dfe514

commit 7191b800f101e959801c95b75329ec89a7dfe514
Author: Marc-Antoine Courteau <macourteau@chromium.org>
Date: Thu Nov 23 17:23:56 2017

Adds the DefaultDownloadDirectory policy.

Bug:  616135 
Change-Id: Ic808a1dd6803e7702ceb8af445e42cbe0c03e2b4
Reviewed-on: https://chromium-review.googlesource.com/771546
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518970}
[modify] https://crrev.com/7191b800f101e959801c95b75329ec89a7dfe514/chrome/browser/BUILD.gn
[add] https://crrev.com/7191b800f101e959801c95b75329ec89a7dfe514/chrome/browser/download/default_download_dir_policy_handler.cc
[add] https://crrev.com/7191b800f101e959801c95b75329ec89a7dfe514/chrome/browser/download/default_download_dir_policy_handler.h
[modify] https://crrev.com/7191b800f101e959801c95b75329ec89a7dfe514/chrome/browser/download/download_dir_policy_handler.cc
[add] https://crrev.com/7191b800f101e959801c95b75329ec89a7dfe514/chrome/browser/download/download_dir_util.cc
[add] https://crrev.com/7191b800f101e959801c95b75329ec89a7dfe514/chrome/browser/download/download_dir_util.h
[modify] https://crrev.com/7191b800f101e959801c95b75329ec89a7dfe514/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/7191b800f101e959801c95b75329ec89a7dfe514/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/7191b800f101e959801c95b75329ec89a7dfe514/components/policy/resources/policy_templates.json
[modify] https://crrev.com/7191b800f101e959801c95b75329ec89a7dfe514/tools/metrics/histograms/enums.xml

Status: Fixed (was: Available)
Labels: M-64
As verified in ChromeOS M64.0.3282.79 10176.41.0 beta glimmer, the bug has been fixed as "Save link as ..." prompts the save destination modal as expected.
Cc: yanglee@chromium.org
Pending Verification on Chrome on Linux/Windows/Mac
Labels: cros-verified

Sign in to add a comment