New issue
Advanced search Search tips

Issue 616130 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Search+Shift+Volume up causes context menu to appear and then disappear

Project Member Reported by dtseng@chromium.org, May 31 2016

Issue description

Within the address bar, press search shift volume up (f10)

result:
the context menu shows and then immediately closes.

Notes:
It appears that the search (keyc code 91) keyup causes the menu to close.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae9dad85f214ce7a33c821e28b1dacbadea9bac0

commit ae9dad85f214ce7a33c821e28b1dacbadea9bac0
Author: dtseng <dtseng@chromium.org>
Date: Mon Oct 24 23:21:30 2016

Fix keyboard-activated context menus

In Ash, there is logic to close menus then asynchronisly perform an accelerator command. However, the accelerator that opens the context menu itself can and does trigger the close path depending on how a person executes the command.

On Chrome OS, the shortcut to open a context menu is Search+Shift+Volume Up. Any of these keys should leave the menu as is otherwise, the context menu is effectively a no-op when triggered from the keyboard.

TEST=on device, hit search; verify apps list opens. Press Search+Shift+Volume up; verify context menu opens. Press Search+m with ChromeVox on, verify context menu opens.
BUG= 621331 , 616130 

Review-Url: https://codereview.chromium.org/2434483003
Cr-Commit-Position: refs/heads/master@{#427178}

[modify] https://crrev.com/ae9dad85f214ce7a33c821e28b1dacbadea9bac0/ash/common/accelerators/accelerator_table.cc

Comment 2 by dtseng@chromium.org, Oct 25 2016

Status: fixed (was: Untriaged)

Comment 3 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61
Status: Verified (was: Fixed)
verified on build 9817.0.0

Sign in to add a comment