New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616126 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Build error in chromeos-3.18 if PM_OPP is enabled

Project Member Reported by groeck@chromium.org, May 31 2016

Issue description

The following build error is seen in chromeos-3.18 if PM_OPP is enabled.

drivers/base/power/opp/core.c: In function ‘_find_device_opp’:
drivers/base/power/opp/core.c:37:30: error: expected ‘)’ before ‘(’ token
     (s && srcu_read_lock_held(s)) || \

Caused by commit eb1d0193aec2 ("BACKPORT: FROMLIST: OPP: Allow notifiers to call dev_pm_opp_get_{voltage,freq} RCU-free"). opp_rcu_lockdep_assert() now has a parameter, which was not added for all calls.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2016

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/62e3f6c7bcf3fcd2dca1def72705a942f791ac36

commit 62e3f6c7bcf3fcd2dca1def72705a942f791ac36
Author: Guenter Roeck <groeck@chromium.org>
Date: Tue May 31 13:38:04 2016

CHROMIUM: OPP: Fix up calls to opp_rcu_lockdep_assert()

If PM_OPP is enabled, builds fail with

drivers/base/power/opp/core.c: In function '_find_device_opp':
	drivers/base/power/opp/core.c:37:30: error: expected ')' before '(' token

rcu_lockdep_assert() now has a parameter.

BUG= chromium:616126 
TEST=build with CONFIG_PM_OPP enabled

Fixes: eb1d0193aec2 ("BACKPORT: FROMLIST: OPP: Allow notifiers to call dev_pm_opp_get_{voltage,freq} RCU-free")
Change-Id: I211fa3af81cd9bf96026b1a71e0052a9c2e11cb3
Cc: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/348303
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

[modify] https://crrev.com/62e3f6c7bcf3fcd2dca1def72705a942f791ac36/drivers/base/power/opp/core.c

Labels: Merge-Request-52
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2016

Labels: merge-merged-release-R52-8350.B-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/3c3a9338b23aa57ffc9f8e30a37f67ebf1e91469

commit 3c3a9338b23aa57ffc9f8e30a37f67ebf1e91469
Author: Guenter Roeck <groeck@chromium.org>
Date: Tue May 31 13:38:04 2016

CHROMIUM: OPP: Fix up calls to opp_rcu_lockdep_assert()

If PM_OPP is enabled, builds fail with

drivers/base/power/opp/core.c: In function '_find_device_opp':
	drivers/base/power/opp/core.c:37:30: error: expected ')' before '(' token

rcu_lockdep_assert() now has a parameter.

BUG= chromium:616126 
TEST=build with CONFIG_PM_OPP enabled

Fixes: eb1d0193aec2 ("BACKPORT: FROMLIST: OPP: Allow notifiers to call dev_pm_opp_get_{voltage,freq} RCU-free")
Change-Id: I211fa3af81cd9bf96026b1a71e0052a9c2e11cb3
Cc: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/348303
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/348603
Commit-Queue: Daniel Kurtz <djkurtz@chromium.org>
Trybot-Ready: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>

[modify] https://crrev.com/3c3a9338b23aa57ffc9f8e30a37f67ebf1e91469/drivers/base/power/opp/core.c

Cc: oak-mtk@chromium.org
Labels: -OS-Linux -Type-Bug Kernel-3.18 OS-Chrome Type-Bug-Regression
Status: Verified (was: Started)
(this was merged to R52 along with the patch set that introduced the bug, as part for issue chrome-os-partner:50411).
Labels: Merge-Approved-52
Labels: Merge-Merged

Comment 7 by tin...@google.com, Jun 2 2016

Labels: -Merge-Request-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 5 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 8 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-52
Already merged.

Sign in to add a comment