Issue metadata
Sign in to add a comment
|
Build error in chromeos-3.18 if PM_OPP is enabled |
||||||||||||||||||||
Issue description
The following build error is seen in chromeos-3.18 if PM_OPP is enabled.
drivers/base/power/opp/core.c: In function ‘_find_device_opp’:
drivers/base/power/opp/core.c:37:30: error: expected ‘)’ before ‘(’ token
(s && srcu_read_lock_held(s)) || \
Caused by commit eb1d0193aec2 ("BACKPORT: FROMLIST: OPP: Allow notifiers to call dev_pm_opp_get_{voltage,freq} RCU-free"). opp_rcu_lockdep_assert() now has a parameter, which was not added for all calls.
,
Jun 1 2016
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/3c3a9338b23aa57ffc9f8e30a37f67ebf1e91469 commit 3c3a9338b23aa57ffc9f8e30a37f67ebf1e91469 Author: Guenter Roeck <groeck@chromium.org> Date: Tue May 31 13:38:04 2016 CHROMIUM: OPP: Fix up calls to opp_rcu_lockdep_assert() If PM_OPP is enabled, builds fail with drivers/base/power/opp/core.c: In function '_find_device_opp': drivers/base/power/opp/core.c:37:30: error: expected ')' before '(' token rcu_lockdep_assert() now has a parameter. BUG= chromium:616126 TEST=build with CONFIG_PM_OPP enabled Fixes: eb1d0193aec2 ("BACKPORT: FROMLIST: OPP: Allow notifiers to call dev_pm_opp_get_{voltage,freq} RCU-free") Change-Id: I211fa3af81cd9bf96026b1a71e0052a9c2e11cb3 Cc: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/348303 Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/348603 Commit-Queue: Daniel Kurtz <djkurtz@chromium.org> Trybot-Ready: Daniel Kurtz <djkurtz@chromium.org> Tested-by: Daniel Kurtz <djkurtz@chromium.org> [modify] https://crrev.com/3c3a9338b23aa57ffc9f8e30a37f67ebf1e91469/drivers/base/power/opp/core.c
,
Jun 1 2016
(this was merged to R52 along with the patch set that introduced the bug, as part for issue chrome-os-partner:50411).
,
Jun 1 2016
,
Jun 1 2016
,
Jun 2 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 5 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2016
Already merged. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2016