New issue
Advanced search Search tips

Issue 616110 link

Starred by 1 user
Status: Fixed
Owner:
paulmeyer@chromium.org
Closed: May 2016
Cc:
dewittj@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

MHTMLGenerationTest.ViewedMHTMLContainsNoStoreContentIfNoCacheControlPolicy test flaky.

Project Member Reported by paulmeyer@chromium.org, May 31 2016 
Version: 53.0.2753.0 
OS: All

I'm seeing this test fail occasionally. I get this error:

../../content/browser/download/mhtml_generation_browsertest.cc:168: Failure
Value of: actual_number_of_matches
  Actual: 0
Expected: 1

Comment 1 by paulmeyer@chromium.org, May 31 2016 

I have an idea of what might be wrong here so I will try a fix.
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7c18f6c0bc2c601ee718e61fac29280e7059042

commit d7c18f6c0bc2c601ee718e61fac29280e7059042
Author: paulmeyer <paulmeyer@chromium.org>
Date: Tue May 31 18:23:14 2016

Fix for flaky MHTMLGenerationTest.ViewedMHTMLContainsNoStoreContentIfNoCacheControlPolicy test.

The problem is here: https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/download/mhtml_generation_browsertest.cc&l=61

The number of matches is checked at the first reply to the find request, without checking that the find operation actually finished. The number of matches should be checked only when |final_update| is true.

BUG= 616110 

Review-Url: https://codereview.chromium.org/2026773002
Cr-Commit-Position: refs/heads/master@{#396869}

[modify] https://crrev.com/d7c18f6c0bc2c601ee718e61fac29280e7059042/content/browser/download/mhtml_generation_browsertest.cc

Comment 3 by paulmeyer@chromium.org, May 31 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment