New issue
Advanced search Search tips

Issue 616105 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

git cl patch -b doesn't set correctly the issue number.

Project Member Reported by tandrii@chromium.org, May 31 2016

Issue description

Repro:

git clone ...depot_tools.git
git new-branch any_branch
git cl patch -b patch_branch 2004303003
git cl status
    any_branch : https://codereview.chromium.org/2004303003 (closed)
  patch_branch : 

 
Correction:

git new-branch any_branch
git cl patch -b patch_branch 2023943003
git cl status
    any_branch : https://codereview.chromium.org/2023943003 (unsent)
  patch_branch : None 
Owner: tandrii@chromium.org
Status: Started (was: Untriaged)
CL to fix: https://codereview.chromium.org/2022183003
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c2786d933bb6517a88ba6ff95e1606f656d89178

commit c2786d933bb6517a88ba6ff95e1606f656d89178
Author: tandrii@chromium.org <tandrii@chromium.org>
Date: Tue May 31 19:53:50 2016

Fix & refactor git cl patch.

* Fixes a bug when issue was incorrectly over-written
  in another branch. Add a test case.
* Refactor for better flow.
* Update outdated errors on wrong arguments.

BUG= 616105 
R=andybons@chromium.org,sergiyb@chromium.org

Review-Url: https://codereview.chromium.org/2022183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300681 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/c2786d933bb6517a88ba6ff95e1606f656d89178/git_cl.py
[modify] https://crrev.com/c2786d933bb6517a88ba6ff95e1606f656d89178/tests/git_cl_test.py

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/abc98affa9579fb36961b51fc7f2ce7edc168322

commit abc98affa9579fb36961b51fc7f2ce7edc168322
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue May 31 20:07:11 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/c2786d933bb6517a88ba6ff95e1606f656d89178 Fix & refactor git cl patch. (tandrii@chromium.org)

R=sergiyb@chromium.org,andybons@chromium.org,tandrii@chromium.org
BUG= 616105 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2027813002

[modify] https://crrev.com/abc98affa9579fb36961b51fc7f2ce7edc168322/infra/config/recipes.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 17 2016

Sign in to add a comment