New issue
Advanced search Search tips

Issue 616100 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest flaky on Android Tests bot

Project Member Reported by guidou@chromium.org, May 31 2016

Issue description

See
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests

First observed flake:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/26745

Possible suspect CL: https://codereview.chromium.org/2012753003
This is the most recent CL touching any IndexedDB files before the flakes started.
 

Comment 1 by guidou@chromium.org, May 31 2016

Cc: pfeldman@chromium.org
Labels: Sheriff-Chromium
Owner: dgro...@chromium.org
dgrogan@, can you help triage this? you are listed as IndexedDB owner and wrote the test (years ago).

cc pfeldman@, who wrote a CL that modified some IndexedDB-related files a few builds before the flakes started.

In the meantime, I'm disabling the test.
Note that this test, along with several other IndexedDBBrowserTests, started flaking very frequently over on the K tablet bot on chromium.android on Friday: https://build.chromium.org/p/chromium.android/builders/KitKat%20Tablet%20Tester
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d194033e684b15f2991f87edc1bf5498b5526e81

commit d194033e684b15f2991f87edc1bf5498b5526e81
Author: guidou <guidou@chromium.org>
Date: Tue May 31 16:09:51 2016

Disable IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest

This test has been flaky on the Android Tests bot on the last few days.
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests

No CL looks like the obvious culprit, although the most recent CL touching IndexedDB-related files before the flakes started seems to be
https://codereview.chromium.org/2012753003

BUG= 616100 
TBR=dgrogan@chromium.org

Review-Url: https://codereview.chromium.org/2023763007
Cr-Commit-Position: refs/heads/master@{#396841}

[modify] https://crrev.com/d194033e684b15f2991f87edc1bf5498b5526e81/content/browser/indexed_db/indexed_db_browsertest.cc

Comment 4 by jsb...@chromium.org, May 31 2016

Owner: cmumford@chromium.org

Comment 5 by guidou@chromium.org, May 31 2016

Labels: -Sheriff-Chromium
This is an excerpt from the logs.

I  271.680s run_tests_on_device(01ab4b680c375d0a)  Note: Google Test filter = IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [==========] Running 1 test from 1 test case.
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [----------] Global test environment set-up.
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [----------] 1 test from IndexedDBBrowserTest, where TypeParam = 
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [ RUN      ] IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [WARNING:dns_config_service_posix.cc(316)] Failed to read DnsConfig.
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [ERROR:devtools_http_handler.cc(228)] Cannot start http server for devtools. Stop devtools.
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [INFO:indexed_db_browsertest.cc(88)] Navigating to URL and blocking.
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [ERROR:layer_tree_host_impl.cc(2243)] Forcing zero-copy tile initialization as worker context is missing
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [ERROR:shell_android.cc(70)] Not implemented reached in void content::Shell::PlatformSetTitle(const string16&): IDB test that origins over quota aren't trapped Part 1 / 2
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [INFO:indexed_db_browsertest.cc(90)] Navigation done.
I  271.680s run_tests_on_device(01ab4b680c375d0a)  ../../content/browser/indexed_db/indexed_db_browsertest.cc:437: Failure
I  271.680s run_tests_on_device(01ab4b680c375d0a)  Expected: (size) > (kQuotaKilobytes * 1024), actual: 1604 vs 2048
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [INFO:indexed_db_browsertest.cc(88)] Navigating to URL and blocking.
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [ERROR:shell_android.cc(70)] Not implemented reached in void content::Shell::PlatformSetTitle(const string16&): IDB test that origins over quota aren't trapped
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [INFO:indexed_db_browsertest.cc(90)] Navigation done.
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [  FAILED  ] IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest, where TypeParam =  and GetParam() =  (656 ms)
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [----------] 1 test from IndexedDBBrowserTest (656 ms total)
I  271.680s run_tests_on_device(01ab4b680c375d0a)  
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [----------] Global test environment tear-down
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [==========] 1 test from 1 test case ran. (657 ms total)
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [  PASSED  ] 0 tests.
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [  FAILED  ] 1 test, listed below:
I  271.680s run_tests_on_device(01ab4b680c375d0a)  [  FAILED  ] IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest, where TypeParam =  and GetParam() = 
I  271.680s run_tests_on_device(01ab4b680c375d0a)  
I  271.680s run_tests_on_device(01ab4b680c375d0a)   1 FAILED TEST


Also:
IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest (run #1):

IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest (run #2):

IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest (run #3):
Mergedinto: 616155
Status: Duplicate (was: Untriaged)
Seems to be caused by https://codereview.chromium.org/2018663002. I'll mark this as a duplicate of issue 616155, which covers failures in a variety of IndexedDB tests all caused by that patch.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cccf913208aa51a4a2a8c2837f949633a53d5baf

commit cccf913208aa51a4a2a8c2837f949633a53d5baf
Author: johnme <johnme@chromium.org>
Date: Tue Jun 07 11:38:42 2016

Re-enable IndexedDB tests that weren't really flaky

The following tests were marked flaky in  https://crbug.com/616100  and
https://crbug.com/616155:
- IndexedDBBrowserTest.GetAllMaxMessageSize
- IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest
- IndexedDBBrowserTest.DeleteCompactsBackingStore

But they're not so much flaky, as genuinely broken since
https://codereview.chromium.org/2018663002 landed. That patch will soon
be fixed or reverted now that it has been identified as the root cause.

BUG=616155, 616100 
TBR=jsbell@chromium.org

Review-Url: https://codereview.chromium.org/2044533002
Cr-Commit-Position: refs/heads/master@{#398271}

[modify] https://crrev.com/cccf913208aa51a4a2a8c2837f949633a53d5baf/content/browser/indexed_db/indexed_db_browsertest.cc

Sign in to add a comment