Issue metadata
Sign in to add a comment
|
Scrolling Jumps around uncontrollably with slow passive event listeners |
||||||||||||||||||||||
Issue descriptionBuild ToT on Ubuntu 14.04 I used: commit c7ae4bedf7fd3865492ffa48d5528916656b4c30 Author: lizeb <lizeb@chromium.org> Date: Tue May 31 05:51:52 2016 -0700 1) Visit http://dtapuska.github.io/passive/wheel-passive.html 2) Wheel scroll. 3) Stop wheel scrolling. 4) Wait for it; watch page jump to some random location. Build with "git revert 36a74489ec5e4fb898a7984398ad79b3798f70d7" Run the same steps and see that the page doesn't jump around.
,
May 31 2016
,
May 31 2016
Hi - why was I cc:ed to this? Anything I can help with?
,
May 31 2016
I cc'd you because you seem to be copied on the original bug and was the reviewer of the said change. I wasn't sure if you knew how the feature behaves; if not feel free to remove yourself.
,
May 31 2016
oh I see, sorry, missed that this was marked blocking https://bugs.chromium.org/p/chromium/issues/detail?id=612596. The CL that reverting solved this sets the default of the Field Trial "MainFrameBeforeActivation" to enabled. I'm part of the Field trial infastructure team, so I don't know the details of the behavior of MainFrameBeforeActivation being enabled - sunny will have to investigate
,
May 31 2016
+ brianderson@
,
Jun 1 2016
I'm rolling back the server side config for now.
,
Jun 2 2016
Issue 616264 has been merged into this issue.
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08 commit d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08 Author: sunnyps <sunnyps@chromium.org> Date: Fri Jun 10 03:36:12 2016 cc: Fix for synced property main thread updates with MFBA. Main thread before activation allows sending BeginMainFrames while there is a pending tree. In this mode pulling deltas from SyncedProperty for BeginMainFrame should not be incorrect in between commit and activation of a previous frame. BUG= 616086 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2035543003 Cr-Commit-Position: refs/heads/master@{#399079} [modify] https://crrev.com/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08/cc/base/synced_property.h [modify] https://crrev.com/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08/cc/trees/layer_tree_host_unittest_scroll.cc
,
Jun 13 2016
Reenabled experiment on dev/canary. Requesting merge to M52.
,
Jun 13 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d924383891e9d4c575f181dd8347e2f0392fb177 commit d924383891e9d4c575f181dd8347e2f0392fb177 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Mon Jun 13 19:27:41 2016 cc: Fix for synced property main thread updates with MFBA. Main thread before activation allows sending BeginMainFrames while there is a pending tree. In this mode pulling deltas from SyncedProperty for BeginMainFrame should not be incorrect in between commit and activation of a previous frame. BUG= 616086 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2035543003 Cr-Commit-Position: refs/heads/master@{#399079} (cherry picked from commit d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08) Review URL: https://codereview.chromium.org/2062963002 . Cr-Commit-Position: refs/branch-heads/2743@{#339} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/d924383891e9d4c575f181dd8347e2f0392fb177/cc/base/synced_property.h [modify] https://crrev.com/d924383891e9d4c575f181dd8347e2f0392fb177/cc/trees/layer_tree_host_unittest_scroll.cc
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08 commit d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08 Author: sunnyps <sunnyps@chromium.org> Date: Fri Jun 10 03:36:12 2016 cc: Fix for synced property main thread updates with MFBA. Main thread before activation allows sending BeginMainFrames while there is a pending tree. In this mode pulling deltas from SyncedProperty for BeginMainFrame should not be incorrect in between commit and activation of a previous frame. BUG= 616086 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2035543003 Cr-Commit-Position: refs/heads/master@{#399079} [modify] https://crrev.com/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08/cc/base/synced_property.h [modify] https://crrev.com/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08/cc/trees/layer_tree_host_unittest_scroll.cc
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d924383891e9d4c575f181dd8347e2f0392fb177 commit d924383891e9d4c575f181dd8347e2f0392fb177 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Mon Jun 13 19:27:41 2016 cc: Fix for synced property main thread updates with MFBA. Main thread before activation allows sending BeginMainFrames while there is a pending tree. In this mode pulling deltas from SyncedProperty for BeginMainFrame should not be incorrect in between commit and activation of a previous frame. BUG= 616086 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2035543003 Cr-Commit-Position: refs/heads/master@{#399079} (cherry picked from commit d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08) Review URL: https://codereview.chromium.org/2062963002 . Cr-Commit-Position: refs/branch-heads/2743@{#339} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/d924383891e9d4c575f181dd8347e2f0392fb177/cc/base/synced_property.h [modify] https://crrev.com/d924383891e9d4c575f181dd8347e2f0392fb177/cc/trees/layer_tree_host_unittest_scroll.cc
,
Jun 15 2016
Tested the issue on Ubuntu 14.04 using 52.0.2743.41.Observed that page not jumped to some random location after stopping wheel scroll. Marking it as TE-Verified.
,
Jun 15 2016
,
Jun 22 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, May 31 2016Labels: ReleaseBlock-Stable