New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 616086 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression

Blocking:
issue 612596



Sign in to add a comment

Scrolling Jumps around uncontrollably with slow passive event listeners

Project Member Reported by dtapu...@chromium.org, May 31 2016

Issue description

Build ToT on Ubuntu 14.04
I used:
commit c7ae4bedf7fd3865492ffa48d5528916656b4c30
Author: lizeb <lizeb@chromium.org>
Date:   Tue May 31 05:51:52 2016 -0700


1) Visit http://dtapuska.github.io/passive/wheel-passive.html
2) Wheel scroll.
3) Stop wheel scrolling.
4) Wait for it; watch page jump to some random location.


Build with "git revert 36a74489ec5e4fb898a7984398ad79b3798f70d7"

Run the same steps and see that the page doesn't jump around.
 
Cc: rkaplow@chromium.org
Labels: ReleaseBlock-Stable
+rkaplow

Setting Release Block Stable for now as we need to fix this before shipping.
Labels: M-52
Hi - why was I cc:ed to this? Anything I can help with?
I cc'd you because you seem to be copied on the original bug and was the reviewer of the said change. I wasn't sure if you knew how the feature behaves; if not feel free to remove yourself.
oh I see, sorry, missed that this was marked blocking https://bugs.chromium.org/p/chromium/issues/detail?id=612596.

The CL that reverting solved this sets the default of the Field Trial "MainFrameBeforeActivation" to enabled. I'm part of the Field trial infastructure team, so I don't know the details of the behavior of MainFrameBeforeActivation being enabled - sunny will have to investigate
Cc: briander...@chromium.org
+ brianderson@
I'm rolling back the server side config for now.
Issue 616264 has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08

commit d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08
Author: sunnyps <sunnyps@chromium.org>
Date: Fri Jun 10 03:36:12 2016

cc: Fix for synced property main thread updates with MFBA.

Main thread before activation allows sending BeginMainFrames while there
is a pending tree. In this mode pulling deltas from SyncedProperty for
BeginMainFrame should not be incorrect in between commit and activation
of a previous frame.

BUG= 616086 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2035543003
Cr-Commit-Position: refs/heads/master@{#399079}

[modify] https://crrev.com/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08/cc/base/synced_property.h
[modify] https://crrev.com/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08/cc/trees/layer_tree_host_unittest_scroll.cc

Labels: Merge-Request-52
Reenabled experiment on dev/canary. Requesting merge to M52.

Comment 11 by tin...@google.com, Jun 13 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 13 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d924383891e9d4c575f181dd8347e2f0392fb177

commit d924383891e9d4c575f181dd8347e2f0392fb177
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Mon Jun 13 19:27:41 2016

cc: Fix for synced property main thread updates with MFBA.

Main thread before activation allows sending BeginMainFrames while there
is a pending tree. In this mode pulling deltas from SyncedProperty for
BeginMainFrame should not be incorrect in between commit and activation
of a previous frame.

BUG= 616086 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2035543003
Cr-Commit-Position: refs/heads/master@{#399079}
(cherry picked from commit d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08)

Review URL: https://codereview.chromium.org/2062963002 .

Cr-Commit-Position: refs/branch-heads/2743@{#339}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/d924383891e9d4c575f181dd8347e2f0392fb177/cc/base/synced_property.h
[modify] https://crrev.com/d924383891e9d4c575f181dd8347e2f0392fb177/cc/trees/layer_tree_host_unittest_scroll.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08

commit d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08
Author: sunnyps <sunnyps@chromium.org>
Date: Fri Jun 10 03:36:12 2016

cc: Fix for synced property main thread updates with MFBA.

Main thread before activation allows sending BeginMainFrames while there
is a pending tree. In this mode pulling deltas from SyncedProperty for
BeginMainFrame should not be incorrect in between commit and activation
of a previous frame.

BUG= 616086 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2035543003
Cr-Commit-Position: refs/heads/master@{#399079}

[modify] https://crrev.com/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08/cc/base/synced_property.h
[modify] https://crrev.com/d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08/cc/trees/layer_tree_host_unittest_scroll.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d924383891e9d4c575f181dd8347e2f0392fb177

commit d924383891e9d4c575f181dd8347e2f0392fb177
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Mon Jun 13 19:27:41 2016

cc: Fix for synced property main thread updates with MFBA.

Main thread before activation allows sending BeginMainFrames while there
is a pending tree. In this mode pulling deltas from SyncedProperty for
BeginMainFrame should not be incorrect in between commit and activation
of a previous frame.

BUG= 616086 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2035543003
Cr-Commit-Position: refs/heads/master@{#399079}
(cherry picked from commit d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08)

Review URL: https://codereview.chromium.org/2062963002 .

Cr-Commit-Position: refs/branch-heads/2743@{#339}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/d924383891e9d4c575f181dd8347e2f0392fb177/cc/base/synced_property.h
[modify] https://crrev.com/d924383891e9d4c575f181dd8347e2f0392fb177/cc/trees/layer_tree_host_unittest_scroll.cc

Labels: TE-Verified-M52 TE-Verified-52.0.2743.41
Tested the issue on Ubuntu 14.04 using 52.0.2743.41.Observed that page not jumped to some random location after stopping wheel scroll.

Marking it as TE-Verified.
Status: Fixed (was: Assigned)
Cc: skobes@chromium.org
 Issue 617264  has been merged into this issue.

Sign in to add a comment