Issue metadata
Sign in to add a comment
|
8.3% regression in smoothness.top_25_smooth at 396655:396658 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 31 2016
=== Auto-CCing suspected CL author sigbjornf@opera.com === Hi sigbjornf@opera.com, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Tidy PendingScript. Author : sigbjornf Commit description: No need for a prefinalizer as ScriptLoader is careful to eagerly and explicitly dispose of PendingScripts already. Remove unwanted copy constructor; not needed after PendingScript stopped being a part object. R= BUG= Review-Url: https://codereview.chromium.org/2023683002 Cr-Commit-Position: refs/heads/master@{#396656} Commit : 0c0d99080d6ada1fbbf43e2b488accc65f413923 Date : Sun May 29 10:05:41 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@396654 18.0325 0.275788 5 good chromium@396655 18.0305 0.166295 5 good chromium@396656 19.2815 0.163514 5 bad <-- chromium@396658 18.9406 0.540802 7 bad Bisect job ran on: android_one_perf_bisect Bug ID: 616080 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth Test Metric: frame_times/LinkedIn Relative Change: 5.44% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1330 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011146668512640416 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5873589295775744 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 31 2016
===== BISECT JOB RESULTS ===== Status: completed === Bisection aborted === The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression. Please contact the the team (see below) if you believe this is in error. === Warnings === The following warnings were raised by the bisect job: * Bisect failed to reproduce the regression with enough confidence. ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@396654 18.4017 0.775126 5 good chromium@396658 19.072 0.986908 8 bad Bisect job ran on: android_one_perf_bisect Bug ID: 616080 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth Test Metric: frame_times/LinkedIn Relative Change: 2.53% Score: 0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1329 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011146672317425728 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5903572093370368 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 31 2016
I don't see how r396656 could have a perf impact, doing less work when finalizing, but in any case that was reverted via issue 615977.
,
Jun 7 2016
Regression seems recovered as per http://test-results.appspot.com/revision_range?start=396807&end=396815 |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by primiano@chromium.org
, May 31 2016