New issue
Advanced search Search tips

Issue 616069 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Files app: Invisible file is left in Downloads when downloading file is cancelled.

Project Member Reported by fukino@chromium.org, May 31 2016

Issue description

What steps will reproduce the problem?
(1) Start downloading a big file.
(2) Cancel the download on the way.

No new file is visible in Files app, but there actually is a file with name "Unconfirmed <number>.crdownload"

I suppose that those files should be deleted automatically, but as far as I confirmed on my Chromebook, the file have been in Downloads for a while (> 1 hour, after sign out/in).
I'm not sure when/whether the file will be deleted.

We made a change to hide *.crdownload ( issue 409490 ), but it might be safer to show those files now.
If we show the size of Downloads in storage manager, more users will notice that invisible file takes up some space.

How about make *.crdownload files visible again, or add a setting to show them?
 
Owner: fukino@chromium.org
Curious, why do we keep the file at all? Given limited space on chromebooks I'd like to automatically delete if a download is terminated. 

Comment 2 by tomac...@gmail.com, Jun 17 2016

Hi, fukino, I have this issue on occasion even when downloading. Maybe you will take this over and fix them both.

https://bugs.chromium.org/p/chromium/issues/detail?id=620919&q=crdownload&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified

Comment 3 by tomac...@gmail.com, Jun 17 2016

*even when the download is successful*

Comment 4 by fukino@chromium.org, Jul 20 2016

Re:#2
It looks a separated bug and tracked in  Issue 580906 .
In this bug, we focus on the bug occurring on Chrome OS.

Comment 5 by fukino@chromium.org, Jul 20 2016

Cc: yamaguchi@chromium.org mitsuji@chromium.org
Re:#1
I guess the file was not deleted due to a bug...

My concern is that .crdownload files can be stored in Downloads in some cases (listed below), and they can take up space invisibly forever.
- Chrome fails to clean-up the .crdownload file due to a bug.
- User downloads a file which has .crdownload extension. (Unlikely, but the behavior can be abused.)
- User renames a file to *.crdownload.

So, I think showing *.crdownload is safer.
WDTY?
Labels: -Pri-2 Hotlist-GoodFirstBug Pri-3
Owner: ----
Status: Available (was: Assigned)
Weifang, Do you agree with the approach in #5?

Comment 7 by sashab@chromium.org, Feb 24 2018

Labels: CrOS-FilesApp
Owner: weifangsun@chromium.org
Status: Assigned (was: Available)
Assigning to Weifang for response.
Cc: -mitsuji@chromium.org weifangsun@chromium.org
Owner: ----
Status: Unconfirmed (was: Assigned)
Thoughts -
(1) I think the key issue here is that we need to ensure we are successfully deleting the file if the user cancels the download. Is there still a bug surrounding this behavior?

(2) In the case where we do have an unexpected issue, I agree that we should show the *.crdownload file. The user should have the ability to manually remove this file if they choose.

Comment 9 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp
Status: Untriaged (was: Unconfirmed)
I can confirm that I can't see .crdownload files (after canceling the download).

On  crbug.com/409490  an user says that they use the .crdownload file to start watching the video even before the end of the download. Smart user. :-)

So, re-enabling the display of .crdownload files seems correct to me.
Status: Available (was: Untriaged)
Owner: slangley@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Labels: CrOSFilesCategory-UI
So there's a flag in the gear menu that an inspired user can use to see dot files and crdownload files ("Show Hidden Files").

But it seems crdownload shouldn't be hidden anyways, so making this change.
Seems sane to me.  Use "Show Hidden Files" for users of type #10.  
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/587fff9cb8ce4be7ffc416d1a746f62f62ad11ac

commit 587fff9cb8ce4be7ffc416d1a746f62f62ad11ac
Author: Stuart Langley <slangley@google.com>
Date: Wed Dec 19 05:34:22 2018

Show files ending with .crdownload in the file manager again.

It appears this was not tested, so added a basic test to the gear_menu
test as well.

Bug:  616069 
Change-Id: Iec705221deb64f07cbb59da84682f6bd588b0a82
Reviewed-on: https://chromium-review.googlesource.com/c/1382660
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617734}
[modify] https://crrev.com/587fff9cb8ce4be7ffc416d1a746f62f62ad11ac/ui/file_manager/file_manager/foreground/js/directory_contents.js
[modify] https://crrev.com/587fff9cb8ce4be7ffc416d1a746f62f62ad11ac/ui/file_manager/integration_tests/file_manager/gear_menu.js
[modify] https://crrev.com/587fff9cb8ce4be7ffc416d1a746f62f62ad11ac/ui/file_manager/integration_tests/test_util.js

Status: Fixed (was: Started)

Sign in to add a comment