New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 616060 link

Starred by 1 user
Status: Fixed
Owner:
amaralp@chromium.org
Closed: Jun 2016
Cc:
moh...@chromium.org
nyerramilli@chromium.org
█ ashej...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Context menu does not appear on long tap/touch on chrome://help.

Reported by jshan...@etouch.net, May 31 2016 
Chrome Version: 53.0.2753.0 (Official Build)bb0c85e1aaa882aa7c4c40b0e3da609573f07d8f-refs/heads/master@{#396745}-32/64 bit
OS: Windows 10(Touch device)

Steps:
1. Launch Chrome and navigate to chrome://help
2. Long tap/touch on the page and observe.

Actual: Context menu does not appear on long tap/touch.

Expected: Context menu should appear on long tap/touch.

This is a regression issue broken in M-53, below is bisect info.

Good build: 53.0.2747.0
Bad build: 53.0.2748.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/72e829d44ebea9010a95409aecbcf2dd92aa52cb..e79f1dd40fc3a6591b1a30aa911eaf1fbb339e49?pretty=fuller&n=100

Suspecting: r395490 ?

Please help to re-assign if your change is not the cause for this issue.

Note: This is touch device specific issue, same works fine on mouse click.
Actual_context.mp4
361 KB Download
Expected_context.mp4
504 KB Download

Comment 1 by ashej...@chromium.org, May 31 2016

Labels: ReleaseBlock-Beta
Marking the above issue as RB-Beta as this is a recent regression.

Thank you!
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a4f551361bcc1ea8f801d44b16b2d086feef2df

commit 9a4f551361bcc1ea8f801d44b16b2d086feef2df
Author: amaralp <amaralp@chromium.org>
Date: Wed Jun 01 19:24:13 2016

Fixing Regression Bug where context menu doesn't appear on long press

Added a Setting to tell Blink whether or not to always show the
context menu on a long press.

BUG= 616060 

Review-Url: https://codereview.chromium.org/2024323002
Cr-Commit-Position: refs/heads/master@{#397203}

[modify] https://crrev.com/9a4f551361bcc1ea8f801d44b16b2d086feef2df/content/public/common/web_preferences.cc
[modify] https://crrev.com/9a4f551361bcc1ea8f801d44b16b2d086feef2df/content/public/common/web_preferences.h
[modify] https://crrev.com/9a4f551361bcc1ea8f801d44b16b2d086feef2df/third_party/WebKit/Source/core/frame/Settings.in
[modify] https://crrev.com/9a4f551361bcc1ea8f801d44b16b2d086feef2df/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
[modify] https://crrev.com/9a4f551361bcc1ea8f801d44b16b2d086feef2df/third_party/WebKit/Source/web/ContextMenuClientImpl.h
[modify] https://crrev.com/9a4f551361bcc1ea8f801d44b16b2d086feef2df/third_party/WebKit/Source/web/WebSettingsImpl.cpp
[modify] https://crrev.com/9a4f551361bcc1ea8f801d44b16b2d086feef2df/third_party/WebKit/Source/web/WebSettingsImpl.h
[modify] https://crrev.com/9a4f551361bcc1ea8f801d44b16b2d086feef2df/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/9a4f551361bcc1ea8f801d44b16b2d086feef2df/third_party/WebKit/public/web/WebSettings.h

Comment 3 by amaralp@chromium.org, Jun 1 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment