V8 should use the same ICU config as chrome by default. V8 and chromium differ in using sysroot and icu_datafile. It is atm not possible to overwrite the defaults for these configs on a per-project basis.
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/cec0ed0f77e91bfd49bbd298ab58f77375eecead commit cec0ed0f77e91bfd49bbd298ab58f77375eecead Author: machenbach <machenbach@chromium.org> Date: Wed Jun 08 12:09:25 2016 [icu] Support loading data file from default location This allows using icu data, bundled in the icudtl.dat file, to be loaded automatically from a default location side-by-side with the executable. The v8 stand-alone default is still to use statically linked ICU data, but this will be switched in a separate follow-up CL. BUG= chromium:616033 LOG=y Review-Url: https://codereview.chromium.org/2042253002 Cr-Commit-Position: refs/heads/master@{#36823} [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/BUILD.gn [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/include/v8.h [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/samples/hello-world.cc [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/samples/process.cc [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/samples/shell.cc [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/src/api.cc [add] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/src/base/file-utils.cc [add] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/src/base/file-utils.h [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/src/d8.cc [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/src/icu_util.cc [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/src/icu_util.h [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/src/snapshot/mksnapshot.cc [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/src/startup-data-util.cc [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/src/v8.gyp [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/test/cctest/cctest.cc [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/test/cctest/interpreter/generate-bytecode-expectations.cc [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/test/fuzzer/fuzzer-support.cc [modify] https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead/tools/parser-shell.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/77af83ba18b44ae88d7faa2a3cb87d098f2735b9 commit 77af83ba18b44ae88d7faa2a3cb87d098f2735b9 Author: machenbach <machenbach@chromium.org> Date: Thu Jun 09 13:23:00 2016 [build] Use icu data file by default BUG= chromium:616033 LOG=y Review-Url: https://codereview.chromium.org/2049743002 Cr-Commit-Position: refs/heads/master@{#36862} [modify] https://crrev.com/77af83ba18b44ae88d7faa2a3cb87d098f2735b9/gypfiles/isolate.gypi [modify] https://crrev.com/77af83ba18b44ae88d7faa2a3cb87d098f2735b9/gypfiles/standalone.gypi [modify] https://crrev.com/77af83ba18b44ae88d7faa2a3cb87d098f2735b9/src/v8.gyp
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/9d12ad0df01b6aa5cff5b0ae1a7b83a854fd965e commit 9d12ad0df01b6aa5cff5b0ae1a7b83a854fd965e Author: mostynb <mostynb@opera.com> Date: Wed Jun 15 08:57:20 2016 include stdlib.h when using calloc Small followup to https://codereview.chromium.org/2042253002 BUG= chromium:616033 Review-Url: https://codereview.chromium.org/2061163003 Cr-Commit-Position: refs/heads/master@{#36992} [modify] https://crrev.com/9d12ad0df01b6aa5cff5b0ae1a7b83a854fd965e/src/base/file-utils.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/a774fa5142ae9d8d3539e1f25f6e9f04893a2121 commit a774fa5142ae9d8d3539e1f25f6e9f04893a2121 Author: machenbach <machenbach@chromium.org> Date: Wed Jun 15 11:57:11 2016 [gn] Fix config for icu data file and swarming Fix after: https://codereview.chromium.org/2042253002/ https://codereview.chromium.org/2049743002/ Using the data file is the default now and it shouldn't be overridden in v8's build_overrides. Also the isolate logic now needs to include the gni file specifying the flag. BUG= chromium:616033 TBR=jochen@chromium.org, vogelheim@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2062363002 Cr-Commit-Position: refs/heads/master@{#36998} [modify] https://crrev.com/a774fa5142ae9d8d3539e1f25f6e9f04893a2121/build_overrides/v8.gni [modify] https://crrev.com/a774fa5142ae9d8d3539e1f25f6e9f04893a2121/gni/isolate.gni
Comment 1 by machenb...@chromium.org
, May 31 2016Status: Assigned (was: Available)