New issue
Advanced search Search tips

Issue 616032 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 621726



Sign in to add a comment

V8 needs to support sysroot

Project Member Reported by hablich@chromium.org, May 31 2016

Issue description

V8 needs to support sysroot. 

V8 and chromium differ in using sysroot and icu_datafile. It is atm not possible to overwrite the defaults for these configs on a per-project basis
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d226bb761b68fdfcc5775be574643404e0aaf09b

commit d226bb761b68fdfcc5775be574643404e0aaf09b
Author: machenbach <machenbach@chromium.org>
Date: Wed Jun 01 13:50:51 2016

sysroot installer: Don't error out for unknown target archs

V8 has several target_archs that don't have a supported
sysroot image, e.g. mips (big endian), ppc, s390.

This prevents the script from failing when run as a hook and
when one of these architectures is used.

BUG= chromium:616032 

Review-Url: https://codereview.chromium.org/2027873004
Cr-Commit-Position: refs/heads/master@{#397129}

[modify] https://crrev.com/d226bb761b68fdfcc5775be574643404e0aaf09b/build/linux/sysroot_scripts/install-sysroot.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c47d3c63695d2999752f5fc61ff171f3ff100553

commit c47d3c63695d2999752f5fc61ff171f3ff100553
Author: machenbach <machenbach@chromium.org>
Date: Mon Jun 06 08:40:15 2016

[build] Use sysroot for linux compilation with clang

This ports the configuration for using a sysroot from
chromium's common.gypi.

This is restricted to clang only.

BUG= chromium:474921 ,  chromium:616032 
LOG=y

Review-Url: https://codereview.chromium.org/2028623002
Cr-Commit-Position: refs/heads/master@{#36729}

[modify] https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553/DEPS
[modify] https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553/gypfiles/standalone.gypi

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/46d8293f50478be702ce00b6ae51f6491a552173

commit 46d8293f50478be702ce00b6ae51f6491a552173
Author: machenbach <machenbach@chromium.org>
Date: Mon Jun 06 11:00:31 2016

Revert of [build] Fix default for target_arch (patchset #1 id:1 of https://codereview.chromium.org/2040803005/ )

Reason for revert:
sysroot logic breaks "make arm"

Original issue's description:
> [build] Fix default for target_arch
>
> Fix after https://codereview.chromium.org/2028623002/
>
> BUG= chromium:474921 ,  chromium:616032 
> TBR=vogelheim@chromium.org, jochen@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/9dcb67dd174fefc98f9c964ef54fed8fe6feb224
> Cr-Commit-Position: refs/heads/master@{#36733}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:474921 ,  chromium:616032 

Review-Url: https://codereview.chromium.org/2039853002
Cr-Commit-Position: refs/heads/master@{#36740}

[modify] https://crrev.com/46d8293f50478be702ce00b6ae51f6491a552173/gypfiles/standalone.gypi

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0e2d92967db1d7502b5b5bed5813dca901ebdf97

commit 0e2d92967db1d7502b5b5bed5813dca901ebdf97
Author: machenbach <machenbach@chromium.org>
Date: Mon Jun 06 11:02:06 2016

Revert of [build] Use sysroot for linux compilation with clang (patchset #5 id:80001 of https://codereview.chromium.org/2028623002/ )

Reason for revert:
sysroot logic breaks "make arm"

Original issue's description:
> [build] Use sysroot for linux compilation with clang
>
> This ports the configuration for using a sysroot from
> chromium's common.gypi.
>
> This is restricted to clang only.
>
> BUG= chromium:474921 ,  chromium:616032 
> LOG=y
>
> Committed: https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553
> Cr-Commit-Position: refs/heads/master@{#36729}

TBR=jochen@chromium.org,vogelheim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:474921 ,  chromium:616032 

Review-Url: https://codereview.chromium.org/2042693003
Cr-Commit-Position: refs/heads/master@{#36741}

[modify] https://crrev.com/0e2d92967db1d7502b5b5bed5813dca901ebdf97/DEPS
[modify] https://crrev.com/0e2d92967db1d7502b5b5bed5813dca901ebdf97/gypfiles/standalone.gypi

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0d4983fbb88b1a1453791778ce29967734bbb366

commit 0d4983fbb88b1a1453791778ce29967734bbb366
Author: machenbach <machenbach@chromium.org>
Date: Wed Jun 08 13:51:13 2016

[build] Ensure target_arch is set correctly in toplevel Makefile

This sets the target_arch for simulator builds.

Fix needed for https://codereview.chromium.org/2028623002/

BUG= chromium:616032 
NOTRY=true

Review-Url: https://codereview.chromium.org/2045173003
Cr-Commit-Position: refs/heads/master@{#36826}

[modify] https://crrev.com/0d4983fbb88b1a1453791778ce29967734bbb366/Makefile

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c4fab3ec25663fd6676f1bddc12a2b5cacec0d54

commit c4fab3ec25663fd6676f1bddc12a2b5cacec0d54
Author: machenbach <machenbach@chromium.org>
Date: Wed Jun 08 15:27:21 2016

[build] Use sysroot for linux compilation with clang

This ports the configuration for using a sysroot from
chromium's common.gypi.

This is restricted to clang only.

BUG= chromium:474921 ,  chromium:616032 
LOG=y

Committed: https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553
Review-Url: https://codereview.chromium.org/2028623002
Cr-Original-Commit-Position: refs/heads/master@{#36729}
Cr-Commit-Position: refs/heads/master@{#36830}

[modify] https://crrev.com/c4fab3ec25663fd6676f1bddc12a2b5cacec0d54/DEPS
[modify] https://crrev.com/c4fab3ec25663fd6676f1bddc12a2b5cacec0d54/gypfiles/standalone.gypi

Blocking: 621726
Status: Fixed (was: Assigned)
This is fixed. It doesn't work with gcc though, but maybe it will work after switching to gn. The only gcc bots we used have a trusty-trusty builder/tester fit.

Sign in to add a comment