Put "Courier New" for Arabic script monospace fallback on inspector, or make "monospace" able to fallback correctly to Arabic on Windows |
|||||
Issue descriptionThe font chain "font-family: Consolas, Lucida Console, monospace;" doesn't provide needed font for Arabic and it makes Arabic to render with a non-monospace font, please turn it to "font-family: Consolas, Lucida Console, Courier New, monospace;" on the below places. https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css&q=Consolas,%20Lucida%20Console&sq=package:chromium&dr=C&l=28 https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html&q=Consolas,%20Lucida%20Console&sq=package:chromium&dr=C&l=44 Or alternatively, make "monospace" somehow able to fallback to Arabic in needed cases, it was actually the subject of Issue 466754 but it just happend when lang="ar" is defined which is not enough. Compare these two: data:text/html;charset=utf8,<span style="font-family: monospace;">%D8%B4%D9%88%D8%A7%D9%84</span> data:text/html;charset=utf8,<span style="font-family: monospace;" lang="ar">%D8%B4%D9%88%D8%A7%D9%84</span>
,
May 31 2016
,
May 31 2016
Over to devtools team.
,
May 31 2016
,
Jul 8 2016
I compared the two data:text/html links, but they look exactly the same for me on Linux in both Chrome 51 and Chrome 54. Another question, why do you need these changes in InspectorOverlayPage.html? Can you provide a specific scenario when fonts are picked improperly?
,
Jul 8 2016
This is about Windows which current font chain is not providing suitable mono-spaced glyphs for Arabic script but the suggested font which previously was default monospace font is providing suitable glyphs for that and it is better to have monospaced glyphs for most scripts possible where it supposed to be.
,
Jul 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/400443255b3609c9c6d323cb08e083fd767ed39c commit 400443255b3609c9c6d323cb08e083fd767ed39c Author: lushnikov <lushnikov@chromium.org> Date: Sat Jul 09 01:30:32 2016 DevTools: add Courier New to support monospace arabic on Windows The current monospace font chain for windows doesn't cover arabic symbols. "Courier New" has all the needed characters, let's fallback to it. BUG= 616020 R=alph Review-Url: https://codereview.chromium.org/2135803002 Cr-Commit-Position: refs/heads/master@{#404558} [modify] https://crrev.com/400443255b3609c9c6d323cb08e083fd767ed39c/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
,
Jul 9 2016
Just checked that the fix is available on 54.0.2793.0. Thank you. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ebra...@gnu.org
, May 31 2016