Issue metadata
Sign in to add a comment
|
Regression: ‘Close’ button on tabstrip is not visible after adding ‘Colorful Spring’ Theme.
Reported by
dmascare...@etouch.net,
May 31 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:52.0.2743.19 (Official Build)Revision b25ac237c4e0eee088839ade87facf7b04ee3a16-refs/branch-heads/2743@{#129}(64-bit) OS: Mac(10.10.5,10.11.4), Mac Retina (10.11.4) Url: https://chrome.google.com/webstore/detail/colorful-spring/jlckghdpbgidbjpfmdpeikmnofmhdkei?hl=en What steps will reproduce the problem? 1. Launch chrome and open 2-3 tabs/webpages. 2. Then navigate to above url and click on ‘Add to chrome’ button. 3. After theme gets added,click on previous tabs and observe. Actual:’Close’ button on tabstrip is not visible for previous tabs. Expected: ‘Close’ button on tabstrip should be visible after step 3. This is regression issue,broken in ‘M 51’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/5121a34129f274edc61a288f73f99b39eb06e1e7..b38be38cee2027dcb827ebc61abb23508b8e5d25?pretty=fuller&n=100 Suspecting: r378367 Good build:51.0.2663.0 Bad build:51.0.2664.0 Note: Issue is not reproducible on Windows and Linux OS.
,
May 31 2016
Marking the above issue as RB-Stable. Feel free to remove if not required. Thank you!
,
Jun 15 2016
Able to reproduce the issue on Mac OS 10.11.5 using chrome latest canary M53-53.0.2768.0. Observed the close button on tab strip is not visible after adding color spring theme. shrike@ - Any update on this bug? Since this issue is marked as ReleaseBlock-Stable could you please check is this issue due to your change, If not please feel free to reassign it to the concerned Dev person. Thanks!
,
Jun 15 2016
I'm the correct owner, and hope to look into this today.
,
Jun 15 2016
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29bd2eed90a5c548ce737aa09225952bfab22461 commit 29bd2eed90a5c548ce737aa09225952bfab22461 Author: shrike <shrike@chromium.org> Date: Thu Jun 16 15:40:16 2016 [Mac][Material Design] Fix problem with tab close button redraw. With a theme installed the close button's "x" can have a different color for the tab active and inactive states. This cl forces the close button to redraw on tab state change so that it displays the "x" in the correct color. R=tapted@chromium.org BUG= 616008 Review-Url: https://codereview.chromium.org/2073523002 Cr-Commit-Position: refs/heads/master@{#400162} [modify] https://crrev.com/29bd2eed90a5c548ce737aa09225952bfab22461/chrome/browser/ui/cocoa/tabs/tab_view.mm
,
Jun 16 2016
,
Jun 17 2016
Tested the same on mac 10.11 chrome version 53.0.2770.0 - ’Close’ button on tab strip is visible for previous tabs after adding the theme. Please find the screenshot Fix works as expected
,
Jun 17 2016
,
Jun 17 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 17 2016
shrike@, can you please merge this CL in to M52 branch by EOD so that it can be picked up for beta promotion scheduled next week.
,
Jun 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab1fa8cfc752cc3f21a6af02b5f5a373f36f02b2 commit ab1fa8cfc752cc3f21a6af02b5f5a373f36f02b2 Author: Jayson Adams <shrike@chromium.org> Date: Mon Jun 20 21:24:50 2016 [Mac][Material Design] Fix problem with tab close button redraw. With a theme installed the close button's "x" can have a different color for the tab active and inactive states. This cl forces the close button to redraw on tab state change so that it displays the "x" in the correct color. R=tapted@chromium.org BUG= 616008 Review-Url: https://codereview.chromium.org/2073523002 Cr-Commit-Position: refs/heads/master@{#400162} (cherry picked from commit 29bd2eed90a5c548ce737aa09225952bfab22461) Review URL: https://codereview.chromium.org/2080973002 . Cr-Commit-Position: refs/branch-heads/2743@{#414} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/ab1fa8cfc752cc3f21a6af02b5f5a373f36f02b2/chrome/browser/ui/cocoa/tabs/tab_view.mm
,
Jun 22 2016
Tested the issue on Mac 10.11.5 using chrome version 52.0.2743.49.Close button of previous tabs is visible after adding the theme. Please find the attached screen cast for the same. Adding TE-Verified labels. Thanks,
,
Jun 22 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lasmiley...@gmail.com
, May 31 201610.3 MB
10.3 MB Download