New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 615995 link

Starred by 2 users
Status: Archived
Owner:
█ shunhsingou@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
hungte@chromium.org
█ stimim@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

wipe-in-place: dchp fails after pivot root in some boards.

Project Member Reported by shunhsingou@chromium.org, May 31 2016 
For some boards, e.g., Ultima or Reks, we found dhcpc fails after pivot root to the wiping tmpfs, and the device fails to inform shopfloor server after wiping.

We found it is caused by '/run' is set to 'read-only' after pivot root.

Before wiping, We use script chromeos_shutdown to unmount stateful partition, and use 'mount bind' to bind important directories, e.g. /sys, /proc, /run, /dev to the tmp rootfs.

The problem is in those boards, chromeos_shutdown unmounts '/run', so the following 'mount bind' mounts the original rootfs to '/wipe_tmpfs/run', making it a read-only filesystem.

The solution is simply run the 'mount bind' before calling chromeos_shutdown.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/fca82708dcb1d31d1a40bab3f72d35cc51bc4d8c

commit fca82708dcb1d31d1a40bab3f72d35cc51bc4d8c
Author: Shun-Hsing Ou <shunhsingou@chromium.org>
Date: Tue May 31 07:07:21 2016

wipe_in_place: bind mount before calling chromeos_shutdown

We use chromeos_shutdown to umount stateful partition, and bind mount
some important directories before pivot_root for wiping. In some factory
branches, e.g. 7548, chromeos_shutdown unmounts /run. This causes
bind mount failing to mount the correct path. To avoid the problem,
it's bettery to bind mount before calling chromeos_shutdown.

BUG= chromium:615995 
TEST=None

Change-Id: I4c04080382b05d6ffcdb51c42ccf52d2ef439463
Reviewed-on: https://chromium-review.googlesource.com/348115
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: WeiHeng Lin <WeiHeng.Lin@quantatw.com>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: WeiHeng Lin <WeiHeng.Lin@quantatw.com>

[modify] https://crrev.com/fca82708dcb1d31d1a40bab3f72d35cc51bc4d8c/sh/wipe_in_tmpfs.sh

Comment 2 by hungte@chromium.org, Aug 11 2016 

Earl: Is this fixed or you'd like to add anything else?

Comment 3 by shunhsingou@chromium.org, Aug 11 2016

Status: Fixed (was: Started)
Fixed and verified in Chell.

Comment 4 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 5 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 6 by dchan@chromium.org, Oct 10 2016

Labels: -VerifyIn-55

Comment 7 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 12 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
►

Sign in to add a comment