Issue metadata
Sign in to add a comment
|
3.6%-9.6% regression in speedometer at 396646:396647 |
||||||||||||||||||||
Issue descriptionStrongly suspecting https://chromium.googlesource.com/chromium/src/+/04269068016b6ee7ac16c1d93c118668ac3a8936 because it recovered when the CL was reverted. Is this an expected outcome?
,
May 31 2016
=== Auto-CCing suspected CL author sebmarchand@chromium.org === Hi sebmarchand@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Disable warning 4702: Unreachable code for the WPO/PGO builds. Author : sebmarchand Commit description: BUG= 490934 Review-Url: https://codereview.chromium.org/2023653002 Cr-Commit-Position: refs/heads/master@{#396647} Commit : 04269068016b6ee7ac16c1d93c118668ac3a8936 Date : Sat May 28 18:58:43 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@396646 605.909 4.84259 5 good chromium@396647 632.07 3.71078 5 bad <-- Bisect job ran on: win_perf_bisect Bug ID: 615981 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests speedometer Test Metric: AngularJS-TodoMVC/AngularJS-TodoMVC Relative Change: 4.32% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6550 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011166005566975184 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5805182982553600 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jun 7 2016
Hum, my CL can't cause this, it's just disabling a warning, it has no impact on the generated code.
,
Jun 15 2016
Should this be marked Fixed since it recovered? (Am new to perf sheriffing :-)
,
Jun 24 2016
Yes, this should be marked fixed. But heads up sebmarchand - it looks like your CL *did* cause this. It dropped down as soon as it was reverted.
,
Jun 27 2016
Nop, there's really no way for my CL to cause this as it doesn't affect the generated code at all (it's just preventing the compiler to stop because of this warning), in fact it has been relanded and it doesn't look like we've observed this since then. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by hablich@chromium.org
, May 31 2016