Regression: Overlapping of info bubble is seen after toggling to fullscreen mode.
Reported by
dmascare...@etouch.net,
May 31 2016
|
|||||||
Issue descriptionTOT Version:53.0.2754.0 (Developer Build)8dbe47eb360b8cdec212900dc46da3e78ce3e018-refs/heads/master@{#396782} 64 bit OS: MAC (10.10.5,10.11.4),Mac Retina (10.11.4) What steps will reproduce the problem? 1.Launch chrome and navigate to https://www.youtube.com/watch?v=Wgf7xyOqzdQ 2. Click ‘Backspace’ key from keyboard and immediately click fullscreen icon of the video. 3. Observe the info bubble. Actual:Overlapping of info bubble is seen after step 2. Expected: Overlapping should not be seen. This is regression issue, broken in ‘M 53’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/a59bfc826308f7bb5abedf4106224daca03f646c..cba6b3081e6bfab05d4874d91f0de8653a80b12e?pretty=fuller&n=100 Suspecting: r396759 Good build:53.0.2753.0 Bad build:53.0.2754.0 Note: Issue is not seen on Windows OS.
,
Jun 1 2016
,
Jun 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1ec367efc1eeae3ba9fcb7309d4e0be44e6c44f commit e1ec367efc1eeae3ba9fcb7309d4e0be44e6c44f Author: mgiuca <mgiuca@chromium.org> Date: Mon Jun 06 05:01:15 2016 Fixed overlapping subtle notifications on Mac. Can happen when a fullscreen/pointer-lock bubble and a new-back-shortcut bubble are visible at the same time. Now the new bubble will dismiss the old bubble (which is the behaviour on Views platforms). BUG= 615971 Review-Url: https://codereview.chromium.org/2028963002 Cr-Commit-Position: refs/heads/master@{#397973} [modify] https://crrev.com/e1ec367efc1eeae3ba9fcb7309d4e0be44e6c44f/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
,
Jun 6 2016
Fixed. Does this need a merge to M52 or is it good enough to just let it slide to be fixed in M53?
,
Jun 6 2016
+Ainslie to get his take on it, but I'm disinclined to merge this myself.
,
Jun 6 2016
Waiting SGTM.
,
Jun 13 2016
This needs to be merged for my heuristics fix to merge properly. We should Just Merge This.
,
Jun 14 2016
Requesting a merge of e1ec367efc1eeae3ba9fcb7309d4e0be44e6c44f / r397973 to M52. Rationale: Fixes a small regression introduced in M52. Not strictly necessary, but pkasting@ wants to merge something that depends on this (see #7).
,
Jun 14 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/011b06586201c9bdcd9d1959455a0454ac028be2 commit 011b06586201c9bdcd9d1959455a0454ac028be2 Author: Matt Giuca <mgiuca@chromium.org> Date: Tue Jun 14 04:06:37 2016 Fixed overlapping subtle notifications on Mac. Can happen when a fullscreen/pointer-lock bubble and a new-back-shortcut bubble are visible at the same time. Now the new bubble will dismiss the old bubble (which is the behaviour on Views platforms). BUG= 615971 Review-Url: https://codereview.chromium.org/2028963002 Cr-Commit-Position: refs/heads/master@{#397973} (cherry picked from commit e1ec367efc1eeae3ba9fcb7309d4e0be44e6c44f) Review URL: https://codereview.chromium.org/2063103002 . Cr-Commit-Position: refs/branch-heads/2743@{#346} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/011b06586201c9bdcd9d1959455a0454ac028be2/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/011b06586201c9bdcd9d1959455a0454ac028be2 commit 011b06586201c9bdcd9d1959455a0454ac028be2 Author: Matt Giuca <mgiuca@chromium.org> Date: Tue Jun 14 04:06:37 2016 Fixed overlapping subtle notifications on Mac. Can happen when a fullscreen/pointer-lock bubble and a new-back-shortcut bubble are visible at the same time. Now the new bubble will dismiss the old bubble (which is the behaviour on Views platforms). BUG= 615971 Review-Url: https://codereview.chromium.org/2028963002 Cr-Commit-Position: refs/heads/master@{#397973} (cherry picked from commit e1ec367efc1eeae3ba9fcb7309d4e0be44e6c44f) Review URL: https://codereview.chromium.org/2063103002 . Cr-Commit-Position: refs/branch-heads/2743@{#346} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/011b06586201c9bdcd9d1959455a0454ac028be2/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
,
Jun 15 2016
Tested the same on mac 10.11 chrome version 52.0.2743.41 - No overlapping of info bubble is seen after step 2. Fix works as expected |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mgiuca@chromium.org
, May 31 2016