New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615970 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
(currently inactive on Chromium)
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Flickering of header is observed on www.facebook.com

Reported by dchau...@etouch.net, May 31 2016

Issue description

Chrome Version: 53.0.2753.0 (Official Build) bb0c85e1aaa882aa7c4c40b0e3da609573f07d8f-refs/heads/master@{#396745} 32/64-bit.
OS: Windows(7,8,10), Linux (Ubuntu 14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome and login to www.facebook.com with valid credentials.
2. Click on 'Profile' icon at header of facebook (Navigates to profile section).
3. Now, Scroll up the page using mouse wheel and observe the header part of facebook.

On scrooling, Header of facebook gets flicker.
On scrooling, Header of facebook should not flicker.

This is a regression issue,broken in M-53 series, below is bisect info.

Good build: 53.0.2748.0 
Bad build: 53.0.2750.0 

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/44ac07c8316385250002371bec549fc6621826ec..2ab1696fd3a8d9e00f6736f7e5dba15f761452db?pretty=fuller&n=100

Suspecting: r396061

@ymalik: Kindly help to reassign, if your changes are not related to this issue.

Note:
1. This issue is not seen on Mac OS. 
2. To reproduce the issue frequently, repeat the step-3, 2-3 times.
3. This issue is not seen on other browsers like 'Firefox' and 'IE'.

Kindly review the attached screen-cast for reference.
 

Comment 1 by dchau...@etouch.net, May 31 2016

Actual behavior.mp4
1.0 MB Download
Labels: ReleaseBlock-Beta
Marking the above issue as RB-BETA as this is recent regression.

Feel free to remove if not required.

Thank you!
Cc: skobes@chromium.org
Labels: -ReleaseBlock-Beta
From the attached video, I think you're referring to the top nav changing in height and not flickering? Is this true?

I can repro that on stable, so I don't think this is caused by r396061. It could be related to the takeover logic in some way though. I'll investigate further.
Labels: Needs-Feedback
Labels: -Needs-Feedback
With response to comment #4: No, it's a flickering related issue only. i.e. on scrolling up the page using mouse wheel, header part of facebook gets flicker.

Again done the bisect on different machine and found the same range as mentioned in bug.

Note: Unable to capture the flickering in the video, but the same is reproducible on steps which is mentioned in the bug.

Comment 7 by ymalik@chromium.org, Jun 21 2016

Status: Started (was: Assigned)

Comment 8 by skobes@chromium.org, Jun 23 2016

FYI, I don't see a "flicker" in the sense of the header disappearing and reappearing, but I do see the height change mentioned in #4, which appears to be a 1px shift when the scroll offset exceeds the height of the header.

Comment 9 by ymalik@chromium.org, Jun 27 2016

I was able to repro the flicker.

For some background, when a main thread scrolling reason gets added on the main thread, we send a "takeover" message to the compositor thread, telling it to continue its scroll offset animation on the main thread.

The problem is that there could be a delay between when the main thread scrolling reason gets added and when the takeover message is sent. As a result, we continue to animate on the compositor for longer than we should.

Currently in Stable, we still see the flicker once in a while, but this got worse with r396061.

https://codereview.chromium.org/2085873004/ brings it back to what's currently in stable.

@dchaubey, can you verify this on the latest canary and close the issue if resolved?

With response to comment #9: Retested the above issue on Windows-7 machine using latest canary: 53.0.2781.0 (Official Build). It's seems to be fixed and working as intended i.e. header of facebook doesn't flicker on scrolling up the page using mouse wheel.
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 7 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Closing as per #10
Labels: Hotlist-Input-Dev

Sign in to add a comment